[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15730576#comment-15730576 ] ASF subversion and git services commented on CB-11947: -- Commit 6376f76762cfece37a2d9a82d6bfae1017ff9acb in cordova-plugin-file's branch refs/heads/4.3.x from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=6376f76 ] CB-11947 fixed typo that occurs when adding file-transfer plugin This closes #197 > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546994#comment-15546994 ] ASF GitHub Bot commented on CB-11947: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/197 > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546992#comment-15546992 ] ASF subversion and git services commented on CB-11947: -- Commit 6376f76762cfece37a2d9a82d6bfae1017ff9acb in cordova-plugin-file's branch refs/heads/master from [~auso] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=6376f76 ] CB-11947 fixed typo that occurs when adding file-transfer plugin This closes #197 > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546865#comment-15546865 ] ASF GitHub Bot commented on CB-11947: - Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 LGTM > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546842#comment-15546842 ] ASF GitHub Bot commented on CB-11947: - Github user jcesarmobile commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81866162 --- Diff: plugin.xml --- @@ -109,8 +109,10 @@ xmlns:android="http://schemas.android.com/apk/res/android"; - -The Android Persistent storage location now defaults to "Internal". Please check this plugins README to see if you application needs any changes in its config.xml. + + + +The Android Persistent storage location now defaults to "Internal". Please check this plugin's README to see if your application needs any changes in its config.xml. --- End diff -- its config.xml. should be it's config.xml. > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546844#comment-15546844 ] ASF GitHub Bot commented on CB-11947: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/197/commits/97913236aac42b1e19c765495552842a99b26489) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/47//PLATFORM=android/artifact/) | > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546831#comment-15546831 ] ASF GitHub Bot commented on CB-11947: - Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 LGTM > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546785#comment-15546785 ] ASF GitHub Bot commented on CB-11947: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81862737 --- Diff: plugin.xml --- @@ -119,11 +121,7 @@ If this is an update to an existing application that did not specify an "Android "" to config.xml in order for the application to find previously stored files. - --- End diff -- tab this closing tag in so it is inline with the opening `` tag > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546787#comment-15546787 ] ASF GitHub Bot commented on CB-11947: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81862840 --- Diff: plugin.xml --- @@ -109,8 +109,10 @@ xmlns:android="http://schemas.android.com/apk/res/android"; - -The Android Persistent storage location now defaults to "Internal". Please check this plugins README to see if you application needs any changes in its config.xml. + + + --- End diff -- I think you tabbed the opening info tag one time too much. > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546786#comment-15546786 ] ASF GitHub Bot commented on CB-11947: - Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/197#discussion_r81863003 --- Diff: plugin.xml --- @@ -109,8 +109,10 @@ xmlns:android="http://schemas.android.com/apk/res/android"; - -The Android Persistent storage location now defaults to "Internal". Please check this plugins README to see if you application needs any changes in its config.xml. + + + --- End diff -- `` should be in line with the `` tag below > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546392#comment-15546392 ] ASF GitHub Bot commented on CB-11947: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file/pull/197 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-file/pull/197/commits/dd18b50900bdf05826c72314a8ffd831f8fc4599) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/46//PLATFORM=android/artifact/) | > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11947) Bad English in feedback
[ https://issues.apache.org/jira/browse/CB-11947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546348#comment-15546348 ] ASF GitHub Bot commented on CB-11947: - GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-file/pull/197 CB-11947 fixed typo that occurs when adding file-transfer plugin to android ### Platforms affected ### What does this PR do? CB-11947 fixed typo that occurs when adding file-transfer plugin to android ### What testing has been done on this change? Installed cordova-plugin-file for multiple platforms to check ### Checklist - [X ] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secret...@apache.org. - [X ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/audreyso/cordova-plugin-file CB-11947 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/197.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #197 commit dd18b50900bdf05826c72314a8ffd831f8fc4599 Author: audreyso Date: 2016-10-04T18:13:10Z CB-11947 fixed typo that occurs when adding file-transfer plugin > Bad English in feedback > --- > > Key: CB-11947 > URL: https://issues.apache.org/jira/browse/CB-11947 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin File Transfer > Environment: Ubuntu 16.04 >Reporter: Sean Hankins >Assignee: Audrey So >Priority: Trivial > > When adding file transfer plug-in, I get bad English for 2 of 2 platforms > I've added (android, ios): > "The Android Persistent storage location now defaults to "Internal". Please > check this plugins README to see if you application needs any changes in its > config.xml." -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
