[jira] [Commented] (CB-12010) [INAppBrowser] Opening a relative path in _system would crash the app on Android 7.0

2016-10-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581794#comment-15581794
 ] 

ASF GitHub Bot commented on CB-12010:
-

Github user alsorokin closed the pull request at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191


> [INAppBrowser] Opening a relative path in _system would crash the app on 
> Android 7.0
> 
>
> Key: CB-12010
> URL: https://issues.apache.org/jira/browse/CB-12010
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: Master
> Environment: Android API level 24
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: triaged
>
> This issue can be reproduced by running manual tests for InAppBrowser and 
> clicking on `target=_system` button in `Local URL` section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12010) [INAppBrowser] Opening a relative path in _system would crash the app on Android 7.0

2016-10-17 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15581792#comment-15581792
 ] 

ASF subversion and git services commented on CB-12010:
--

Commit ab696f6ebd64b93ae46aac9816562ce194e32607 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~alsorokin]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=ab696f6
 ]

CB-12010 (android) Catch FileUriExposedException


> [INAppBrowser] Opening a relative path in _system would crash the app on 
> Android 7.0
> 
>
> Key: CB-12010
> URL: https://issues.apache.org/jira/browse/CB-12010
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: Master
> Environment: Android API level 24
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: triaged
>
> This issue can be reproduced by running manual tests for InAppBrowser and 
> clicking on `target=_system` button in `Local URL` section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12010) [INAppBrowser] Opening a relative path in _system would crash the app on Android 7.0

2016-10-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576008#comment-15576008
 ] 

ASF GitHub Bot commented on CB-12010:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/191/commits/beac334dc814c54a97b272e6e2bfc7db46a0754a)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/83//PLATFORM=android/artifact/)
 |
 



> [INAppBrowser] Opening a relative path in _system would crash the app on 
> Android 7.0
> 
>
> Key: CB-12010
> URL: https://issues.apache.org/jira/browse/CB-12010
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: Master
> Environment: Android API level 24
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: triaged
>
> This issue can be reproduced by running manual tests for InAppBrowser and 
> clicking on `target=_system` button in `Local URL` section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12010) [INAppBrowser] Opening a relative path in _system would crash the app on Android 7.0

2016-10-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575424#comment-15575424
 ] 

ASF GitHub Bot commented on CB-12010:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191
  
LGTM


> [INAppBrowser] Opening a relative path in _system would crash the app on 
> Android 7.0
> 
>
> Key: CB-12010
> URL: https://issues.apache.org/jira/browse/CB-12010
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: Master
> Environment: Android API level 24
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: triaged
>
> This issue can be reproduced by running manual tests for InAppBrowser and 
> clicking on `target=_system` button in `Local URL` section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12010) [INAppBrowser] Opening a relative path in _system would crash the app on Android 7.0

2016-10-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575338#comment-15575338
 ] 

ASF GitHub Bot commented on CB-12010:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/191/commits/fcee5a357754aa6734169169c39b04a2de2272aa)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/82//PLATFORM=android/artifact/)
 |
 



> [INAppBrowser] Opening a relative path in _system would crash the app on 
> Android 7.0
> 
>
> Key: CB-12010
> URL: https://issues.apache.org/jira/browse/CB-12010
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: Master
> Environment: Android API level 24
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: triaged
>
> This issue can be reproduced by running manual tests for InAppBrowser and 
> clicking on `target=_system` button in `Local URL` section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12010) [INAppBrowser] Opening a relative path in _system would crash the app on Android 7.0

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15572706#comment-15572706
 ] 

ASF GitHub Bot commented on CB-12010:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-inappbrowser/pull/191/commits/efae0573dd6e56205a3ce3615c9ef8edf0ce7623)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-inappbrowser-pr/81//PLATFORM=android/artifact/)
 |
 



> [INAppBrowser] Opening a relative path in _system would crash the app on 
> Android 7.0
> 
>
> Key: CB-12010
> URL: https://issues.apache.org/jira/browse/CB-12010
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: Master
> Environment: Android API level 24
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: triaged
>
> This issue can be reproduced by running manual tests for InAppBrowser and 
> clicking on `target=_system` button in `Local URL` section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12010) [INAppBrowser] Opening a relative path in _system would crash the app on Android 7.0

2016-10-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571552#comment-15571552
 ] 

ASF GitHub Bot commented on CB-12010:
-

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191

CB-12010 (android) Catch FileUriExposedException

### Platforms affected
Android

### What does this PR do?
Fixes a crash on Android 7.0 devices when trying to open a file URI in the 
system browser.

### What testing has been done on this change?
Manual testing on Android 7.0 emulator

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change - *can 
only be tested manually*.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alsorokin/cordova-plugin-inappbrowser CB-12010

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/191.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #191


commit efae0573dd6e56205a3ce3615c9ef8edf0ce7623
Author: Alexander Sorokin 
Date:   2016-10-13T10:29:23Z

CB-12010 (android) Catch FileUriExposedException




> [INAppBrowser] Opening a relative path in _system would crash the app on 
> Android 7.0
> 
>
> Key: CB-12010
> URL: https://issues.apache.org/jira/browse/CB-12010
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin InAppBrowser
>Affects Versions: Master
> Environment: Android API level 24
>Reporter: Alexander Sorokin
>Assignee: Alexander Sorokin
>  Labels: triaged
>
> This issue can be reproduced by running manual tests for InAppBrowser and 
> clicking on `target=_system` button in `Local URL` section.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org