[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127807#comment-16127807 ] ASF subversion and git services commented on CB-12015: -- Commit 5bda4df7fad5460d5108d7af3ce19f6072e8bcdc in cordova-android's branch refs/heads/master from [~macdonst] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=5bda4df ] Revert CB-12015: initial-scale values less than 1.0 are ignored on Android > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127808#comment-16127808 ] ASF subversion and git services commented on CB-12015: -- Commit dce3b7ed6c5c7e2329f66c6869f800a9028d6c54 in cordova-android's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-android.git;h=dce3b7e ] Merge pull request #402 from macdonst/master Revert CB-12015: initial-scale values less than 1.0 are ignored on Android > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126695#comment-16126695 ] Simon MacDonald commented on CB-12015: -- I've sent a PR for Joe to review to revert back to the previous behaviour. https://github.com/apache/cordova-android/pull/402 > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126604#comment-16126604 ] Håkon Nilsen commented on CB-12015: --- You can also revert the change by adding `webView.getSettings().setUseWideViewPort(false);` in your onCreate. That should fix it even if you don't have the project as a library. > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126499#comment-16126499 ] Kyle commented on CB-12015: --- I agree with [~hnilsen] here. Updating to the latest version of cordova caused all of our pages to load fully zoomed out, like they were being viewed in "desktop mode" in mobile chrome or something. This might be caused by our html files not including the proper meta tags, but they've always worked before and it's not feasible for me to go edit hundreds of html files right now. Thankfully, our implementation uses cordova as a library in our custom in-house android application, so I can simply remove the 2 lines that were added for this fix. However, that also causes maintenance issues with our code going forward, as we have to remember to remove these 2 lines each time we update cordova versions. Hopefully a new fix will be incoming that somehow makes this optional or returns to the prior version. Thanks! > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16065306#comment-16065306 ] Joe Bowser commented on CB-12015: - See CB-12015 for the aftermath of this fix. > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16062962#comment-16062962 ] Håkon Nilsen commented on CB-12015: --- Wait, this is the wrong approach people. Setting settings.setUseWideViewPort(true); as default should not be done. In this case; initial-scale=1.1, width=device-width - The view is 10% wider than device width, with this setting on (should be scaled 10%, but remain within device-width) In this case; initial-scale=1.1 (without width=device-width) - The view is as many pixels as the phone is - 980px in my case. This is NOT the way to go about fixing the initial problem. If anything, it should be introduced as an optional thing to be turned on. > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994038#comment-15994038 ] ASF subversion and git services commented on CB-12015: -- Commit e3b3bcd75fbc2070ad5d80adda98840254a13c90 in cordova-android's branch refs/heads/6.2.x from [~macdonst] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=e3b3bcd ] CB-12015: initial-scale values less than 1.0 are ignored on Android This closes #376 > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991239#comment-15991239 ] ASF GitHub Bot commented on CB-12015: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/376 > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991238#comment-15991238 ] ASF subversion and git services commented on CB-12015: -- Commit ee1165ea332391b81cef181e6f8f928c883673f2 in cordova-android's branch refs/heads/master from [~macdonst] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=ee1165e ] CB-12015: initial-scale values less than 1.0 are ignored on Android This closes #376 > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977888#comment-15977888 ] ASF GitHub Bot commented on CB-12015: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/376 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr=h1) Report > Merging [#376](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/e13e15d3e9aa4b9a61c6ece434e7c023fa5c3553?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/376/graphs/tree.svg?width=650=150=pr=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #376 +/- ## === Coverage 42.07% 42.07% === Files 14 14 Lines1338 1338 Branches 245 245 === Hits 563 563 Misses775 775 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr=footer). Last update [e13e15d...c06b96c](https://codecov.io/gh/apache/cordova-android/pull/376?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977875#comment-15977875 ] Simon MacDonald commented on CB-12015: -- PR sent for Joe to take a look over. > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977874#comment-15977874 ] ASF GitHub Bot commented on CB-12015: - GitHub user macdonst opened a pull request: https://github.com/apache/cordova-android/pull/376 Fix for CB-12015: initial-scale values less than 1.0 are ignored on Android ### Platforms affected Android ### What does this PR do? Fixed an issue where the meta tag viewport is ignored if scaling is less than 1.0. ### What testing has been done on this change? I tested it on a couple of devices running Android 5.0 and 6.0. ### Checklist - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/macdonst/cordova-android cb12015 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/376.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #376 commit c06b96cd4562b228b015b6cbebd8e0948744d2db Author: Simon MacDonaldDate: 2017-04-21T00:41:54Z CB-12015: initial-scale values less than 1.0 are ignored on Android > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972791#comment-15972791 ] Juan David Nicholls Cardona commented on CB-12015: -- Guys, please accept this change. For the moment, what's the temporal solution to scale the viewport? Thanks in advance, Nicholls > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: cordova-android@5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576625#comment-15576625 ] Joe Bowser commented on CB-12015: - Apparently this only really works on 5.0 or later anyway, but I'm cool with this change. > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12015) initial-scale values less than 1.0 are ignored on Android
[ https://issues.apache.org/jira/browse/CB-12015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15573197#comment-15573197 ] Joe Bowser commented on CB-12015: - Adding this only seems to work on Android 6.0 and later. I'll need to do more testing on Android 5.0 and Android 4.4, since those devices aren't charged at the moment. > initial-scale values less than 1.0 are ignored on Android > - > > Key: CB-12015 > URL: https://issues.apache.org/jira/browse/CB-12015 > Project: Apache Cordova > Issue Type: Bug > Components: Android >Affects Versions: 5.2.2 >Reporter: Simon MacDonald > > So, the way cordova-android is right now if I use: > > Everything is good. Increasing the scale to 2.0 or 3.0 correctly makes > everything bigger. However, setting: > > has no effect whatsoever. > Going into the SystemWebViewEngine class and adding: > settings.setUseWideViewPort(true); > settings.setLoadWithOverviewMode(true); > to initWebViewSettings() method then allows me to scale the viewport down. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org