[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624490#comment-16624490 ] ASF GitHub Bot commented on CB-12242: - jayvdb commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-423716900 I think https://github.com/apache/cordova-fetch/issues/46 is a reasonable starting point, as the work would need to be done in cordova-fetch first, and that is where the complexity of tight integration with npm exists. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624488#comment-16624488 ] ASF GitHub Bot commented on CB-12242: - jayvdb commented on issue #14: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-fetch/pull/14#issuecomment-423716849 See also https://github.com/apache/cordova-fetch/issues/46 for a possible way to introduce supporting other package managers without adding CLI / config args which give the feeling that something is supported. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623678#comment-16623678 ] ASF GitHub Bot commented on CB-12242: - janpio commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-423547090 (Best create a new issue so this doesn't get lost @jayvdb as a possible starting point) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16623668#comment-16623668
]
ASF GitHub Bot commented on CB-12242:
-
jayvdb commented on issue #292: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-423544491
fwiw, I was able to get yarn working with cordova@8 and a very basic yarn
wrapper (below) and a symlink `npm`. The wrapper is needed because `npm
install foo` needs to invoke `yarn add foo`.
```bash
#!/bin/bash
args="$@"
arg2="$2"
if [ "$1" = "install" ] && [ -n "$arg2" ] && [ "${arg2/--//}" = "$arg2" ] ;
then
args="${args/install/add}"
fi
yarn $args
```
A better version of the wrapper is needed to get `--save-exact` working.
And [`pnpm`](https://github.com/pnpm/pnpm) with a symlink `npm` works
without any wrapper.
No doubt this wouldnt cover all possible usages, and shouldnt be supportable
by the core team, but it seems reasonable that cordova-fetch can use other
package managers used by the project (e.g. detected via
https://github.com/apache/cordova-fetch/issues/46 , or an explicit and
non-friendly option ), and include a warning that only npm is supported.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-fetch
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using
> cordova plugin add), especially if I need to re-add the plugins. My
> suggestion is to update the cordova cli to start using yarn js instead of npm
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally
> sure how to proceed on this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527503#comment-16527503 ] ASF GitHub Bot commented on CB-12242: - raphinesse commented on issue #14: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-fetch/pull/14#issuecomment-401331752 https://github.com/apache/cordova-cli/pull/292#issuecomment-401331607 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527504#comment-16527504
]
ASF GitHub Bot commented on CB-12242:
-
raphinesse closed pull request #14: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-fetch/pull/14
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/index.js b/index.js
index 8bb6326..37790c6 100644
--- a/index.js
+++ b/index.js
@@ -29,7 +29,7 @@ var isGitUrl = require('is-git-url');
var hostedGitInfo = require('hosted-git-info');
/*
- * A function that npm installs a module from npm or a git url
+ * A function that installs a module from package manager or a git url
*
* @param {String} target the packageID or git url
* @param {String} dest destination of where to install the module
@@ -39,13 +39,13 @@ var hostedGitInfo = require('hosted-git-info');
*
*/
module.exports = function (target, dest, opts) {
-var fetchArgs = opts.link ? ['link'] : ['install'];
opts = opts || {};
+var manager = opts.manager || 'npm';
+var fetchArgs = opts.link ? ['link'] : manager === 'yarn' ? ['add'] :
['install'];
var tree1;
var nodeModulesDir = dest;
-// check if npm is installed
-return module.exports.isNpmInstalled()
+return isPackageManagerInstalled(manager)
.then(function () {
if (dest && target) {
// add target to fetchArgs Array
@@ -61,16 +61,16 @@ module.exports = function (target, dest, opts) {
}
} else return Q.reject(new CordovaError('Need to supply a target
and destination'));
-// set the directory where npm install will be run
+// set the directory where install command will be run
opts.cwd = dest;
-// npm should use production by default when install is npm run
+// package manager should use production by default when install
command is run
if ((opts.production) || (opts.production === undefined)) {
fetchArgs.push('--production');
opts.production = true;
}
-// if user added --save flag, pass it to npm install command
+// if user added --save flag, pass it to install command
if (opts.save_exact) {
events.emit('verbose', 'saving exact');
fetchArgs.push('--save-exact');
@@ -80,16 +80,16 @@ module.exports = function (target, dest, opts) {
} else {
fetchArgs.push('--no-save');
}
-// Grab json object of installed modules before npm install
+// Grab json object of installed modules before install command
return depls(nodeModulesDir);
})
.then(function (depTree) {
tree1 = depTree;
// install new module
-return superspawn.spawn('npm', fetchArgs, opts);
+return superspawn.spawn(manager, fetchArgs, opts);
})
.then(function (output) {
-// Grab object of installed modules after npm install
+// Grab object of installed modules after install command
return depls(nodeModulesDir);
})
.then(function (depTree2) {
@@ -111,8 +111,8 @@ module.exports = function (target, dest, opts) {
* If a module already exists in node_modules, the diff will be blank.
* cordova-fetch will use trimID in that case.
*
- * @param {Object} obj1 json object representing installed modules before
latest npm install
- * @param {Object} obj2 json object representing installed modules after
latest npm install
+ * @param {Object} obj1 json object representing installed modules before
latest install command
+ * @param {Object} obj2 json object representing installed modules after
latest install command
*
* @return {String} String containing the key value of the difference
between the two objects
*
@@ -137,6 +137,7 @@ function getJsonDiff (obj1, obj2) {
// only return the first element
return result[0];
}
+
/*
* Takes the specified target and returns the moduleID
* If the git repoName is different than moduleID, then the
@@ -206,7 +207,6 @@ function trimID (target) {
* @return {String|Error} Returns the absolute url for the module or throws a
error
*
*/
-
function getPath (id, dest, target) {
var destination = path.resolve(path.join(dest, id));
var finalDest = fs.existsSync(destination) ? destination :
searchDirForTarget(dest, target);
@@ -219,6 +219,7 @@ function getPath (id, dest, target) {
}
module.exports.getPath = getPath;
+
/*
*
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527507#comment-16527507
]
ASF GitHub Bot commented on CB-12242:
-
raphinesse closed pull request #610: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-lib/pull/610
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/cordova/plugin/add.js b/src/cordova/plugin/add.js
index 65a75812c..f86c0d9e5 100644
--- a/src/cordova/plugin/add.js
+++ b/src/cordova/plugin/add.js
@@ -89,7 +89,8 @@ function add (projectRoot, hooksRunner, opts) {
variables: opts.cli_variables,
is_top_level: true,
save_exact: opts['save-exact'] || false,
-production: opts.production
+production: opts.production,
+manager: opts.manager
};
return module.exports.determinePluginTarget(projectRoot,
cfg, target, fetchOptions).then(function (resolvedTarget) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-fetch
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using
> cordova plugin add), especially if I need to re-add the plugins. My
> suggestion is to update the cordova cli to start using yarn js instead of npm
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally
> sure how to proceed on this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527506#comment-16527506 ] ASF GitHub Bot commented on CB-12242: - raphinesse commented on issue #610: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-lib/pull/610#issuecomment-401331818 https://github.com/apache/cordova-cli/pull/292#issuecomment-401331607 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527501#comment-16527501 ] ASF GitHub Bot commented on CB-12242: - raphinesse commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-401331607 @qkdreyer I can understand your desire to use your package manager of choice with cordova. But with how Cordova currently uses npm, adding support for additional package managers is just not feasible. I just recently completely refactored `cordova-fetch`, the main component to use npm in Cordova. This resolved a *massive* amount of bugs and performance problems. Unfortunately, the new implementation had to be even more tightly coupled to npm to achieve this. However, the performance problems you mentioned in the original issue might be resolved already in `cordova@nightly` because of this. Please give it a try. My long term goal is to get to a point where Cordova does not have to do any package management at all. But that's still a long way to go, *if* we will ever get there. Until then, I would like to avoid any *additional* complexity introduced to the whole package management process. I'll play the bad guy here and close this and the other related PRs. I'm under the impression that this reflects the general stance among the Cordova tooling team. Please note that my decision is not authoritative in any respect. If someone disagrees, they should just reopen. I'm sorry that this did not come up during discussion in the issue before you created your PRs. :bowing_man: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-fetch >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527502#comment-16527502
]
ASF GitHub Bot commented on CB-12242:
-
raphinesse closed pull request #292: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-cli/pull/292
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/cli.js b/src/cli.js
index 7791b303..72dd9823 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -453,6 +453,12 @@ function cli (inputArgs) {
args.production = true;
}
+if (args.yarn) {
+args.manager = 'yarn';
+} else {
+args.manager = 'npm';
+}
+
if (args.save === undefined) {
// User explicitly did not pass in save
args.save = conf.get('autosave');
@@ -486,7 +492,8 @@ function cli (inputArgs) {
save_exact: args['save-exact'] || false,
shrinkwrap: args.shrinkwrap || false,
force: args.force || false,
-production: args.production
+production: args.production,
+manager: args.manager
};
return cordova[cmd](subcommand, targets, download_opts);
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-fetch
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using
> cordova plugin add), especially if I need to re-add the plugins. My
> suggestion is to update the cordova cli to start using yarn js instead of npm
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally
> sure how to proceed on this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505747#comment-16505747 ] ASF GitHub Bot commented on CB-12242: - qkdreyer commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-395661577 Not sure what do you mean here guys... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500652#comment-16500652 ] ASF GitHub Bot commented on CB-12242: - Bessonov commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-394447873 Fully agree with @dpogue. Personally I think it's OK to provide some parameter to call external managers or scripts to do tasks, but without any support. This pull request do it wrong. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500647#comment-16500647 ] ASF GitHub Bot commented on CB-12242: - japj commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-394446337 I'm not familiar with any recent changes to npm w.r.t. offline support, but we have internally standardized on yarn for offline mirror support during building (also for not-cordova related projects). I can imagine that might also be the case for other people/companies? I'd be interested in thoughts about resolving that in a nice way This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500500#comment-16500500 ] ASF GitHub Bot commented on CB-12242: - dpogue commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-394422962 Not speaking for anyone else here, but I'm not especially in favour of adding additional complexity and maintenance burden to several layers of Cordova libraries for very little benefit. Cordova made the decision to use npm, and with the improvements in npm 5 and 6 it's arguable whether there's any advantage to yarn (especially in this limited use case). We know that there are some issues with how cordova-fetch is using npm, but I'd rather fix those as opposed to doubling the amount of testing everyone needs to do to support two package managers with different command syntaxes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500354#comment-16500354 ] ASF GitHub Bot commented on CB-12242: - c-emil commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-394390682 Can anyone move forward with this PR please? It would be really appreciated to have this merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467409#comment-16467409
]
ASF GitHub Bot commented on CB-12242:
-
Bessonov commented on a change in pull request #292: CB-12242 : Use yarn
instead of npm
URL: https://github.com/apache/cordova-cli/pull/292#discussion_r186724549
##
File path: src/cli.js
##
@@ -486,7 +492,8 @@ function cli (inputArgs) {
save_exact: args['save-exact'] || false,
shrinkwrap: args.shrinkwrap || false,
force: args.force || false,
-production: args.production
+production: args.production,
+manager: args.manager
Review comment:
why not just `args.manager || 'npm'`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using
> cordova plugin add), especially if I need to re-add the plugins. My
> suggestion is to update the cordova cli to start using yarn js instead of npm
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally
> sure how to proceed on this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463555#comment-16463555 ] ASF GitHub Bot commented on CB-12242: - japj commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-386537971 is there anyone that can help with progressing this item further? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442076#comment-16442076 ] ASF GitHub Bot commented on CB-12242: - qkdreyer commented on issue #14: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-fetch/pull/14#issuecomment-382297914 I've just removed the out of date comments and npm keyword from other comments. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442056#comment-16442056 ] ASF GitHub Bot commented on CB-12242: - qkdreyer commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-382293012 It depends on both https://github.com/apache/cordova-fetch/pull/14 and https://github.com/apache/cordova-lib/pull/610 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442049#comment-16442049 ] ASF GitHub Bot commented on CB-12242: - japj commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-382292109 Does this also depend on https://github.com/apache/cordova-fetch/pull/14 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435269#comment-16435269 ] ASF GitHub Bot commented on CB-12242: - janpio commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-380745831 Nope sorry, I don't know anything about the `cordova-cli` codebase. Hope someone else who does will come along and review and merge this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435238#comment-16435238 ] ASF GitHub Bot commented on CB-12242: - qkdreyer commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-380739234 I've just fixed the code style issue. Could you merge it @janpio ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434458#comment-16434458 ] ASF GitHub Bot commented on CB-12242: - HeatherLemieux commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-380569957 Any updates on this? Would love for this to get merged in. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16384873#comment-16384873 ] ASF GitHub Bot commented on CB-12242: - janpio commented on issue #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-370184568 Tests are failing because of a code style problem: > C:\projects\cordova-cli\src\cli.js > 496:34 error Unexpected trailing comma comma-dangle Could you please fix that so the actual tests can run an this can possibly be merged? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380044#comment-16380044 ] Marc Bornträger commented on CB-12242: -- Is there an update on this? I would love to see the mentioned cordova plugins using yarn as well! At the moment it is always a package-lock.json file generated for me when I do something with these cordava plugins. It's really annoying... > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374507#comment-16374507
]
ASF GitHub Bot commented on CB-12242:
-
janpio commented on a change in pull request #14: CB-12242 : Use yarn instead
of npm
URL: https://github.com/apache/cordova-fetch/pull/14#discussion_r170283466
##
File path: index.js
##
@@ -39,13 +39,14 @@ var hostedGitInfo = require('hosted-git-info');
*
*/
module.exports = function (target, dest, opts) {
-var fetchArgs = opts.link ? ['link'] : ['install'];
opts = opts || {};
+var manager = opts.manager || 'npm';
+var fetchArgs = opts.link ? ['link'] : manager === 'yarn' ? ['add'] :
['install'];
var tree1;
var nodeModulesDir = dest;
// check if npm is installed
Review comment:
this line says that it checks if "npm is installed". this is not true any
more, also pretty self explaining now per function name, so comment can just be
removed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using
> cordova plugin add), especially if I need to re-add the plugins. My
> suggestion is to update the cordova cli to start using yarn js instead of npm
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally
> sure how to proceed on this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374476#comment-16374476
]
ASF GitHub Bot commented on CB-12242:
-
qkdreyer commented on a change in pull request #14: CB-12242 : Use yarn instead
of npm
URL: https://github.com/apache/cordova-fetch/pull/14#discussion_r170277360
##
File path: index.js
##
@@ -39,13 +39,14 @@ var hostedGitInfo = require('hosted-git-info');
*
*/
module.exports = function (target, dest, opts) {
-var fetchArgs = opts.link ? ['link'] : ['install'];
opts = opts || {};
+var manager = opts.manager || 'npm';
+var fetchArgs = opts.link ? ['link'] : manager === 'yarn' ? ['add'] :
['install'];
var tree1;
var nodeModulesDir = dest;
// check if npm is installed
Review comment:
What do you mean ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using
> cordova plugin add), especially if I need to re-add the plugins. My
> suggestion is to update the cordova cli to start using yarn js instead of npm
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally
> sure how to proceed on this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374373#comment-16374373
]
ASF GitHub Bot commented on CB-12242:
-
janpio commented on a change in pull request #14: CB-12242 : Use yarn instead
of npm
URL: https://github.com/apache/cordova-fetch/pull/14#discussion_r170257217
##
File path: index.js
##
@@ -39,13 +39,14 @@ var hostedGitInfo = require('hosted-git-info');
*
*/
module.exports = function (target, dest, opts) {
-var fetchArgs = opts.link ? ['link'] : ['install'];
opts = opts || {};
+var manager = opts.manager || 'npm';
+var fetchArgs = opts.link ? ['link'] : manager === 'yarn' ? ['add'] :
['install'];
var tree1;
var nodeModulesDir = dest;
// check if npm is installed
Review comment:
comment is out of date
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using
> cordova plugin add), especially if I need to re-add the plugins. My
> suggestion is to update the cordova cli to start using yarn js instead of npm
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally
> sure how to proceed on this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374363#comment-16374363 ] ASF GitHub Bot commented on CB-12242: - qkdreyer opened a new pull request #14: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-fetch/pull/14 ### Platforms affected All ### What does this PR do? Allows user to select his package manager used by cordova-fetch, possible values are "npm" or "yarn", defaulting to "npm" ### What testing has been done on this change? yarn jasmine ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374362#comment-16374362 ] ASF GitHub Bot commented on CB-12242: - qkdreyer opened a new pull request #610: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-lib/pull/610 ### Platforms affected All ### What does this PR do? Allows user to select his package manager used by cordova-fetch, possible values are "npm" or "yarn", defaulting to "npm" ### What testing has been done on this change? None, since we're just adding cordova arguments here N.B. : src/cordova/plugin/util is still using fetch.isNpmInstalled() ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374361#comment-16374361 ] ASF GitHub Bot commented on CB-12242: - qkdreyer opened a new pull request #292: CB-12242 : Use yarn instead of npm URL: https://github.com/apache/cordova-cli/pull/292 ### Platforms affected All ### What does this PR do? Allows user to select his package manager used by cordova-fetch, possible values are "npm" or "yarn", defaulting to "npm" ### What testing has been done on this change? None, since we're just adding cordova arguments here ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Major > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256898#comment-16256898 ] Roland Nagy commented on CB-12242: -- [~tschumacher] On the cordova-fetch side the changes needed are minor compared to the changes needed on the cordova-lib and cordova-cli side to make it configurable to the user for using yarn or npm. > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256893#comment-16256893 ] Jan Piotrowski (Sujan) commented on CB-12242: - Then go for it. A PR would have to keep the default behaviour, but could of course add a configurable way to change this to yarn. How do other tools handle this? > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256613#comment-16256613 ] Tim Schumacher commented on CB-12242: - [~Sujan12] As I wrote earlier, the only change as far as I can see it, is needed in [cordova-fetch|https://github.com/apache/cordova-fetch] and it looks relative reasonable. > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255102#comment-16255102 ] Jan Piotrowski (Sujan) commented on CB-12242: - Feel free to start by evaluating what and where would need to be changed. All groundwork already taken care of makes it easier for someone to pick this issue and create a PR (or multiple PRs, as I suspect this to be spread about over multiple repos) that implements this. My impression in general is that from Cordova side there is no real need to tackle this right now. > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255068#comment-16255068 ] Roland Nagy commented on CB-12242: -- Any update on this issue? > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16164369#comment-16164369 ] Jacques de Villiers commented on CB-12242: -- I asked a question about this on StackOverflow: https://stackoverflow.com/questions/41125428/how-can-i-get-cordova-to-use-yarn-js-instead-of-npm-for-adding-plugins And it seems quite a number of people are interested in this, so any feedback on this from the Cordova team would be great. > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Wish > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins
[ https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16153607#comment-16153607 ] Tim Schumacher commented on CB-12242: - Sorry to dig this issue up, but this is not true, `cordova-fetch` has npm hardcoded and as such prevents me from using yarn. Are there any plans to refactor cordova-fetch? > Use yarn js instead of npm when adding plugins > -- > > Key: CB-12242 > URL: https://issues.apache.org/jira/browse/CB-12242 > Project: Apache Cordova > Issue Type: Wish > Components: cordova-cli, cordova-lib >Reporter: Jacques de Villiers >Priority: Minor > > Currently it can take quite long to add certain plugins to my project (using > cordova plugin add), especially if I need to re-add the plugins. My > suggestion is to update the cordova cli to start using yarn js instead of npm > directly. > When I looked at this page, I realised yarn was just a wrapper for npm, and > much better at caching packages locally. > https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc > I would imagine this change would be relatively straightforward, and would be > a massive win for the cli. > I was thinking of creating a fork to do a PR but realised I am not totally > sure how to proceed on this. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
