[jira] [Commented] (CB-12261) subdirectories deprecated warning always shows and stop fetch

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802915#comment-15802915
 ] 

ASF subversion and git services commented on CB-12261:
--

Commit 4191fa9b25b06140c58037ab9b504d6c9b9b064d in cordova-lib's branch 
refs/heads/master from [~yyfea...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=4191fa9 ]

CB-12261: fix subdirectories deprecated warning always shows and stop fetch 
caused by CB-11979

 This closes #511


> subdirectories deprecated warning always shows and stop fetch
> -
>
> Key: CB-12261
> URL: https://issues.apache.org/jira/browse/CB-12261
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
> Environment: Any
>Reporter: Wilson Yang
>Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> CB-11979 introduced a warning for using subdir with git url.
> But even there is no subdir, it still show the warning, or prevent fetch.
> Because the line of code `options.subdir = options.subdir || '.';`
> And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
> Then `if(options.subdir) {` will always true since options.subdir is '.' by 
> default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12261) subdirectories deprecated warning always shows and stop fetch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802917#comment-15802917
 ] 

ASF GitHub Bot commented on CB-12261:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-lib/pull/511


> subdirectories deprecated warning always shows and stop fetch
> -
>
> Key: CB-12261
> URL: https://issues.apache.org/jira/browse/CB-12261
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
> Environment: Any
>Reporter: Wilson Yang
>Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> CB-11979 introduced a warning for using subdir with git url.
> But even there is no subdir, it still show the warning, or prevent fetch.
> Because the line of code `options.subdir = options.subdir || '.';`
> And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
> Then `if(options.subdir) {` will always true since options.subdir is '.' by 
> default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12261) subdirectories deprecated warning always shows and stop fetch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755886#comment-15755886
 ] 

ASF GitHub Bot commented on CB-12261:
-

Github user stevengill commented on the issue:

https://github.com/apache/cordova-lib/pull/511
  
yes, those are known issues in the CI right now


> subdirectories deprecated warning always shows and stop fetch
> -
>
> Key: CB-12261
> URL: https://issues.apache.org/jira/browse/CB-12261
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
> Environment: Any
>Reporter: Wilson Yang
>Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> CB-11979 introduced a warning for using subdir with git url.
> But even there is no subdir, it still show the warning, or prevent fetch.
> Because the line of code `options.subdir = options.subdir || '.';`
> And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
> Then `if(options.subdir) {` will always true since options.subdir is '.' by 
> default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12261) subdirectories deprecated warning always shows and stop fetch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755831#comment-15755831
 ] 

ASF GitHub Bot commented on CB-12261:
-

Github user yyfearth commented on the issue:

https://github.com/apache/cordova-lib/pull/511
  
I think the CI has issue for the android sdk.
Travis-CI got:
`Failed to find 'ANDROID_HOME' environment variable. Try setting setting it 
manually.
Failed to find 'android' command in your 'PATH'. Try update your 'PATH' to 
include path to valid SDK directory.`
Appveyor got:
`You have not accepted the license agreements of the following SDK 
components:
[Android SDK Platform 25].
Before building your project, you need to accept the license agreements and 
complete the installation of the missing components using the Android Studio 
SDK Manager.`


> subdirectories deprecated warning always shows and stop fetch
> -
>
> Key: CB-12261
> URL: https://issues.apache.org/jira/browse/CB-12261
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
> Environment: Any
>Reporter: Wilson Yang
>Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> CB-11979 introduced a warning for using subdir with git url.
> But even there is no subdir, it still show the warning, or prevent fetch.
> Because the line of code `options.subdir = options.subdir || '.';`
> And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
> Then `if(options.subdir) {` will always true since options.subdir is '.' by 
> default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12261) subdirectories deprecated warning always shows and stop fetch

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755798#comment-15755798
 ] 

ASF GitHub Bot commented on CB-12261:
-

GitHub user yyfearth opened a pull request:

https://github.com/apache/cordova-lib/pull/511

CB-12261: Fix subdirectories deprecated warning always shows and stop fetch 
for…

### Platforms affected
All

### What does this PR do?
Fix the issue created by CB-11979, the subdirectories deprecated warning 
always shows and stop fetch

### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

_Not sure how the test should be written since the original PR does not 
comes with a test._


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yyfearth/cordova-lib CB-12261

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #511


commit 581bd6a5ce0e15fde2ebb3192fdd1a4b62954929
Author: Wilson Yang 
Date:   2016-12-16T23:18:52Z

CB-12261: fix subdirectories deprecated warning always shows and stop fetch 
caused by CB-11979




> subdirectories deprecated warning always shows and stop fetch
> -
>
> Key: CB-12261
> URL: https://issues.apache.org/jira/browse/CB-12261
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CordovaLib
>Affects Versions: 6.3.1
> Environment: Any
>Reporter: Wilson Yang
>Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> CB-11979 introduced a warning for using subdir with git url.
> But even there is no subdir, it still show the warning, or prevent fetch.
> Because the line of code `options.subdir = options.subdir || '.';`
> And `if (result[2]) options.subdir = result[2];` will not set subdir to empty
> Then `if(options.subdir) {` will always true since options.subdir is '.' by 
> default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org