[jira] [Commented] (CB-12341) Possible crash in [CDVUserAgentUtil releaseLock:]
[ https://issues.apache.org/jira/browse/CB-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818464#comment-15818464 ] Ben Rigas commented on CB-12341: That was fast, thank you [~shazron]! > Possible crash in [CDVUserAgentUtil releaseLock:] > - > > Key: CB-12341 > URL: https://issues.apache.org/jira/browse/CB-12341 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 > Environment: only tested on iOS 10.x, but would affect other versions > also. >Reporter: Ben Rigas >Assignee: Shazron Abdullah >Priority: Minor > Fix For: cordova-ios@4.4.0 > > > There is a possibility of a crash when calling [CDVUserAgentUtil > releaseLock:] with a nil pointer. The first check in this method dereferences > the lockToken pointer without first checking that it is non-nil, it should be > updated to check for nil before continuing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12341) Possible crash in [CDVUserAgentUtil releaseLock:]
[ https://issues.apache.org/jira/browse/CB-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816543#comment-15816543 ] ASF subversion and git services commented on CB-12341: -- Commit 6df46b7bad8da2f49560389a38a6d3929fabfe01 in cordova-ios's branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=6df46b7 ] CB-12341 - Possible crash in [CDVUserAgentUtil releaseLock:] > Possible crash in [CDVUserAgentUtil releaseLock:] > - > > Key: CB-12341 > URL: https://issues.apache.org/jira/browse/CB-12341 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 > Environment: only tested on iOS 10.x, but would affect other versions > also. >Reporter: Ben Rigas >Assignee: Shazron Abdullah >Priority: Minor > > There is a possibility of a crash when calling [CDVUserAgentUtil > releaseLock:] with a nil pointer. The first check in this method dereferences > the lockToken pointer without first checking that it is non-nil, it should be > updated to check for nil before continuing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12341) Possible crash in [CDVUserAgentUtil releaseLock:]
[ https://issues.apache.org/jira/browse/CB-12341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816445#comment-15816445 ] Shazron Abdullah commented on CB-12341: --- Thanks for the report! Even though the NSInteger* is a pointer to a static type (and not an object) and can never be nil (nil is just "(id)0" thus is essentially NULL equivalent) the check should be there in either case. > Possible crash in [CDVUserAgentUtil releaseLock:] > - > > Key: CB-12341 > URL: https://issues.apache.org/jira/browse/CB-12341 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.5.0 > Environment: only tested on iOS 10.x, but would affect other versions > also. >Reporter: Ben Rigas >Assignee: Shazron Abdullah >Priority: Minor > > There is a possibility of a crash when calling [CDVUserAgentUtil > releaseLock:] with a nil pointer. The first check in this method dereferences > the lockToken pointer without first checking that it is non-nil, it should be > updated to check for nil before continuing. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
