[jira] [Commented] (CB-12383) [Windows] App crashes with --browserify and SplashScreen plugin
[ https://issues.apache.org/jira/browse/CB-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839462#comment-15839462 ] ASF GitHub Bot commented on CB-12383: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/515 > [Windows] App crashes with --browserify and SplashScreen plugin > --- > > Key: CB-12383 > URL: https://issues.apache.org/jira/browse/CB-12383 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12383) [Windows] App crashes with --browserify and SplashScreen plugin
[ https://issues.apache.org/jira/browse/CB-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839461#comment-15839461 ] ASF subversion and git services commented on CB-12383: -- Commit 9f704a70b1376f712c7287d32587b33e68ff8f70 in cordova-lib's branch refs/heads/master from [~daserge] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=9f704a7 ] CB-12383 Fix cordova_plugins metadata definition Define parent object first > [Windows] App crashes with --browserify and SplashScreen plugin > --- > > Key: CB-12383 > URL: https://issues.apache.org/jira/browse/CB-12383 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12383) [Windows] App crashes with --browserify and SplashScreen plugin
[ https://issues.apache.org/jira/browse/CB-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837500#comment-15837500 ] ASF GitHub Bot commented on CB-12383: - Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/515#discussion_r97743108 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider // instead of generating intermediate file on FS var cordova_plugins = new Readable(); cordova_plugins.push( -'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n' + -'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n', 'utf8'); +'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n' + +'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n', 'utf8'); --- End diff -- Cool, thanks for clarification > [Windows] App crashes with --browserify and SplashScreen plugin > --- > > Key: CB-12383 > URL: https://issues.apache.org/jira/browse/CB-12383 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12383) [Windows] App crashes with --browserify and SplashScreen plugin
[ https://issues.apache.org/jira/browse/CB-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837501#comment-15837501 ] ASF GitHub Bot commented on CB-12383: - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-lib/pull/515 LGTM > [Windows] App crashes with --browserify and SplashScreen plugin > --- > > Key: CB-12383 > URL: https://issues.apache.org/jira/browse/CB-12383 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12383) [Windows] App crashes with --browserify and SplashScreen plugin
[ https://issues.apache.org/jira/browse/CB-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837471#comment-15837471 ] ASF GitHub Bot commented on CB-12383: - Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/515#discussion_r97741534 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider // instead of generating intermediate file on FS var cordova_plugins = new Readable(); cordova_plugins.push( -'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n' + -'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n', 'utf8'); +'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n' + +'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n', 'utf8'); --- End diff -- Right. And the behavior differs for normal and browserify cases. I.e. in normal case when we are injecting a script element the above code did not result in `module.exports` being overwritten. > [Windows] App crashes with --browserify and SplashScreen plugin > --- > > Key: CB-12383 > URL: https://issues.apache.org/jira/browse/CB-12383 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12383) [Windows] App crashes with --browserify and SplashScreen plugin
[ https://issues.apache.org/jira/browse/CB-12383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15837426#comment-15837426 ] ASF GitHub Bot commented on CB-12383: - Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/515#discussion_r97738068 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -157,8 +157,8 @@ module.exports = function doBrowserify (project, platformApi, pluginInfoProvider // instead of generating intermediate file on FS var cordova_plugins = new Readable(); cordova_plugins.push( -'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n' + -'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n', 'utf8'); +'module.exports = ' + JSON.stringify(modulesMetadata, null, 4) + ';\n' + +'module.exports.metadata = ' + JSON.stringify(pluginMetadata, null, 4) + ';\n', 'utf8'); --- End diff -- So, if I understand correctly, the whole `module.exports` object was being rewritten, so `metadata` property was being lost, right? > [Windows] App crashes with --browserify and SplashScreen plugin > --- > > Key: CB-12383 > URL: https://issues.apache.org/jira/browse/CB-12383 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Reporter: Sergey Shakhnazarov >Assignee: Sergey Shakhnazarov > -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
