[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340249#comment-16340249 ] Jan Piotrowski (Sujan) commented on CB-12499: - I am currently working on CB-13829, fixing some tests that were broken by another change. Unfortunately this `Default.rd.xml` is also causing one of the tests (build with ` --release --bundle --archs="x64 x86 arm"`) to fail when Visual Studio 17 is installed: {code:java} Started Creating Cordova Windows Project: Path: testcreate 応用 Namespace: com.test.app Name: 応用 Windows project created with cordova-windows@5.1.0-dev Building project: C:\projects\cordova-windows\testcreate 応用\CordovaApp.Windows10.jsproj Configuration : release Platform : x64 Patching 10 in prebuild event... Injected base.js reference to the www/index.html Removing /( *)(\s*<\/script>)(\s*)/ from www/index.html Removing /( *)(\s*<\/script>)(\s*)/ from www/index.html CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate ??\build\windows\release\x64\win10\CordovaApp.Windows10_1.0.0.0_x64.appx CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate ??\build\windows\release\x64\win10\Upload\CordovaApp.Windows10_1.0.0.0_x64.appx CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate ??\AppPackages\CordovaApp.Windows10_1.0.0.0_Test\CordovaApp.Windows10_1.0.0.0_x64.appxbundle CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate ??\AppPackages\CordovaApp.Windows10_1.0.0.0\CordovaApp.Windows10_1.0.0.0_x64.appxbundle CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate ??\AppPackages\CordovaApp.Windows10_1.0.0.0_x64_bundle.appxupload Your package has been successfully created. Building project: C:\projects\cordova-windows\testcreate 応用\CordovaApp.Windows10.jsproj Configuration : release Platform : x86 Patching 10 in prebuild event... C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(2975,5): error MSB3231: Unable to remove directory "build\windows\bld\PackageUploadLayout\". The process cannot access the file 'Default.rd.xml' because it is being used by another process. [C:\projects\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj] C:\projects\cordova-windows\testcreate 応用\cordova\node_modules\q\q.js:155 throw e; ^ Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed with exit code 1 at ChildProcess.whenDone (C:\projects\cordova-windows\testcreate 応用\cordova\node_modules\cordova-common\src\superspawn.js:169:23) at emitTwo (events.js:106:13) at ChildProcess.emit (events.js:191:7) at maybeClose (internal/child_process.js:920:16) at Process.ChildProcess._handle.onexit (internal/child_process.js:230:5){code} I will investigate a bit and then create an issue for this and reference it here. > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932386#comment-15932386 ] ASF subversion and git services commented on CB-12499: -- Commit d5ddcb4c4f546d2aa7707b57b26c5143ff42c91f in cordova-windows's branch refs/heads/master from [~daserge] [ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=d5ddcb4 ] CB-12499 UWP: Dependent external libraries specified as resource-file not being referenced in Release mode Adds Default.rd.xml to Windows 10 project template making an app metadata to be available for reflection at runtime > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932388#comment-15932388 ] ASF GitHub Bot commented on CB-12499: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/228 > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930618#comment-15930618 ] ASF GitHub Bot commented on CB-12499: - Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-windows/pull/228 LGTM > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886569#comment-15886569 ] ASF GitHub Bot commented on CB-12499: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/228 # [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=h1) Report > Merging [#228](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-windows/commit/a4ab7ccb59516a3d3d937b7b708d9bd4cac80159?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. ```diff @@ Coverage Diff @@ ## master #228 +/- ## === Coverage 76.91% 76.91% === Files 16 16 Lines Branches 439 439 === Hits 1709 1709 Misses513 513 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-windows/pull/228?src=pr&el=footer). Last update [a4ab7cc...d5ddcb4](https://codecov.io/gh/apache/cordova-windows/compare/a4ab7ccb59516a3d3d937b7b708d9bd4cac80159...d5ddcb4c4f546d2aa7707b57b26c5143ff42c91f?el=footer&src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886251#comment-15886251 ] ASF GitHub Bot commented on CB-12499: - GitHub user daserge opened a pull request: https://github.com/apache/cordova-windows/pull/228 CB-12499 UWP: Dependent external libraries specified as resource-file… … not being referenced in Release mode ### Platforms affected Windows ### What does this PR do? Adds Default.rd.xml to Windows 10 project template making an app (and plugins) metadata to be available for reflection at runtime ### What testing has been done on this change? npm tests, WACK tests ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/daserge/cordova-windows CB-12499 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-windows/pull/228.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #228 > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15882019#comment-15882019 ] Srutha Keerthi commented on CB-12499: - The mfp jsonstore plugin fails : https://www.npmjs.com/package/cordova-plugin-mfp-jsonstore. > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880350#comment-15880350 ] Sergey Shakhnazarov commented on CB-12499: -- [~sruthakeerthik] thanks for reporting! Could you link a plugin which fails in Release mode? > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12499) UWP : Dependent external libraries specified as resource-file not being referenced in Release mode.
[ https://issues.apache.org/jira/browse/CB-12499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880163#comment-15880163 ] Srutha Keerthi commented on CB-12499: - The fix for this is to include the file "Default.rd.xml" to the that specifies the actions to be taken on release build. The contents of the file should be the same as the contents of the file in a standard uwp project, which is as below : http://schemas.microsoft.com/netfx/2013/01/metadata";> > UWP : Dependent external libraries specified as resource-file not being > referenced in Release mode. > > > Key: CB-12499 > URL: https://issues.apache.org/jira/browse/CB-12499 > Project: Apache Cordova > Issue Type: Bug > Components: Windows >Affects Versions: 5.0.0, 4.4.2, 4.4.3 > Environment: Cordova Windows >Reporter: Srutha Keerthi > Fix For: 5.0.0, 4.4.2, 4.4.3 > > -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org