[jira] [Commented] (CB-12528) Remove silly existSync replacement
[ https://issues.apache.org/jira/browse/CB-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902130#comment-15902130 ] ASF GitHub Bot commented on CB-12528: - Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/524 It was deprecated for a time but then got undeprecated. Great find! https://github.com/nodejs/node/issues/1592 > Remove silly existSync replacement > -- > > Key: CB-12528 > URL: https://issues.apache.org/jira/browse/CB-12528 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen > > Remove bunk claim that existsSync is deprecated, so our own implementation is > provided... > It is not deprecated, our implementation appears to be unused. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12528) Remove silly existSync replacement
[ https://issues.apache.org/jira/browse/CB-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895529#comment-15895529 ] ASF GitHub Bot commented on CB-12528: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/524 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=h1) Report > Merging [#524](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/b0402b9e51bf2d97488fedd39d13348b29f81c3c?src=pr&el=desc) will **decrease** coverage by `-0.02%`. > The diff coverage is `100%`. ```diff @@Coverage Diff @@ ## master #524 +/- ## == - Coverage81.9% 81.88% -0.02% == Files 68 68 Lines5504 5498 -6 Branches 1090 1090 == - Hits 4508 4502 -6 Misses996 996 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cordova-lib/src/util/npm-helper.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL3V0aWwvbnBtLWhlbHBlci5qcw==) | `95.65% <100%> (ø)` | :white_check_mark: | | [cordova-lib/src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvdXRpbC5qcw==) | `97.2% <100%> (-0.08%)` | :x: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/524?src=pr&el=footer). Last update [b0402b9...62d491f](https://codecov.io/gh/apache/cordova-lib/compare/b0402b9e51bf2d97488fedd39d13348b29f81c3c...62d491f3ff107ab03957ded15603667bf68e692f?src=pr&el=footer&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > Remove silly existSync replacement > -- > > Key: CB-12528 > URL: https://issues.apache.org/jira/browse/CB-12528 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen > > Remove bunk claim that existsSync is deprecated, so our own implementation is > provided... > It is not deprecated, our implementation appears to be unused. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12528) Remove silly existSync replacement
[ https://issues.apache.org/jira/browse/CB-12528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893622#comment-15893622 ] ASF GitHub Bot commented on CB-12528: - GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-lib/pull/524 CB-12528 use fs instead of our own existsSync ### Platforms affected Lib ### What does this PR do? Removes unneeded API ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-lib CB-12528 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/524.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #524 commit 62d491f3ff107ab03957ded15603667bf68e692f Author: Jesse MacFadyen Date: 2017-03-03T02:08:52Z use fs instead of our own existsSync > Remove silly existSync replacement > -- > > Key: CB-12528 > URL: https://issues.apache.org/jira/browse/CB-12528 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaCommon >Reporter: Jesse MacFadyen >Assignee: Jesse MacFadyen > > Remove bunk claim that existsSync is deprecated, so our own implementation is > provided... > It is not deprecated, our implementation appears to be unused. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
