[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628523#comment-16628523 ] ASF GitHub Bot commented on CB-12774: - codecov-io commented on issue #680: WIP CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-424664151 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=h1) Report > Merging [#680](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/3079853c0ac2a60c7c38db87fc1996ab3cf1b9b8?src=pr&el=desc) will **increase** coverage by `0.24%`. > The diff coverage is `94.87%`. [](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#680 +/- ## = + Coverage 82.96% 83.2% +0.24% = Files 50 50 Lines27592775 +16 = + Hits 22892309 +20 + Misses470 466 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/cordova/plugin/save.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL3NhdmUuanM=) | `98.36% <ø> (-0.13%)` | :arrow_down: | | [src/plugman/uninstall.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vdW5pbnN0YWxsLmpz) | `93.58% <100%> (ø)` | :arrow_up: | | [src/cordova/plugin/plugin\_spec\_parser.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL3BsdWdpbl9zcGVjX3BhcnNlci5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [src/cordova/plugin/add.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL2FkZC5qcw==) | `98.69% <100%> (+0.41%)` | :arrow_up: | | [src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `90.03% <100%> (-0.08%)` | :arrow_down: | | [src/plugman/util/metadata.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vdXRpbC9tZXRhZGF0YS5qcw==) | `100% <100%> (+15.62%)` | :arrow_up: | | [src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvdXRpbC5qcw==) | `91.35% <100%> (+0.28%)` | :arrow_up: | | [src/cordova/platform/addHelper.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGxhdGZvcm0vYWRkSGVscGVyLmpz) | `96.31% <100%> (-0.03%)` | :arrow_down: | | [src/cordova/plugin/util.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL3V0aWwuanM=) | `96.77% <91.3%> (-3.23%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=footer). Last update [3079853...47981ae](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628524#comment-16628524 ] ASF GitHub Bot commented on CB-12774: - codecov-io edited a comment on issue #680: WIP CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-424664151 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=h1) Report > Merging [#680](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/3079853c0ac2a60c7c38db87fc1996ab3cf1b9b8?src=pr&el=desc) will **increase** coverage by `0.24%`. > The diff coverage is `94.87%`. [](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#680 +/- ## = + Coverage 82.96% 83.2% +0.24% = Files 50 50 Lines27592775 +16 = + Hits 22892309 +20 + Misses470 466 -4 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [src/cordova/plugin/save.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL3NhdmUuanM=) | `98.36% <ø> (-0.13%)` | :arrow_down: | | [src/plugman/uninstall.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vdW5pbnN0YWxsLmpz) | `93.58% <100%> (ø)` | :arrow_up: | | [src/cordova/plugin/plugin\_spec\_parser.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL3BsdWdpbl9zcGVjX3BhcnNlci5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [src/cordova/plugin/add.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL2FkZC5qcw==) | `98.69% <100%> (+0.41%)` | :arrow_up: | | [src/plugman/install.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vaW5zdGFsbC5qcw==) | `90.03% <100%> (-0.08%)` | :arrow_down: | | [src/plugman/util/metadata.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL3BsdWdtYW4vdXRpbC9tZXRhZGF0YS5qcw==) | `100% <100%> (+15.62%)` | :arrow_up: | | [src/cordova/util.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvdXRpbC5qcw==) | `91.35% <100%> (+0.28%)` | :arrow_up: | | [src/cordova/platform/addHelper.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGxhdGZvcm0vYWRkSGVscGVyLmpz) | `96.31% <100%> (-0.03%)` | :arrow_down: | | [src/cordova/plugin/util.js](https://codecov.io/gh/apache/cordova-lib/pull/680/diff?src=pr&el=tree#diff-c3JjL2NvcmRvdmEvcGx1Z2luL3V0aWwuanM=) | `96.77% <91.3%> (-3.23%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=footer). Last update [3079853...47981ae](https://codecov.io/gh/apache/cordova-lib/pull/680?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612730#comment-16612730 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-420797496 > Do you have any objections against me rebasing and squashing these commits as is necessary to further clean up this PR? None at all. Do as you see fit :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612712#comment-16612712 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-420794119 > I'd say get it into master ASAP. Then people could test with nightly builds, that's what I did. While crowd-sourcing is a fine thing, I still have to review and understand it, before I approve it :wink: > It would probably make sense to publish cordova under an npm scope at some point in the future. That would make for enough testing. Yeah, that's been on my silent wish list for some time now. But there's tons of more important stuff to do than that. Do you have any objections against me rebasing and squashing these commits as is necessary to further clean up this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612706#comment-16612706 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-420792185 I'd say get it into master ASAP. Then people could test with nightly builds, that's what I did. But because it didn't work out, but I had to move forward, all our packages are now published without a scope and we've abandoned npm (the company/registry) altogether. So I currently have neither a way of testing the new use case nor do I have any interest in moving back. It would probably make sense to publish cordova under an npm scope at some point in the future. That would make for enough testing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16612609#comment-16612609 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-420758886 So with the tests passing, do you think this is ready for a more thorough review @oliversalzburg? Or do you think there is still work to be done before that? (Apart from the changes that have to be moved to common if the rest checks out) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606516#comment-16606516 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419270559 No idea about that AppVeyor failure right now. I'll head to bed soon and then to Amsterdam over the weekend. I can look into it next week hopefully. I'm open for ideas of course :D This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606451#comment-16606451 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419257942 I think I had that timeout-related failure locally as well. I'll look into it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606349#comment-16606349 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419226485 I'd say leave it here until we're certain we have what we want. Then move it to common This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606336#comment-16606336 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419222510 @raphinesse I think you're right. I'm debugging the failing tests right now and it appears the `getAllHelper` is broken. What would you suggest? Bringing the change back or putting the change into common? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606314#comment-16606314 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419217533 @oliversalzburg To me 6acff93 looked like some change to a class from `cordova-common` that was needed for this change and that should have been ported to common once this was finished. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606307#comment-16606307 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680#issuecomment-419216613 I also dropped 6acff9309641c080dfd9227161384f027a013496 as I think it should have been removed. Not so sure about the 3 failures. I didn't see those earlier. I'll look into them. If someone has any ideas beforehand, that'd be great. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606283#comment-16606283
]
ASF GitHub Bot commented on CB-12774:
-
raphinesse commented on a change in pull request #680: CB-12774: Support scoped
packages
URL: https://github.com/apache/cordova-lib/pull/680#discussion_r215744083
##
File path: tsconfig.json
##
@@ -0,0 +1,55 @@
+{
Review comment:
It's from a commit labeled TEMP. I guess the original author used it to aid
the refactoring.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova plugin add doesn't support scoped packages from private registries
> --
>
> Key: CB-12774
> URL: https://issues.apache.org/jira/browse/CB-12774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: 1.1.0
>Reporter: Enrico Mazzucchelli
>Assignee: Raphael
>Priority: Major
> Labels: cordova-8.0.0
> Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker:
> https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config: npm config set @myco:registry
> http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in
> plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
> - npm set registry http://0.0.0.0:4873
> - npm publish
>- npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
> cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
> cordova plugin are installed
> ACTUAL BEHAVIOR:
> cordova installation failed:
> Error: Failed to fetch plugin my.co.plugin.demo via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 1 Error output:
> npm ERR! code E404
> npm ERR! 404 Registry returned 404 for GET on
> https://registry.npmjs.org/my.co.plugin.demo
> npm ERR! 404
> npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry.
> npm ERR! 404 You should bug the author to publish it (or use the name
> yourself!)
> npm ERR! 404
> npm ERR! 404 Note that you can also install from a
> npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and
> fetch.json have a new entry with key
> @my.co.plugin.demo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606275#comment-16606275
]
ASF GitHub Bot commented on CB-12774:
-
dpogue commented on a change in pull request #680: CB-12774: Support scoped
packages
URL: https://github.com/apache/cordova-lib/pull/680#discussion_r215742882
##
File path: tsconfig.json
##
@@ -0,0 +1,55 @@
+{
Review comment:
We probably don't want to add a tsconfig to the repo without further
discussion?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova plugin add doesn't support scoped packages from private registries
> --
>
> Key: CB-12774
> URL: https://issues.apache.org/jira/browse/CB-12774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-lib
>Affects Versions: 1.1.0
>Reporter: Enrico Mazzucchelli
>Assignee: Raphael
>Priority: Major
> Labels: cordova-8.0.0
> Fix For: 1.1.1
>
>
> STEP TO REPRODUCE:
> 1) setup a private repo (for example sinopia with docker:
> https://github.com/kfatehi/docker-sinopia)
> 2) add scope in your npm config: npm config set @myco:registry
> http://0.0.0.0:4873/
> 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in
> plugin.xml set plugin id: @myco/my.co.plugin.demo.
> 3) publish plugin in your private repo:
> - npm set registry http://0.0.0.0:4873
> - npm publish
>- npm set registry https://registry.npmjs.org/
> 4) in your cordova project dir, exec:
> cordova plugin add @myco/my.co.plugin.demo
> EXPECTED BEHAVIOR:
> cordova plugin are installed
> ACTUAL BEHAVIOR:
> cordova installation failed:
> Error: Failed to fetch plugin my.co.plugin.demo via registry.
> Probably this is either a connection problem, or plugin spec is incorrect.
> Check your connection and plugin name/version/URL.
> Error: npm: Command failed with exit code 1 Error output:
> npm ERR! code E404
> npm ERR! 404 Registry returned 404 for GET on
> https://registry.npmjs.org/my.co.plugin.demo
> npm ERR! 404
> npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry.
> npm ERR! 404 You should bug the author to publish it (or use the name
> yourself!)
> npm ERR! 404
> npm ERR! 404 Note that you can also install from a
> npm ERR! 404 tarball, folder, http url, or git url.
> However node module are correctly installed (verified with npm ls) and
> fetch.json have a new entry with key
> @my.co.plugin.demo.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[
https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606268#comment-16606268
]
ASF GitHub Bot commented on CB-12774:
-
raphinesse closed pull request #602: CB-12774 : Don't munge scoped plugin IDs
anymore. Comment requested.
URL: https://github.com/apache/cordova-lib/pull/602
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/integration-tests/plugin.spec.js b/integration-tests/plugin.spec.js
index 815d4182b..f03f2e9f1 100644
--- a/integration-tests/plugin.spec.js
+++ b/integration-tests/plugin.spec.js
@@ -46,6 +46,9 @@ var org_test_defaultvariables = 'org.test.defaultvariables';
var npmInfoTestPlugin = 'cordova-lib-test-plugin';
var npmInfoTestPluginVersion = '1.1.2';
+var npmScopedTestPlugin = '@testscope/cordova-lib-test-plugin-scoped';
+var npmScopedTestPluginDir = 'cordova-lib-test-plugin-scoped';
+
var testGitPluginRepository =
'https://github.com/apache/cordova-plugin-device.git';
var testGitPluginId = 'cordova-plugin-device';
@@ -95,8 +98,7 @@ function mockPluginFetch (id, dir) {
spyOn(plugman, 'fetch').and.callFake(function (target, pluginPath,
fetchOptions) {
var dest = path.join(project, 'plugins', id);
var src = path.join(dir, 'plugin.xml');
-
-shell.mkdir(dest);
+shell.mkdir('-p', dest);
shell.cp(src, dest);
return Q(dest);
});
@@ -259,19 +261,18 @@ describe('plugin end-to-end', function () {
}, 3);
it('Test 011 : should handle scoped npm packages', function (done) {
-var scopedPackage = '@testscope/' + npmInfoTestPlugin;
-mockPluginFetch(npmInfoTestPlugin, path.join(pluginsDir,
npmInfoTestPlugin));
+mockPluginFetch(npmScopedTestPlugin, path.join(pluginsDir,
npmScopedTestPluginDir));
spyOn(registry, 'info').and.returnValue(Q({}));
-addPlugin(scopedPackage, npmInfoTestPlugin, {}, done)
+addPlugin(npmScopedTestPlugin, npmScopedTestPlugin, {})
.then(function () {
// Check to make sure that we are at least trying to get the
correct package.
// This package is not published to npm, so we can't truly do
end-to-end tests
-expect(registry.info).toHaveBeenCalledWith([scopedPackage]);
+
expect(registry.info).toHaveBeenCalledWith([npmScopedTestPlugin]);
var fetchTarget = plugman.fetch.calls.mostRecent().args[0];
-expect(fetchTarget).toEqual(scopedPackage);
+expect(fetchTarget).toEqual(npmScopedTestPlugin);
})
.fail(function (err) {
expect(err).toBeUndefined();
@@ -280,11 +281,11 @@ describe('plugin end-to-end', function () {
}, 3);
it('Test 012 : should handle scoped npm packages with given version tags',
function (done) {
-var scopedPackage = '@testscope/' + npmInfoTestPlugin + '@latest';
-mockPluginFetch(npmInfoTestPlugin, path.join(pluginsDir,
npmInfoTestPlugin));
+var scopedPackage = npmScopedTestPlugin + '@latest';
+mockPluginFetch(npmScopedTestPlugin, path.join(pluginsDir,
npmScopedTestPluginDir));
spyOn(registry, 'info');
-addPlugin(scopedPackage, npmInfoTestPlugin, {}, done)
+addPlugin(scopedPackage, npmScopedTestPlugin, {})
.then(function () {
expect(registry.info).not.toHaveBeenCalled();
@@ -296,4 +297,37 @@ describe('plugin end-to-end', function () {
})
.fin(done);
}, 3);
+
+it('Test 013 : should be able to add and remove scoped npm packages
without screwing up everything', function (done) {
+mockPluginFetch(npmScopedTestPlugin, path.join(pluginsDir,
npmScopedTestPluginDir));
+
+spyOn(registry, 'info').and.returnValue(Q({}));
+addPlugin(npmScopedTestPlugin, npmScopedTestPlugin, {})
+.then(function () {
+
expect(registry.info).toHaveBeenCalledWith([npmScopedTestPlugin]);
+
+var fetchTarget = plugman.fetch.calls.mostRecent().args[0];
+expect(fetchTarget).toEqual(npmScopedTestPlugin);
+})
+.then(function () {
+return cordova.plugin('ls');
+})
+.then(function (list) {
+console.dir(list);
+})
+.then(function () {
+return removePlugin(npmScopedTestPlugin);
+})
+.then(function () {
+return cordova.plugin('ls');
+})
+.then(function (list) {
+console.dir(list);
+})
+.fail(fun
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606267#comment-16606267 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-419205940 Closing in favor of rebased #680. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606262#comment-16606262 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg opened a new pull request #680: CB-12774: Support scoped packages URL: https://github.com/apache/cordova-lib/pull/680 ### Platforms affected All ### What does this PR do? See #602 for details. ### What testing has been done on this change? ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606220#comment-16606220 ] ASF GitHub Bot commented on CB-12774: - raphinesse commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-419195367 @oliversalzburg Great to hear! OP hasn't reacted to previous mentions, so I'd suggest you open a PR with the rebased changes that references this one. Then we can have another look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606200#comment-16606200 ] ASF GitHub Bot commented on CB-12774: - oliversalzburg commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-419192500 I rebased this locally and did not see the same failure. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12774) cordova plugin add doesn't support scoped packages from private registries
[ https://issues.apache.org/jira/browse/CB-12774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16604236#comment-16604236 ] ASF GitHub Bot commented on CB-12774: - janpio commented on issue #602: CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. URL: https://github.com/apache/cordova-lib/pull/602#issuecomment-418679124 @tobilarscheid This PR has a failing test on Windows: ``` Failures: 1) plugin end-to-end Test 013 : should be able to add and remove scoped npm packages without screwing up everything Message: Expected Plugin "@testscope/cordova-lib-test-plugin-scoped" is not present in the project. See `cordova plugin list`. to be undefined. Stack: Error: Expected Plugin "@testscope/cordova-lib-test-plugin-scoped" is not present in the project. See `cordova plugin list`. to be undefined. at C:\projects\cordova-lib\integration-tests\plugin.spec.js:329:29 at _rejected (C:\projects\cordova-lib\node_modules\q\q.js:797:24) at C:\projects\cordova-lib\node_modules\q\q.js:823:30 at Promise.when (C:\projects\cordova-lib\node_modules\q\q.js:1035:31) ``` Also unfortunately the branch is now also conflicted and has to be rebased. Could you take care of that @akdor1154 please? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova plugin add doesn't support scoped packages from private registries > -- > > Key: CB-12774 > URL: https://issues.apache.org/jira/browse/CB-12774 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-lib >Affects Versions: 1.1.0 >Reporter: Enrico Mazzucchelli >Assignee: Raphael >Priority: Major > Labels: cordova-8.0.0 > Fix For: 1.1.1 > > > STEP TO REPRODUCE: > 1) setup a private repo (for example sinopia with docker: > https://github.com/kfatehi/docker-sinopia) > 2) add scope in your npm config: npm config set @myco:registry > http://0.0.0.0:4873/ > 3) create you plugin. In package.json set name: @myco/my.co.plugin.demo; in > plugin.xml set plugin id: @myco/my.co.plugin.demo. > 3) publish plugin in your private repo: > - npm set registry http://0.0.0.0:4873 > - npm publish >- npm set registry https://registry.npmjs.org/ > 4) in your cordova project dir, exec: > cordova plugin add @myco/my.co.plugin.demo > EXPECTED BEHAVIOR: > cordova plugin are installed > ACTUAL BEHAVIOR: > cordova installation failed: > Error: Failed to fetch plugin my.co.plugin.demo via registry. > Probably this is either a connection problem, or plugin spec is incorrect. > Check your connection and plugin name/version/URL. > Error: npm: Command failed with exit code 1 Error output: > npm ERR! code E404 > npm ERR! 404 Registry returned 404 for GET on > https://registry.npmjs.org/my.co.plugin.demo > npm ERR! 404 > npm ERR! 404 'com.vipera.de.foundation.commons' is not in the npm registry. > npm ERR! 404 You should bug the author to publish it (or use the name > yourself!) > npm ERR! 404 > npm ERR! 404 Note that you can also install from a > npm ERR! 404 tarball, folder, http url, or git url. > However node module are correctly installed (verified with npm ls) and > fetch.json have a new entry with key > @my.co.plugin.demo. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
