[jira] [Commented] (CB-12802) When multiple APKs build is enable, you cannot sign and the build crashes.
[ https://issues.apache.org/jira/browse/CB-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006929#comment-16006929 ] ASF GitHub Bot commented on CB-12802: - Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/379 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/379?src=pr&el=h1) Report > Merging [#379](https://codecov.io/gh/apache/cordova-android/pull/379?src=pr&el=desc) into [6.2.x](https://codecov.io/gh/apache/cordova-android/commit/c0df73c3c1040792fdf08acf3c2e07566123357f?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/379?src=pr&el=tree) ```diff @@ Coverage Diff @@ ##6.2.x #379 +/- ## === Coverage 42.07% 42.07% === Files 14 14 Lines1338 1338 Branches 245 245 === Hits 563 563 Misses775 775 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/379?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/379?src=pr&el=footer). Last update [c0df73c...b57ee1a](https://codecov.io/gh/apache/cordova-android/pull/379?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). > When multiple APKs build is enable, you cannot sign and the build crashes. > -- > > Key: CB-12802 > URL: https://issues.apache.org/jira/browse/CB-12802 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 >Reporter: Kevin Lot > > When multiple APKs build is enable, you cannot sign and the build crashes. > Method for sign can be parameters of command or build.json, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12802) When multiple APKs build is enable, you cannot sign and the build crashes.
[ https://issues.apache.org/jira/browse/CB-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16006919#comment-16006919 ] ASF GitHub Bot commented on CB-12802: - GitHub user kevin-lot opened a pull request: https://github.com/apache/cordova-android/pull/379 CB-12802: (android) When multiple APKs build is enable, you cannot sign and the build crashes. When 'cdvBuildMultipleApks' is true, 'task.name' can have 'validateSigningArmv7Release' or 'validateSigningX86Release' values. ### Platforms affected cordova 7 cordova-android 6.2.3 ### What does this PR do? Fix build.gradle to sign when multiple APK is enable. ### What testing has been done on this change? Test to build with or without signature and with or without multiple APK. ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Keyclic/cordova-android 6.2.x Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/379.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #379 commit b57ee1afa10b4cfba8858742d43404fab536d0e0 Author: Kevin Lot Date: 2017-05-11T17:58:29Z Include missing values for task.name When 'cdvBuildMultipleApks' is true, 'task.name' can have 'validateSigningArmv7Release' or 'validateSigningX86Release' values. > When multiple APKs build is enable, you cannot sign and the build crashes. > -- > > Key: CB-12802 > URL: https://issues.apache.org/jira/browse/CB-12802 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova@7.0.0 >Reporter: Kevin Lot > > When multiple APKs build is enable, you cannot sign and the build crashes. > Method for sign can be parameters of command or build.json, etc. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
