[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-12-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288043#comment-16288043
 ] 

ASF subversion and git services commented on CB-13405:
--

Commit 34a9765b4f21438cbd9f74988f5964c582ee72da in 
cordova-plugin-screen-orientation's branch refs/heads/master from 
[~vishalmishra]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-screen-orientation.git;h=34a9765
 ]

Merge pull request #24 from dnfield/master

CB-13405: (ios) Go to last used orientation before locking when unlocking 
screen on iOS

> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-12-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288042#comment-16288042
 ] 

ASF subversion and git services commented on CB-13405:
--

Commit b4db5e2796abf7a773b8e644f55e9457c221693a in 
cordova-plugin-screen-orientation's branch refs/heads/master from [~dfield]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-screen-orientation.git;h=b4db5e2
 ]

CB-13405: (ios) undo lock when resetting


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-12-12 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288041#comment-16288041
 ] 

ASF subversion and git services commented on CB-13405:
--

Commit 114aeef0bb79478098669594e7207357ffcc7644 in 
cordova-plugin-screen-orientation's branch refs/heads/master from [~dfield]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-screen-orientation.git;h=114aeef
 ]

CB-13405: (ios) Screen unlock bug fix


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-12-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288040#comment-16288040
 ] 

ASF GitHub Bot commented on CB-13405:
-

maverickmishra closed pull request #24: CB-13405: (ios) Go to last used 
orientation before locking when unlocking screen on iOS
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/24
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ios/CDVOrientation.h b/src/ios/CDVOrientation.h
index 48166a3..6bdd4d4 100644
--- a/src/ios/CDVOrientation.h
+++ b/src/ios/CDVOrientation.h
@@ -24,7 +24,11 @@
 #import 
 
 @interface CDVOrientation : CDVPlugin
-{}
+{
+@protected
+BOOL _isLocked;
+UIInterfaceOrientation _lastOrientation;
+}
 
 - (void)screenOrientation:(CDVInvokedUrlCommand *)command;
 
diff --git a/src/ios/CDVOrientation.m b/src/ios/CDVOrientation.m
index c7704e4..0152680 100644
--- a/src/ios/CDVOrientation.m
+++ b/src/ios/CDVOrientation.m
@@ -51,21 +51,37 @@ -(void)screenOrientation:(CDVInvokedUrlCommand *)command
 SEL selector = NSSelectorFromString(@"setSupportedOrientations:");
 
 if([vc respondsToSelector:selector]) {
-((void (*)(CDVViewController*, SEL, 
NSMutableArray*))objc_msgSend)(vc,selector,result);
+if (orientationMask != 15 || [UIDevice currentDevice] == nil) {
+((void (*)(CDVViewController*, SEL, 
NSMutableArray*))objc_msgSend)(vc,selector,result);
+}
 
 if ([UIDevice currentDevice] != nil){
 NSNumber *value = nil;
-if(orientationMask == 8 || orientationMask == 12) {
-value = [NSNumber 
numberWithInt:UIInterfaceOrientationLandscapeRight];
-} else if (orientationMask == 4){
-value = [NSNumber 
numberWithInt:UIInterfaceOrientationLandscapeLeft];
-} else if (orientationMask == 1 || orientationMask == 3) {
-value = [NSNumber 
numberWithInt:UIInterfaceOrientationPortrait];
-} else if (orientationMask == 2) {
-value = [NSNumber 
numberWithInt:UIInterfaceOrientationPortraitUpsideDown];
+if (orientationMask != 15) {
+if (!_isLocked) {
+_lastOrientation = [UIApplication 
sharedApplication].statusBarOrientation;
+}
+if(orientationMask == 8 || orientationMask == 12) {
+value = [NSNumber 
numberWithInt:UIInterfaceOrientationLandscapeRight];
+} else if (orientationMask == 4){
+value = [NSNumber 
numberWithInt:UIInterfaceOrientationLandscapeLeft];
+} else if (orientationMask == 1 || orientationMask == 3) {
+value = [NSNumber 
numberWithInt:UIInterfaceOrientationPortrait];
+} else if (orientationMask == 2) {
+value = [NSNumber 
numberWithInt:UIInterfaceOrientationPortraitUpsideDown];
+}
+} else {
+if (_lastOrientation != UIInterfaceOrientationUnknown) {
+[[UIDevice currentDevice] setValue:[NSNumber 
numberWithInt:_lastOrientation] forKey:@"orientation"];
+((void (*)(CDVViewController*, SEL, 
NSMutableArray*))objc_msgSend)(vc,selector,result);
+[UINavigationController 
attemptRotationToDeviceOrientation];
+}
 }
 if (value != nil) {
+_isLocked = true;
 [[UIDevice currentDevice] setValue:value 
forKey:@"orientation"];
+} else {
+_isLocked = false;
 }
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-12-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287802#comment-16287802
 ] 

ASF GitHub Bot commented on CB-13405:
-

janpio commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-351097991
 
 
   @devtobo Did you test and review the code? Does it work as expected? For now 
it couldn't be merged as no one did a comprehensive review (and my Obj-C is 
non-existant).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-12-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287768#comment-16287768
 ] 

ASF GitHub Bot commented on CB-13405:
-

devtobo commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-351090399
 
 
   Possible to merge eventually?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265765#comment-16265765
 ] 

ASF GitHub Bot commented on CB-13405:
-

janpio commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-346951576
 
 
   Nah, JIRA is strange with the URLs somehow. The URL you posted works.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-11-25 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265764#comment-16265764
 ] 

ASF GitHub Bot commented on CB-13405:
-

janpio commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-346858698
 
 
   Hi @dnfield - this looks like a nice feature or bug fix (depending on how 
you look at it).
   
   I can't find/open https://issues.apache.org/jira/projects/CB/issues/CB-13405 
though - is the issue ID correct?
   
   In general, code and feature additions should be announced on the [dev 
mailing list](http://cordova.apache.org/contact/) with request for comments and 
more important code reviews and merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265572#comment-16265572
 ] 

ASF GitHub Bot commented on CB-13405:
-

dnfield commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-346911222
 
 
   Thanks @janpio, I'll follow up on that.  The issue is here: 
https://issues.apache.org/jira/browse/CB-13405 maybe I didn't open it 
correctly?  I'll send an email to the dev list too, didn't see that in the 
contributing guidelines


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16265382#comment-16265382
 ] 

ASF GitHub Bot commented on CB-13405:
-

janpio commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-346858698
 
 
   Hi @dnfield - this looks like a nice feature or bug fix (depending on how 
you look at it).
   
   I can't find/open 
https://issues.apache.org/jira/projects/CB/issues/CB-CB-13405 though - is the 
issue ID correct?
   
   In general, code and feature additions should be announced on the [dev 
mailing list](http://cordova.apache.org/contact/) with request for comments and 
more important code reviews and merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264893#comment-16264893
 ] 

ASF GitHub Bot commented on CB-13405:
-

dnfield commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-346731497
 
 
   Yeah, basic idea is to store what orientation the phone was in before 
locking, and set it to that orientation after unlocking.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-11-23 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264793#comment-16264793
 ] 

ASF GitHub Bot commented on CB-13405:
-

devtobo commented on issue #24: CB-13405: (ios) Go to last used orientation 
before locking when unlocking screen on iOS
URL: 
https://github.com/apache/cordova-plugin-screen-orientation/pull/24#issuecomment-346700389
 
 
   We have a similar issue, landscape-sensor is always landscape-secondary when 
calling unlock('lanscape'). Is this pull-request fix this issue?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>  Labels: Triaged, iOS, in-progress
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-10-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193477#comment-16193477
 ] 

ASF GitHub Bot commented on CB-13405:
-

GitHub user dnfield reopened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/24

CB-13405: (ios) Go to last used orientation before locking when unlocking 
screen on iOS



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnfield/cordova-plugin-screen-orientation 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 114aeef0bb79478098669594e7207357ffcc7644
Author: Dan Field 
Date:   2017-10-05T18:13:26Z

CB-13405: (ios) Screen unlock bug fix

commit b4db5e2796abf7a773b8e644f55e9457c221693a
Author: Dan Field 
Date:   2017-10-05T19:16:07Z

CB-13405: (ios) undo lock when resetting




> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth.  T



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-10-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193388#comment-16193388
 ] 

ASF GitHub Bot commented on CB-13405:
-

Github user dnfield closed the pull request at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/24


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth.  T



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-10-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193387#comment-16193387
 ] 

ASF GitHub Bot commented on CB-13405:
-

Github user dnfield commented on the issue:

https://github.com/apache/cordova-plugin-screen-orientation/pull/24
  
This isn't quite ready.


> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth.  T



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13405) iOS screen orientation plugin fails to reset on unlock

2017-10-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193372#comment-16193372
 ] 

ASF GitHub Bot commented on CB-13405:
-

GitHub user dnfield opened a pull request:

https://github.com/apache/cordova-plugin-screen-orientation/pull/24

CB-13405: (ios) Go to last used orientation before locking when unlocking 
screen on iOS



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnfield/cordova-plugin-screen-orientation 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-screen-orientation/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 114aeef0bb79478098669594e7207357ffcc7644
Author: Dan Field 
Date:   2017-10-05T18:13:26Z

CB-13405: (ios) Screen unlock bug fix




> iOS screen orientation plugin fails to reset on unlock
> --
>
> Key: CB-13405
> URL: https://issues.apache.org/jira/browse/CB-13405
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: all iOS
>Reporter: Dan Field
>Assignee: Vishal Mishra
>Priority: Minor
>   Original Estimate: 6h
>  Remaining Estimate: 6h
>
> When locking and then unlocking the screen orientation on iOS, the device 
> fails to rotate until user manually rotates back and forth.  T



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org