[jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364879#comment-16364879 ] ASF GitHub Bot commented on CB-13522: - jcesarmobile commented on issue #158: CB-13522 (iOS): Remove usage description URL: https://github.com/apache/cordova-plugin-contacts/pull/158#issuecomment-365768993 This was necessary because people weren't setting the value, so the empty default one was used and Apple was rejecting apps. Also, a few plugins were setting the same usage description, which was causing collisions, making it now work as expected. This was done in all the plugins at the same time, and all of them got a major bump update. Major bump means there are breaking changes, so people should read the release notes before doing a major bump. It was also announced on the Cordova blog. The bug only crash development apps, so I don't think it's a big issue, if the developer doesn't catch it in time before trying to publish, Apple will reject it anyway, so there is no way of this crash reaching production apps (unless it's an enterprise app not distributed through the app store) If you think the plugins should fail instead of crash you can create issues on http://issues.cordova.io/ as feature requests proposing this change. Be aware that contacts plugin is deprecated, so no more work will be done on it, but you can propose it for the other plugins. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364669#comment-16364669 ] ASF GitHub Bot commented on CB-13522: - brandon-applied commented on issue #158: CB-13522 (iOS): Remove usage description URL: https://github.com/apache/cordova-plugin-contacts/pull/158#issuecomment-365723115 @jcesarmobile quick question - why was this change necessary? I've looked at the Jira issue and no mention of why this change was required? Failing to include the usage description in the manner described in the updated readme just causes the plugin to crash the app as soon as I attempt to read the contacts. For anyone upgrading, this "fix" just breaks the app. Seems like this fix should at least have updated the plugin to call the error callback if no permission text is available rather than crash. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236799#comment-16236799 ] ASF GitHub Bot commented on CB-13522: - jcesarmobile closed pull request #158: CB-13522 (iOS): Remove usage description URL: https://github.com/apache/cordova-plugin-contacts/pull/158 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/README.md b/README.md index f018631..17dad00 100644 --- a/README.md +++ b/README.md @@ -71,14 +71,19 @@ It is also possible to install via repo url directly ( unstable ) ### iOS Quirks -Since iOS 10 it's mandatory to add a `NSContactsUsageDescription` entry in the info.plist. +Since iOS 10 it's mandatory to provide an usage description in the `info.plist` if trying to access privacy-sensitive data. When the system prompts the user to allow access, this usage description string will displayed as part of the permission dialog box, but if you didn't provide the usage description, the app will crash before showing the dialog. Also, Apple will reject apps that access private data but don't provide an usage description. -`NSContactsUsageDescription` describes the reason that the app accesses the user’s contacts. When the system prompts the user to allow access, this string is displayed as part of the dialog box. To add this entry you can pass the variable `CONTACTS_USAGE_DESCRIPTION` on plugin install. + This plugins requires the following usage description: -Example: -`cordova plugin add cordova-plugin-contacts --variable CONTACTS_USAGE_DESCRIPTION="your usage message"` + * `NSContactsUsageDescription` describes the reason that the app accesses the user's contacts. -If you don't pass the variable, the plugin will add an empty string as value. + To add this entry into the `info.plist`, you can use the `edit-config` tag in the `config.xml` like this: + +``` + +need contacts access to search friends + +``` ### Firefox OS Quirks diff --git a/plugin.xml b/plugin.xml index 039a706..3b58f39 100644 --- a/plugin.xml +++ b/plugin.xml @@ -134,11 +134,6 @@ - - -$CONTACTS_USAGE_DESCRIPTION - - This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236802#comment-16236802 ] ASF subversion and git services commented on CB-13522: -- Commit 36f1d3960f7ced1289b7756f4c13c36f39c1eb03 in cordova-plugin-contacts's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=36f1d39 ] Merge pull request #158 from jcesarmobile/CB-13522 CB-13522 (iOS): Remove usage description > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236801#comment-16236801 ] ASF subversion and git services commented on CB-13522: -- Commit 36f1d3960f7ced1289b7756f4c13c36f39c1eb03 in cordova-plugin-contacts's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=36f1d39 ] Merge pull request #158 from jcesarmobile/CB-13522 CB-13522 (iOS): Remove usage description > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236800#comment-16236800 ] ASF subversion and git services commented on CB-13522: -- Commit 03424074b2094ea90224b25a856570a07e037750 in cordova-plugin-contacts's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=0342407 ] CB-13522 (iOS): Remove usage description > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13522) Remove ios usage description from cordova-plugin-contacts
[ https://issues.apache.org/jira/browse/CB-13522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236714#comment-16236714 ] ASF GitHub Bot commented on CB-13522: - jcesarmobile opened a new pull request #158: CB-13522 (iOS): Remove usage description URL: https://github.com/apache/cordova-plugin-contacts/pull/158 ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove ios usage description from cordova-plugin-contacts > - > > Key: CB-13522 > URL: https://issues.apache.org/jira/browse/CB-13522 > Project: Apache Cordova > Issue Type: Sub-task >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
