[jira] [Commented] (CB-13644) [Windows] "Element not found" exception thrown when launching Windows 8.1 app on Windows 10

2018-01-12 Thread Maarten Manders (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16323882#comment-16323882
 ] 

Maarten Manders commented on CB-13644:
--

Unfortunately it seems like the change is not synced in 
_cordova-windows/template/www/cordova.js_.
I don't know if this has to be done manually or what, but currently using the 
platform from git doesn't solve the issue.

> [Windows] "Element not found" exception thrown when launching Windows 8.1 app 
> on Windows 10
> ---
>
> Key: CB-13644
> URL: https://issues.apache.org/jira/browse/CB-13644
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: Windows 10, build 15063.
> Windows 8.1 app build.
> Cordova 7.1.0
> Cordova-windows 5.0.0
> Visual Studio 2015.
>Reporter: Maarten Manders
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: cordova-windows@4.5.0
>
> The following exception is thrown when launching a Windows 8.1 app on Windows 
> 10:
> {code:javascript}
> Exception is about to be caught by JavaScript library code at line 2083, 
> column 9 in ms-appx://com.test/www/cordova.js
> 0x80070490 - JavaScript runtime error: Element not found.
> {code}
> This occurs due to the addition made in 
> https://issues.apache.org/jira/browse/CB-12238. The check isn't sufficient to 
> account for the use case described above.
> I believe this to be the solution:
> {code:javascript}
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> titleInitialBgColor = appView.titleBar.backgroundColor;
> appView.titleBar.backgroundColor = titleBgColor;
> appView.titleBar.buttonBackgroundColor = titleBgColor;
> }
> }
> // Revert title bg color
> function revertTitleBarColor() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13644) [Windows] "Element not found" exception thrown when launching Windows 8.1 app on Windows 10

2017-12-07 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281647#comment-16281647
 ] 

Jan Piotrowski (Sujan) commented on CB-13644:
-

Thanks for the clarification and investigation.
You can install the cordova-windows platform directly from git if you want to 
test if this solves your problemt.

> [Windows] "Element not found" exception thrown when launching Windows 8.1 app 
> on Windows 10
> ---
>
> Key: CB-13644
> URL: https://issues.apache.org/jira/browse/CB-13644
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: Windows 10, build 15063.
> Windows 8.1 app build.
> Cordova 7.1.0
> Cordova-windows 5.0.0
> Visual Studio 2015.
>Reporter: Maarten Manders
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: cordova-windows@4.5.0
>
> The following exception is thrown when launching a Windows 8.1 app on Windows 
> 10:
> {code:javascript}
> Exception is about to be caught by JavaScript library code at line 2083, 
> column 9 in ms-appx://com.test/www/cordova.js
> 0x80070490 - JavaScript runtime error: Element not found.
> {code}
> This occurs due to the addition made in 
> https://issues.apache.org/jira/browse/CB-12238. The check isn't sufficient to 
> account for the use case described above.
> I believe this to be the solution:
> {code:javascript}
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> titleInitialBgColor = appView.titleBar.backgroundColor;
> appView.titleBar.backgroundColor = titleBgColor;
> appView.titleBar.buttonBackgroundColor = titleBgColor;
> }
> }
> // Revert title bg color
> function revertTitleBarColor() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13644) [Windows] "Element not found" exception thrown when launching Windows 8.1 app on Windows 10

2017-12-07 Thread Maarten Manders (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281620#comment-16281620
 ] 

Maarten Manders commented on CB-13644:
--

The use case mentioned in the title:

 "when launching a Windows 8.1 app on Windows 10".

Will do.

> [Windows] "Element not found" exception thrown when launching Windows 8.1 app 
> on Windows 10
> ---
>
> Key: CB-13644
> URL: https://issues.apache.org/jira/browse/CB-13644
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: Windows 10, build 15063.
> Windows 8.1 app build.
> Cordova 7.1.0
> Cordova-windows 5.0.0
> Visual Studio 2015.
>Reporter: Maarten Manders
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: cordova-windows@4.5.0
>
> The following exception is thrown when launching a Windows 8.1 app on Windows 
> 10:
> {code:javascript}
> Exception is about to be caught by JavaScript library code at line 2083, 
> column 9 in ms-appx://com.test/www/cordova.js
> 0x80070490 - JavaScript runtime error: Element not found.
> {code}
> This occurs due to the addition made in 
> https://issues.apache.org/jira/browse/CB-12238. The check isn't sufficient to 
> account for the use case described above.
> I believe this to be the solution:
> {code:javascript}
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> titleInitialBgColor = appView.titleBar.backgroundColor;
> appView.titleBar.backgroundColor = titleBgColor;
> appView.titleBar.buttonBackgroundColor = titleBgColor;
> }
> }
> // Revert title bg color
> function revertTitleBarColor() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13644) [Windows] "Element not found" exception thrown when launching Windows 8.1 app on Windows 10

2017-12-07 Thread Jan Piotrowski (Sujan) (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281568#comment-16281568
 ] 

Jan Piotrowski (Sujan) commented on CB-13644:
-

> The check isn't sufficient to account for the use case described above.

What exactly does this refer to? Which use case?

> I believe this to be the solution:
> ...

Great you already have a solution!

Just edit the file on Github, it will create a fork of the repo where you can 
just commit your changes, then create a Pull Request to the original repo. Fill 
the pull request template (which will connect it to this issue) and people will 
have a look. Thanks.

> [Windows] "Element not found" exception thrown when launching Windows 8.1 app 
> on Windows 10
> ---
>
> Key: CB-13644
> URL: https://issues.apache.org/jira/browse/CB-13644
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: Windows 10, build 15063.
> Windows 8.1 app build.
> Cordova 7.1.0
> Cordova-windows 5.0.0
> Visual Studio 2015.
>Reporter: Maarten Manders
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: cordova-windows@4.5.0
>
> The following exception is thrown when launching a Windows 8.1 app on Windows 
> 10:
> {code:javascript}
> Exception is about to be caught by JavaScript library code at line 2083, 
> column 9 in ms-appx://com.test/www/cordova.js
> 0x80070490 - JavaScript runtime error: Element not found.
> {code}
> This occurs due to the addition made in 
> https://issues.apache.org/jira/browse/CB-12238. The check isn't sufficient to 
> account for the use case described above.
> I believe this to be the solution:
> {code:javascript}
> // Make title bg color match splashscreen bg color
> function colorizeTitleBar() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> titleInitialBgColor = appView.titleBar.backgroundColor;
> appView.titleBar.backgroundColor = titleBgColor;
> appView.titleBar.buttonBackgroundColor = titleBgColor;
> }
> }
> // Revert title bg color
> function revertTitleBarColor() {
> var appView = 
> Windows.UI.ViewManagement.ApplicationView.getForCurrentView();
> if (appView.titleBar && (isWin10UWP || isWp10)) {
> appView.titleBar.backgroundColor = titleInitialBgColor;
> appView.titleBar.buttonBackgroundColor = titleInitialBgColor;
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org