[jira] [Commented] (CB-13690) Change audio stream src in platform-browser
[ https://issues.apache.org/jira/browse/CB-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634619#comment-16634619 ] ASF GitHub Bot commented on CB-13690: - janpio commented on issue #159: CB-13690 : (browser) Add src change to method to Media object URL: https://github.com/apache/cordova-plugin-media/pull/159#issuecomment-426056733 Tests are now passing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change audio stream src in platform-browser > --- > > Key: CB-13690 > URL: https://issues.apache.org/jira/browse/CB-13690 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 4.0.0 > Environment: Browser >Reporter: Frank Owusu >Priority: Critical > Labels: Audio, browser, easyfix, patch, stream > Fix For: 4.0.0 > > > h2. Media object change src method for Browser. > when node is released stream src is still being downloaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13690) Change audio stream src in platform-browser
[ https://issues.apache.org/jira/browse/CB-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633173#comment-16633173 ] ASF GitHub Bot commented on CB-13690: - janpio commented on issue #159: CB-13690 : (browser) Add src change to method to Media object URL: https://github.com/apache/cordova-plugin-media/pull/159#issuecomment-425685801 jshint is failing: ``` > cordova-plugin-media@5.0.1-dev jshint /home/travis/build/apache/cordova-plugin-media > jshint www && jshint src && jshint tests www/browser/Media.js: line 203, col 2, Missing semicolon. 1 error ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change audio stream src in platform-browser > --- > > Key: CB-13690 > URL: https://issues.apache.org/jira/browse/CB-13690 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 4.0.0 > Environment: Browser >Reporter: Frank Owusu >Priority: Critical > Labels: Audio, browser, easyfix, patch, stream > Fix For: 4.0.0 > > > h2. Media object change src method for Browser. > when node is released stream src is still being downloaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13690) Change audio stream src in platform-browser
[ https://issues.apache.org/jira/browse/CB-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478234#comment-16478234 ] Frank Owusu commented on CB-13690: -- [~wtrocki] [~goffioul] Actually the problem is with browser module, when streaming and you change stream source previous source don't stop downloading, This is the [PR|https://github.com/apache/cordova-plugin-media/pull/159/commits/106dd0948a2eea07d3a60909924ccb3371cdf950] > Change audio stream src in platform-browser > --- > > Key: CB-13690 > URL: https://issues.apache.org/jira/browse/CB-13690 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 4.0.0 > Environment: Browser >Reporter: Frank Owusu >Priority: Critical > Labels: Audio, browser, easyfix, patch, stream > Fix For: 4.0.0 > > > h2. Media object change src method for Browser. > when node is released stream src is still being downloaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13690) Change audio stream src in platform-browser
[ https://issues.apache.org/jira/browse/CB-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478225#comment-16478225 ] Wojciech Trocki commented on CB-13690: -- [~frank_owusu] Can you provide short code snipped? IMHO we may just need to expose destroy method that will do the job: https://github.com/apache/cordova-plugin-media/blob/master/src/android/AudioPlayer.java#L124-L131 This stops everything :) > Change audio stream src in platform-browser > --- > > Key: CB-13690 > URL: https://issues.apache.org/jira/browse/CB-13690 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 4.0.0 > Environment: Browser >Reporter: Frank Owusu >Priority: Critical > Labels: Audio, browser, easyfix, patch, stream > Fix For: 4.0.0 > > > h2. Media object change src method for Browser. > when node is released stream src is still being downloaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13690) Change audio stream src in platform-browser
[ https://issues.apache.org/jira/browse/CB-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408941#comment-16408941 ] Michael Goffioul commented on CB-13690: --- Same problem here, running Chrome 65. This is particularly annoying when the audio stream that was started is a live radio stream: the browser will keep downloading data forever. > Change audio stream src in platform-browser > --- > > Key: CB-13690 > URL: https://issues.apache.org/jira/browse/CB-13690 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 4.0.0 > Environment: Browser >Reporter: Frank Owusu >Priority: Critical > Labels: Audio, browser, easyfix, patch, stream > Fix For: 4.0.0 > > > h2. Media object change src method for Browser. > when node is released stream src is still being downloaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
