[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766387#comment-16766387
]
Darryl Pogue commented on CB-13767:
---
This is fixed in cordova-fetch@2.0.0.
It will be used in cordova-cli@9.0.0, which is blocked on the work-in-progress
major version releases of platforms.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766382#comment-16766382
]
Jon Rista commented on CB-13767:
Oh, to note, npm install was run before cordova, so all of the plugins should
have already been pulled down by npm.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766379#comment-16766379
]
Jon Rista commented on CB-13767:
I am not sure this is resolved. I finally had to update to Cordova 8, and I
just had an 11m3s install run (see below, last line of the log shows the
prompt, which includes the run time of the previous command).
Our normal builds are about 10 minutes. With cordova-fetch taking 11-15 minutes
to run, it is more than doubling our build times. When we are working locally,
especially on plugin issues (which seem to occur fairly often with plugin
abandonment these days), we have to sit there for 15 minutes waiting for the
add/prepare to finish.
This is really untenable. It needs to be fixed.
VERSIONS:
➜ ionic info
Ionic:
ionic (Ionic CLI) : 4.10.2
Ionic Framework : ionic-angular 3.9.2
@ionic/app-scripts : 3.2.2
Cordova:
cordova (Cordova CLI) : 8.1.2 (cordova-lib@8.1.1)
Cordova Platforms : ios 5.0.0
Cordova Plugins : no whitelisted plugins (21 plugins total)
System:
ios-sim : 7.0.0
NodeJS : v8.11.3 (/Users/jonrista/.nvm/versions/node/v8.11.3/bin/node)
npm : 6.7.0
OS : macOS Mojave
Xcode : Xcode 10.1 Build version 10B61
PLATFORM ADD LOG:
---
{{➜ ionic cordova platform add ios }}
{{> cordova platform add ios --save}}
{{Using cordova-fetch for cordova-ios@5.0.0}}
{{Adding ios project...}}
{{Creating Cordova project for the iOS platform:}}
{{ Path: platforms/ios}}
{{ Package: com.jpma.EBTShopper}}
{{ Name: WICShopper}}
{{iOS project created with cordova-ios@5.0.0}}
{{Discovered plugin "card.io.cordova.mobilesdk" in config.xml. Adding it to the
project}}
{{Installing "card.io.cordova.mobilesdk" for ios}}
{{Adding card.io.cordova.mobilesdk to package.json}}
{{Saved plugin info for "card.io.cordova.mobilesdk" to config.xml}}
{{Discovered plugin "cordova-plugin-app-version" in config.xml. Adding it to
the project}}
{{Installing "cordova-plugin-app-version" for ios}}
{{Adding cordova-plugin-app-version to package.json}}
{{Saved plugin info for "cordova-plugin-app-version" to config.xml}}
{{Discovered plugin "cordova-plugin-camera" in config.xml. Adding it to the
project}}
{{Installing "cordova-plugin-camera" for ios}}
{{Adding cordova-plugin-camera to package.json}}
{{Saved plugin info for "cordova-plugin-camera" to config.xml}}
{{Discovered plugin "cordova-plugin-device" in config.xml. Adding it to the
project}}
{{Installing "cordova-plugin-device" for ios}}
{{Adding cordova-plugin-device to package.json}}
{{Saved plugin info for "cordova-plugin-device" to config.xml}}
{{Discovered plugin "cordova-plugin-geolocation" in config.xml. Adding it to
the project}}
{{Installing "cordova-plugin-geolocation" for ios}}
{{Adding cordova-plugin-geolocation to package.json}}
{{Saved plugin info for "cordova-plugin-geolocation" to config.xml}}
{{Discovered plugin "cordova-plugin-google-analytics" in config.xml. Adding it
to the project}}
{{Installing "cordova-plugin-google-analytics" for ios}}
{{Adding cordova-plugin-google-analytics to package.json}}
{{Saved plugin info for "cordova-plugin-google-analytics" to config.xml}}
{{Discovered plugin "cordova-plugin-inappbrowser" in config.xml. Adding it to
the project}}
{{Installing "cordova-plugin-inappbrowser" for ios}}
{{Adding cordova-plugin-inappbrowser to package.json}}
{{Saved plugin info for "cordova-plugin-inappbrowser" to config.xml}}
{{Discovered plugin "cordova-plugin-network-information" in config.xml. Adding
it to the project}}
{{Installing "cordova-plugin-network-information" for ios}}
{{Adding cordova-plugin-network-information to package.json}}
{{Saved plugin info for "cordova-plugin-network-information" to config.xml}}
{{Discovered plugin "cordova-plugin-splashscreen" in config.xml. Adding it to
the project}}
{{Installing "cordova-plugin-splashscreen" for ios}}
{{Adding cordova-plugin-splashscreen to package.json}}
{{Saved plugin info for "cordova-plugin-splashscreen" to config.xml}}
{{Discovered plugin "cordova-plugin-statusbar" in config.xml. Adding it to the
project}}
{{Installing "cordova-plugin-statusbar" for ios}}
{{Adding cordova-plugin-statusbar to package.json}}
{{Saved plugin info for "cordova-plugin-statusbar" to config.xml}}
{{Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
project}}
{{Installing "cordova-plugin-whitelist" for ios}}
{{Adding cordova-plugin-whitelist to package.json}}
{{Saved plugin info for "cordova-plugin-whitelist" to config.xml}}
{{Discovered plugin "cordova-plugin-x-socialsharing" in config.xml. Adding it
to the project}}
{{Installing "cordova-plugin-x-socialsharing" for ios}}
{{Installing "es6-promise-plugin" for ios}}
{{Adding cordova-plugin-x-socialsharing to package.json}}
{{Saved plugin info for "cordova-plugin-x-socialsharing" to config.xml}}
{{Discovered plugin "cordova-sqlite-storage" in
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608059#comment-16608059
]
Raphael commented on CB-13767:
--
No worries. I'm glad to hear that the issue is resolved for you.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608058#comment-16608058
]
Mark Veenstra commented on CB-13767:
[~raphinesse] Just noticed that the CI was still using cordova@8.0.0 instead of
the nightly. So I updated the CI to use the nightly correctly and build times
are back to 6 mins again as in cordova@6.5.0. So this nightly definitely fixes
that issue.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608038#comment-16608038
]
Mark Veenstra commented on CB-13767:
Just verified that npm does install the plugins and platforms into the
node_modules directory, but still when adding a platform after npm install
command results into slow plugin discovery
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608035#comment-16608035
]
Raphael commented on CB-13767:
--
I'm not sure I understand what you are doing in your CI job. Would you be so
kind as to post the output of running `cordova info` (using the nightly) and
exactly which cordova commands you run afterwards. Running them with `–verbose`
and including that output too might help as well
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608033#comment-16608033
]
Mark Veenstra commented on CB-13767:
We are in fact doing a "npm install" before doing the "cordova platform add
android" or any other cordova command.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607186#comment-16607186
]
Raphael commented on CB-13767:
--
Sorry, forgot to add this: Assuming you have all your plugins and platforms as
dependencies in your package.json, do "npm install" once before "cordova
prepare" (or whatever you run then). This will allow dpendencies to be
installed once by npm and cordova will find them then. The only exceptions are
dependencies that use a git URL as their spec.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607182#comment-16607182
]
Mark Veenstra commented on CB-13767:
Just tested the nightly you mentioned, but it does not show any improvement. It
seems that downloading/discovering the plugins is really slow.
The CI/CD is always doing a clean build rather than a subsequent build. It
seems that subsequent builds are faster in the nightly, but the initial build
is slow because of the plugin discovery.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607149#comment-16607149
]
Raphael commented on CB-13767:
--
Yeah, we've been having some troubles with our nightly builds. You can see
which builds passed here: [https://builds.apache.org/job/cordova-nightly/]
So the latest successful build seems to be
cordova@8.0.1-nightly.2018.8.31.dfd2fe79
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607143#comment-16607143
]
Mark Veenstra commented on CB-13767:
[~raphinesse] Which nightly should I use. If i use cordova@nightly or
cordova@8.0.1-nightly.2018.9.7.5f369671 it fails with:
No matching version found for cordova-create@1.1.3-nightly.2018.9.7.86b05858
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607125#comment-16607125
]
Raphael commented on CB-13767:
--
Did you try with a working nightly as suggested above? This should be fixed in
master and will be released in the next major release. Unfortunately there's no
remedy for Cordova 8 in sight.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607121#comment-16607121
]
Mark Veenstra commented on CB-13767:
We are using GitLab CI/CD for auto build the Cordova projects. As all of the
above we needed to migrate to the latest Cordova 8 version since deprecated
warnings from Google.
But build times are massively increased, see these build times:
!image-2018-09-07-15-23-30-849.png!
Before Cordova 8 we had build times of 6-10 minutes:
!image-2018-09-07-15-24-06-688.png!
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
> Attachments: image-2018-09-07-15-23-30-849.png,
> image-2018-09-07-15-24-06-688.png
>
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521939#comment-16521939
]
Raphael commented on CB-13767:
--
Unless you have _only_ Git dependencies and if you use _cordova@nightly_ and do
a _npm install_ (yourself) before running _cordova prepare_, Cordova should NOT
shell out to npm 17 times.
Could you please try that and kindly report your build times before and after?
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521926#comment-16521926
]
Jon Rista commented on CB-13767:
I think the main issue is that npm is called once per package. If you have 17
plugins, then cordova-fetch shells out to npm 17 times, and does whatever else
it does around each execution of npm each time. Calling npm once per package is
extremely inefficient. You incur all of NPMs overhead, which these days
generally amounts to the majority of it's runtime for a single package install,
every time you install a package. You effectively lose all of the efficiency
gains that NPM has implemented recently. Even if you check for plugins on disk
first, that is really of no help in things like CI, which generally starts
fresh with nothing installed, and is the primary case where the performance hit
of cordova-fetch has been too much for us to bear. We can't be waiting 10-15
minutes just for the plugins to install whenever we do a CI build.
Is it not possible to do things in stages? Invoke NPM a single time, and have
it install all dependencies...then run your verification checks after they have
all installed, and deal with verification failures, and only the failures, on a
one-off basis?
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517600#comment-16517600
]
Raphael commented on CB-13767:
--
A sample repo together with some use cases with really bad performance would
surely help us to better tackle this.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517598#comment-16517598
]
Darryl Pogue commented on CB-13767:
---
{quote}I think it would help to know what cordova-fetch does, why it’s
necessary, and why the performance is affected vs. how installation was done
before.
{quote}
Previously, cordova didn't use npm as a registry, it used its own registry and
had its own code to handle retrieving packages and resolving dependencies.
We decided years ago to move to using npm, since it didn't require running our
own registry, and so that we could take advantage of all the work being done by
the npm team on their tooling without additional maintenance burden from our
side.
In the short term (aka, the past few years) cordova-lib contained a mix of
ancient cordova-registry code and support for npm packages via an old bundled
version of npm 2. This caused numerous problems for people, because it meant
that cordova projects that were using npm for managing their project got
unpredictable behaviour due to some commands sometimes using npm2 instead of
the system-wide npm version. In particular, it made it totally impossible to
use npm shrinkwrap with a Cordova project, because npm2 is not shrinkwrappable
by newer version of npm.
cordova-fetch made the decision to offload all the dependency fetching,
installing, and caching to the system installed version of npm. We literally
shell out to npm and tell it to install dependencies for us.
The additional challenge for Cordova is that we need to do steps after the
dependency is installed, and we need to do extra verification around the
version of a dependency that is installed because you can't have the same
plugin installed with different versions at different levels of the
node_modules folder. The current released version of cordova-fetch prints out
the list of all installed modules before/after each operation and compares them
to find out what changed. This is very slow, and leads to all sorts of other
hard-to-diagnose errors.
These changes use the version information reported back from the npm command to
determine the version, which is much faster.
The other change here is to check ahead of time if a dependency is already
installed with the version that we need. Unfortunately, this isn't possible to
do with git dependencies.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517582#comment-16517582
]
Raphael commented on CB-13767:
--
{quote}I think it would help to know what cordova-fetch does [...] and why the
performance is affected
{quote}
I'd like to think I answered the first question in my last comment. If it's
still unclear, feel free to take a look at the code. It's not too much and
quite readable by now. The performance is affected because it's called by
cordova-lib.
{quote}why it’s necessary, [...] how installation was done before.
{quote}
I cannot answer this properly – maybe someone else can. I only know that
platforms and plugins had to bundle their node_modules folders or manage
dependency installation themselves to work properly before Cordova 8. Ever
worked with a repository where node_modules is under version control? I assure
you, it's not pretty.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517571#comment-16517571
]
Andrew Crites commented on CB-13767:
I think it would help to know what cordova-fetch does, why it’s necessary, and
why the performance is affected vs. how installation was done before.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517564#comment-16517564
]
Raphael commented on CB-13767:
--
Whenever _cordova-lib_ decides that it needs some Cordova plugin or platform,
it calls _cordova-fetch_ with the _spec_ (e.g. _foo@1.2.3_ or _github:foo/bar_)
to get a path to the installed package.
Until I made the recent performance patch to cordova-fetch, it would just
install the required dependency using npm and return the path to the installed
package to cordova-lib.
With my patch cordova-fetch first checks if the required dependency is already
installed and returns the path to the installed version if it satisfies the
version constraints passed by cordova-lib. For this, we _need_ to determine the
required package's name. And with a Git spec, the only way to do that is to
install the package. Tough luck.
Consequently, every git dependency you have will be installed _every time_
cordova-lib feels like calling cordova-fetch with its spec. And If your
dependency's repository isn't hosted by one of the major Git hosters (GitHub,
GitLab, ...) npm won't even do a shallow clone, since it can't be sure that
it's supported by the remote side.
So that's why Git dependencies kill performance.
Now please know, that I'm aware that you sometimes simply _need_ to depend on
packages by specifying a Git URL. Moreover, I too think that Cordova should not
have to do package management and dependency resolution. It's a major PITA,
believe me. But also know, that we can't simply flip a switch and all will be
well. It's a little bit more complicated than that.
The improvement in cordova-fetch is something we could do _now_ and with a
_reasonable amount of work_. We will continue to investigate on how to further
improve performance as our time allows. After all, Cordova is improved by
people volunteering their time.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517473#comment-16517473
]
Jon Rista commented on CB-13767:
We have one git dependency...it's the only way to get that particular plugin in
a form that works, as far as we know (there are many forks, most have bugs.)
Why is it that git dependencies take so long?
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516885#comment-16516885
]
Raphael commented on CB-13767:
--
I guess it's still slower than Cordova 6. But I would really appreciate if you
could give it a try and report your build times for different versions here.
As a note: Git dependencies will absolutely kill performance
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516849#comment-16516849
]
Jon Rista commented on CB-13767:
What kind of performance increase are we really talking about here? With
installs that take 12-15 minutes, even if you doubled or tripled performance,
it would still be too slow. We ended up moving back to the previous version of
Cordova because of the severity of this issue...and it seems to install plugins
in just a few seconds. It's several hundred times faster...
If this patch can get close to that kind of performance, then we could give it
a try. We do so many builds per day, though, if it still takes minutes to
install plugins, we'll have to hold off.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514929#comment-16514929
]
Raphael commented on CB-13767:
--
Unless you instal everything from Git repos, performance should be vastly
increased by
[https://github.com/apache/cordova-fetch/pull/24|https://github.com/apache/cordova-fetch/pull/24.].
Please test with a build from source or with the next nightly and share your
results.
This is about all we can do to tackle performance in cordova-fetch. Further
improvements will have to be done in cordova-lib, which will require a lot more
work AFAICT.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-fetch, cordova-lib
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408659#comment-16408659
]
Jon Rista commented on CB-13767:
Latest run...over 12 and a half minutes!!
{noformat}
ionic cordova platform add android -d 777.63s user 88.14s system 114% cpu
12:37.35 total
{noformat}
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408623#comment-16408623
]
Jon Rista commented on CB-13767:
It also appears to run npm independently for each and every plugin, rather than
trying to batch the npm install for any that need to be installed/updated. If
it could run npm install on all the plugins that need fetching all at once, it
would be significantly faster.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408560#comment-16408560
]
Darryl Pogue commented on CB-13767:
---
One of the reasons it is slow is that it appears to always fetch from npm, even
when the plugin or platform has already been installed to node_modules by way
of a normal {{npm install}}. It doesn't attempt to find that existing copy, but
reinstalls it every time. It does the same for any dependencies of those
platforms & plugins.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13767) Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
[
https://issues.apache.org/jira/browse/CB-13767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408537#comment-16408537
]
Jon Rista commented on CB-13767:
I have to back up this issue. We just moved to cordova 7.1/8 from cordova 6.5
due to recent breaking changes in google's build support tools. We are
currently stuck in a bit of a nexus of catch-22's, as we have build tools doing
things for us (i.e. changing versions, force adding back packages that are
broken that we are trying to remove, etc.).
To make the current cordova build tools nitemare all that much worse, though,
is the horrible performance of cordova-fetch. Cordova 6.5 used to install
plugins in a couple of seconds, now, for our moderate set of plugins of about
17, it takes around 6-8 minutes to install all the plugins. I don't know how
cordova-fetch is so slow, but it is too slow to be viable in a normal daily
work environent, or in CI. We can't be spending 8 minutes to install our
plugins each attempt to test and fix our build. What might have been a
couple-hour ordeal has turned into an all day and soon here multi-day ordeal
due to the performance of cordova-fetch.
Hopefully this issue will get some attention soon.
> Huge performance issues moving from cordova 6.5 to 8 due to cordova-fetch
> -
>
> Key: CB-13767
> URL: https://issues.apache.org/jira/browse/CB-13767
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Andrew Crites
>Priority: Major
>
> This is for a project with a wide variety of plugins ... about 25. This may
> be above average, but not extreme. I've updated the project from cordova 6.5
> to cordova 8. Cordova 8 always uses {{cordova-fetch}} to install plugins, so
> I can't opt out. Before, I was not using {{cordova-fetch}}.
> {code}
> $ time npx cordova@6.5 platform add ios
> 23.85s user 9.26s system 130% cpu 25.414 total
> $ time npx cordova@8 platform add ios --nosave
> 402.44s user 61.94s system 119% cpu 6:28.09 total
> {code}
> That takes over 15 times longer. {{--nosave}} was used since this is the
> default behavior for 6.5.
> For subsequent installations using {{--save}} (or default) the performance is
> still like this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
