[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365651#comment-16365651 ] ASF subversion and git services commented on CB-13870: -- Commit dccdab98753abdbd39dd81259df6cfe7ee2ae81d in cordova-windows's branch refs/heads/master from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=dccdab9 ] CB-13870 Improve check_reqs (#258) * better output in `cordova requirements` when VS is chosen because of VSINSTALLDIR * default script `check_reqs` to building 10.0 apps so it can actually return something instead of crashing * new script `check_all` that does the same thing as `cordova requirements` but can be called from the command line > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16365650#comment-16365650 ] ASF GitHub Bot commented on CB-13870: - janpio closed pull request #258: CB-13870 Improve check_reqs URL: https://github.com/apache/cordova-windows/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364218#comment-16364218 ] ASF subversion and git services commented on CB-13870: -- Commit d2c3e99d8d8ba598b229a54252670051f29e06ab in cordova-windows's branch refs/heads/janpio-rework_MSBuildTools from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=d2c3e99 ] CB-13870 change default from UAP to 10.0 (#253) > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364110#comment-16364110 ] ASF GitHub Bot commented on CB-13870: - janpio closed pull request #252: [WIP] CB-13870 "Fix" `cordova requirements` for VS2017 URL: https://github.com/apache/cordova-windows/pull/252 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364104#comment-16364104 ] ASF GitHub Bot commented on CB-13870: - janpio closed pull request #253: CB-13870 change default from UAP to 10.0 URL: https://github.com/apache/cordova-windows/pull/253 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364105#comment-16364105 ] ASF subversion and git services commented on CB-13870: -- Commit d2c3e99d8d8ba598b229a54252670051f29e06ab in cordova-windows's branch refs/heads/master from Jan Piotrowski [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=d2c3e99 ] CB-13870 change default from UAP to 10.0 (#253) > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16363336#comment-16363336 ] Jan Piotrowski (Sujan) commented on CB-13870: - Re 3: This is getting trickier and trickier. The version numbers are actually equal `15.5`, but the MSBuild Tools live in a folder called `15.0`. That means the logic in MSBuildTools.js is actually working to get the right stuff, but then fails when constructing the folder name. It also can not handle multiple versions of the same MSBuildTools being installed, and _really_ doesn't know how to handle MSBuildTools that don't have all necessary packages installed. > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362943#comment-16362943 ] ASF GitHub Bot commented on CB-13870: - janpio commented on issue #253: CB-13870 change default from UAP to 10.0 URL: https://github.com/apache/cordova-windows/pull/253#issuecomment-365382904 Yes, this is actually required for `cordova requirements` not to explode (which happened after the change to `UAP`). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362504#comment-16362504 ] ASF GitHub Bot commented on CB-13870: - janpio opened a new pull request #253: CB-13870 change default from UAP to 10.0 URL: https://github.com/apache/cordova-windows/pull/253 ### What does this PR do? ... which means the same but works for check_reqs as well. This is an "update" to https://github.com/apache/cordova-windows/pull/241 ### What testing has been done on this change? - Manual installation as platform and ran `cordova requirements` successfully ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16362503#comment-16362503 ] ASF subversion and git services commented on CB-13870: -- Commit f7a5450e235ebe0888bd417abb612f6d27c9ce95 in cordova-windows's branch refs/heads/janpio-CB-13870_2 from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=f7a5450 ] CB-13870 change default from UAP to 10.0 which means the same but works for check_reqs as well > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jan Piotrowski (Sujan) >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360993#comment-16360993 ] ASF GitHub Bot commented on CB-13870: - janpio opened a new pull request #252: CB-13870 "Fix" `cordova requirements` for VS2017 URL: https://github.com/apache/cordova-windows/pull/252 This makes the command succeed by hacking the missing parts together. Should not be merged, more a note for whoever wants to really fix this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jesse MacFadyen >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[
https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360931#comment-16360931
]
Chris Brody commented on CB-13870:
--
{quote}check_reqs.js
{quote}
{{cordova requirements}} works fine for me if I try with cordova-windows@5.0.0
{quote}Additional though: There should be tests checking if current tooling
works.
{quote}
I was thinking the same thing. I just raised CB-13871 before finding this
comment.
{quote}Re 1:
This can be solved by either a) changing the default to "10.0" or b) teach
MsBuildTools.js about "UAP".
{quote}
I would favor a) changing the default to "10.0"
{quote}Re 2:
Not actually that relevant and important, but rewriting to be version
independent would probably be a good idea.
{quote}
+1 for rewriting to be version independent, if practical
{quote}Re 3:
This is more tricky.
{quote}
:=|
> `cordova requirements` is broken since change to default=UAP and with modern
> tooling
>
>
> Key: CB-13870
> URL: https://issues.apache.org/jira/browse/CB-13870
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Assignee: Jesse MacFadyen
>Priority: Blocker
>
> check_reqs.js
> 1. doesn't know about "UAP", only "10.0"
> 2. doesn't know about VS2017 (so error messages are wrong)
> 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360875#comment-16360875 ] ASF subversion and git services commented on CB-13870: -- Commit 73a2de5be6541253677ee4f5b25c00d306973c71 in cordova-windows's branch refs/heads/janpio-CB-13870 from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=73a2de5 ] CB-13870 add "version" that matches new default (temp) > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jesse MacFadyen >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360876#comment-16360876 ] ASF subversion and git services commented on CB-13870: -- Commit 51630fdd3b91b716508acc9b48f19b3924052006 in cordova-windows's branch refs/heads/janpio-CB-13870 from [~Sujan12] [ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=51630fd ] CB-13870 workaround for visual studio <-> msbuild version mismatch with 2017(15.5) <-> 15 > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jesse MacFadyen >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360872#comment-16360872 ] Jan Piotrowski (Sujan) commented on CB-13870: - Additional though: There should be tests checking if current tooling works. > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jesse MacFadyen >Priority: Blocker > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13870) `cordova requirements` is broken since change to default=UAP and with modern tooling
[ https://issues.apache.org/jira/browse/CB-13870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360767#comment-16360767 ] Jan Piotrowski (Sujan) commented on CB-13870: - Re 1: This can be solved by either a) changing the default to "10.0" or b) teach MsBuildTools.js about "UAP". Re 2: Not actually that relevant and important, but rewriting to be version independent would probably be a good idea. Re 3: This is more tricky. The current code assumes that the VS version and MSBuild versions are the same (15.0 for the time of when this was added: https://github.com/apache/cordova-windows/pull/237). But now VS is 15.5 and MSBuild is still 15.0. As there is an exact comparison, this does not work any more: https://github.com/apache/cordova-windows/blob/656ef073f417d59e32a123aa1fc84d3149378b52/template/cordova/lib/MSBuildTools.js#L131 > `cordova requirements` is broken since change to default=UAP and with modern > tooling > > > Key: CB-13870 > URL: https://issues.apache.org/jira/browse/CB-13870 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: Jan Piotrowski (Sujan) >Assignee: Jesse MacFadyen >Priority: Major > > check_reqs.js > 1. doesn't know about "UAP", only "10.0" > 2. doesn't know about VS2017 (so error messages are wrong) > 3. doesn't know about current MSBuild tooling (so doesn't recognize it at all) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
