[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700728#comment-16700728 ] ASF subversion and git services commented on CB-13892: -- Commit 46d7db8b0b7d62bbe267244d33388e475154aca7 in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~jcpa] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=46d7db8 ] CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700729#comment-16700729 ] ASF subversion and git services commented on CB-13892: -- Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ] Merge pull request #67 from jcesarmobile/CB-13892 CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700730#comment-16700730 ] ASF subversion and git services commented on CB-13892: -- Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's branch refs/heads/janpio-remove_translations from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ] Merge pull request #67 from jcesarmobile/CB-13892 CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436021#comment-16436021 ] ASF subversion and git services commented on CB-13892: -- Commit 46d7db8b0b7d62bbe267244d33388e475154aca7 in cordova-plugin-vibration's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=46d7db8 ] CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436022#comment-16436022 ] ASF subversion and git services commented on CB-13892: -- Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ] Merge pull request #67 from jcesarmobile/CB-13892 CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[
https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436020#comment-16436020
]
ASF GitHub Bot commented on CB-13892:
-
stevengill closed pull request #67: CB-13892:(all) Remove navigator.notification
URL: https://github.com/apache/cordova-plugin-vibration/pull/67
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/plugin.xml b/plugin.xml
index 3f5c705..9cae7e8 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -47,7 +47,6 @@
-
@@ -60,7 +59,6 @@
-
@@ -71,11 +69,9 @@
-
-
diff --git a/tests/tests.js b/tests/tests.js
index 74ae349..675b002 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -41,34 +41,6 @@ exports.defineManualTests = function (contentEl,
createActionButton) {
// Vibrations
//
-
-// old vibrate call
-var vibrateOld = function () {
-clearLog();
-navigator.notification.vibrate(2500);
-logMessage('navigator.notification.vibrate(2500)', 'green');
-};
-
-// old vibrate with pattern call
-var vibrateWithPatternOld = function () {
-clearLog();
-navigator.notification.vibrateWithPattern([1000, 3000, 2000, 5000]);
-logMessage('navigator.notification.vibrateWithPattern([1000, 3000,
2000, 5000])', 'green');
-};
-
-// old vibrate with pattern with repeat call
-var vibrateWithPatternOldWithRepeat = function () {
-clearLog();
-navigator.notification.vibrateWithPattern([1000, 3000, 2000, 5000], 2);
-logMessage('navigator.notification.vibrateWithPattern([1000, 3000,
2000, 5000], 2)', 'green');
-};
-
-// old cancel vibrate call
-var cancelOld = function () {
-clearLog();
-navigator.notification.cancelVibration();
-logMessage('navigator.notification.cancelVibration()', 'green');
-};
-
// new standard vibrate call that aligns to w3c spec with param long
var vibrateWithInt = function () {
clearLog();
@@ -145,16 +117,6 @@ exports.defineManualTests = function (contentEl,
createActionButton) {
var vibrate_tests = 'Vibrate Tests' +
'Starred tests only work for Android and Windows. ' +
'iOS ignores the time given for a vibrate ' +
-'' +
-'Expected result: Vibrate once for 2.5 seconds.' +
-' ' +
-'Expected result: Pause for 1s, vibrate for 3s, pause for 2s, vibrate
for 5s.' +
-' ' +
-'Expected result: Pause for 1s, vibrate for 3s, [pause for 2s, vibrate
for 5s.], repeat [steps]' +
-' ' +
-'Expected result: Press once to initiate vibrate for 60 seconds. Press
again to cancel vibrate immediately.' +
-' ' +
-'Expected result: Press once to initiate vibrate with pattern for 45s.
Press again to cancel vibrate immediately.' +
' ' +
'Expected result: Vibrate once for 3 seconds.' +
' ' +
@@ -174,45 +136,6 @@ exports.defineManualTests = function (contentEl,
createActionButton) {
contentEl.innerHTML = '' + vibrate_tests;
-// standard vibrate with old call
-createActionButton('Vibrate (Old)', function () {
-vibrateOld();
-}, 'vibrate_old');
-
-// vibrate with pattern with old call
-createActionButton('* Vibrate with a pattern (Old)', function () {
-vibrateWithPatternOld();
-}, 'vibrateWithPattern_old');
-
-// vibrate with pattern with repeat with old call
-createActionButton('* Vibrate with a pattern with repeat (Old)', function
() {
-vibrateWithPatternOldWithRepeat();
-}, 'vibrateWithPatternRepeat_old');
-
-// cancel vibrate with old call
-createActionButton('* Cancel vibration (Old)', function () {
-
-if (!vibrateOn) {
-longVibrate();
-} else {
-cancelOld();
-resetVibrateOn();
-clearTimeout(timeout); // clear the timeout since user has
canceled the vibrate
-}
-}, 'cancelVibrate_old');
-
-// cancel vibrate with pattern with old call
-createActionButton('* Cancel vibration with pattern (Old)', function () {
-
-if (!vibrateOn) {
-longVibrateWithPattern();
-} else {
-cancelOld();
-resetVibrateOn();
-clearTimeout(timeout); // clear the timeout since user has
canceled the vibrate
-}
-}, 'cancelVibrateWithPattern_old'
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436023#comment-16436023 ] ASF subversion and git services commented on CB-13892: -- Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ] Merge pull request #67 from jcesarmobile/CB-13892 CB-13892:(all) Remove navigator.notification > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431941#comment-16431941 ] ASF GitHub Bot commented on CB-13892: - jcesarmobile commented on issue #67: CB-13892:(all) Remove navigator.notification URL: https://github.com/apache/cordova-plugin-vibration/pull/67#issuecomment-379846554 Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431032#comment-16431032 ] ASF GitHub Bot commented on CB-13892: - jcesarmobile commented on issue #67: CB-13892:(all) Remove navigator.notification URL: https://github.com/apache/cordova-plugin-vibration/pull/67#issuecomment-379846554 Fixed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431018#comment-16431018 ] ASF GitHub Bot commented on CB-13892: - jcesarmobile commented on issue #67: CB-13892:(all) Remove navigator.notification URL: https://github.com/apache/cordova-plugin-vibration/pull/67#issuecomment-379846554 Shit, I've rebased with previous commit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Assignee: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin
[ https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429806#comment-16429806 ] ASF GitHub Bot commented on CB-13892: - jcesarmobile opened a new pull request #67: CB-13892:(all) Remove navigator.notification URL: https://github.com/apache/cordova-plugin-vibration/pull/67 ### Platforms affected All ### What does this PR do? Removes the old navigator.notification API as it has been deprecated for a long time (not even documented) Also removed the tests that used it ### What testing has been done on this change? ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Remove navigator.notification from vibration plugin > --- > > Key: CB-13892 > URL: https://issues.apache.org/jira/browse/CB-13892 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-vibration >Reporter: jcesarmobile >Priority: Major > > The navigator.notification was deprecated long time ago and also deleted from > the docs, but the plugin still have it as merges in the plugin.xml > We should remove it from plugin.xml and from the manual tests. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
