[jira] [Commented] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380475#comment-16380475
]
ASF GitHub Bot commented on CB-13922:
-
shazron commented on issue #357: CB-13922 - remove exit for start sim
URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369276355
@hosseinamin as I already said, this PR will not get in because it changes
the default behaviour, which is to exit after running the simulator. If you
want it to not exit per your requirements, you have to add the flag as a
feature.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380182#comment-16380182
]
ASF GitHub Bot commented on CB-13922:
-
hosseinamin commented on issue #357: CB-13922 - remove exit for start sim
URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369218465
@shazron i don't know much about it. In my view this command exits after
running simulator is ok.
Unless cordova-plugin-browsersync is installed and has `-- --live-reload`
```
cordova emulate ios --target="iPhone-7, 11.2"
```
If this exists i don't see in issue with it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380181#comment-16380181
]
ASF GitHub Bot commented on CB-13922:
-
hosseinamin commented on issue #357: CB-13922 - remove exit for start sim
URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369218465
i don't know much about it. In my view this command exits after running
simulator is ok.
Unless cordova-plugin-browsersync is installed and has `-- --live-reload`
```
cordova emulate ios --target="iPhone-7, 11.2"
```
If this exists i don't see in issue with it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379827#comment-16379827
]
ASF GitHub Bot commented on CB-13922:
-
shazron commented on issue #357: CB-13922 - remove exit for start sim
URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369133319
Add a flag here:
https://github.com/apache/cordova-ios/blob/7397337c932e072c0d68e6d1c61e6a5056d4f376/bin/templates/scripts/cordova/run#L50
and handle it in your code, switch on that flag
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13922) sim launch force-fully exits process
[
https://issues.apache.org/jira/browse/CB-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379824#comment-16379824
]
ASF GitHub Bot commented on CB-13922:
-
shazron commented on issue #357: CB-13922 - remove exit for start sim
URL: https://github.com/apache/cordova-ios/pull/357#issuecomment-369132607
I just tested this. Unfortunately this breaks the expectation that after a
(for example):
```bash
cordova emulate ios --target="iPhone-7, 11.2"
```
... the command exits, and the user gets back a command prompt -- the
current behaviour. I think, what is needed here is a flag called `--no-exit` to
handle your special case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> sim launch force-fully exits process
>
>
> Key: CB-13922
> URL: https://issues.apache.org/jira/browse/CB-13922
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios
>Affects Versions: cordova-ios 4.5.0
>Reporter: Hossein Amin
>Assignee: Shazron Abdullah
>Priority: Trivial
> Labels: pull-request-available
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Hi, I was trying to get cordova-plugin-browsersync to work with ios simulator.
> I discovered that at /bin/templates/scripts/cordova/lib/run.js@startSim
> {{return iossim.launch(appPath, 'com.apple.CoreSimulator.SimDeviceType.' +
> target, logPath, '--exit');}}
>
> This call is made inside main process, Where request for exit will end main
> process with no chance to catch it.
>
> I assume this call returns a promise for when launch was successful, If that
> can happen.
> Things will go smoothly after that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
