[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383170#comment-16383170
]
ASF GitHub Bot commented on CB-13925:
-
dblotsky commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369821049
@janpio if you want to know which tasks there are, you run `gulp`, and it
prints out a whole page describing itself. It's already documented, exactly at
the point where you would need the doc: when you use the build system.
Moreover, I think if you want to work on the docs system (not just modifying
contents of the docs), you do need to know the implementation. For example that
extra doc section does describe the implementation, since you never actually
need to run `gulp fetch`, the same way you never run `gulp styles`. It runs
automatically, as part of the build dependency graph.
Since you and @stevengill have been working on the docs a fair bit, I
thought it might be useful for me to pass some of the implementation knowledge
to you (because reading the code is less efficient, but still just as
informative). I also think because you folks are working on this, you might
have more opportunities to document the implementation than I will. However, I
could try and find some time to document this in the next few months if you
think it will be valuable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381882#comment-16381882
]
ASF GitHub Bot commented on CB-13925:
-
janpio commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369569511
Now "documented" at
https://github.com/apache/cordova-docs/blob/master/doc/working-on-docs.md#pull-in-documentation-from-other-repos
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381873#comment-16381873
]
ASF GitHub Bot commented on CB-13925:
-
janpio commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369567307
Telling me won't change the fact that anyone who jumps into the codebase (or
even just content) will have the same problem of not knowing which "processes"
and tasks there are - which is quite different to the technical details of the
implementation.
In this case something like this:
> There is a `fetch` task in `gulpfile.js` (which triggers
`tools/bin/fetch_docs.js` internally) that pulls in external documentation
(plugins READMEs) into the `dev` folder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381872#comment-16381872
]
ASF GitHub Bot commented on CB-13925:
-
janpio commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369567307
Telling me won't change the fact that anyone who jumps into the codebase (or
even just content) will have the same problem of not knowing which "processes"
and tasks there are - which is quite different to the technical details of the
implementation.
In this case something like this I think:
> There is a `fetch` task in `gulpfile.js` (which triggers
`tools/bin/fetch_docs.js` internally) that pulls in external documentation
(plugins READMEs) into the `dev` folder.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381225#comment-16381225
]
ASF GitHub Bot commented on CB-13925:
-
dblotsky commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369420298
@janpio got it. In general, it's unlikely that details like these will ever
be documented because they're in code, and they change. I can e-meet with you
to give you a full exposé of the codebase (it's not that much, actually). Might
you find that helpful?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380092#comment-16380092
]
ASF GitHub Bot commented on CB-13925:
-
janpio commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369191892
Yes, just tried to understand on what "scope" this change affects the docs
(as it is all undocumented).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379494#comment-16379494
]
ASF GitHub Bot commented on CB-13925:
-
dblotsky commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369067752
@janpio this change will not retroactively download files for any languages
or versions other than `en/dev`. Is that what you mean?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379401#comment-16379401
]
ASF subversion and git services commented on CB-13925:
--
Commit 6451c3d5041ebffac5ab73ae46af697aa2393b82 in cordova-docs's branch
refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=6451c3d ]
Merge pull request #793 from dblotsky/CB-13925
[CB-13925] Making file fetch happen on every build.
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379399#comment-16379399
]
ASF subversion and git services commented on CB-13925:
--
Commit 5e2e45996f16f6c3d1006e821738eff2f6df0270 in cordova-docs's branch
refs/heads/master from [~dblotsky]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=5e2e459 ]
CB-13925: (docs) Adding --nofetch option to Gulp build, and making Gulp always
fetch files on build. Improving error message in augment_toc.js a bit.
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379400#comment-16379400
]
ASF subversion and git services commented on CB-13925:
--
Commit 6451c3d5041ebffac5ab73ae46af697aa2393b82 in cordova-docs's branch
refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=6451c3d ]
Merge pull request #793 from dblotsky/CB-13925
[CB-13925] Making file fetch happen on every build.
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379398#comment-16379398
]
ASF GitHub Bot commented on CB-13925:
-
stevengill closed pull request #793: [CB-13925] Making file fetch happen on
every build.
URL: https://github.com/apache/cordova-docs/pull/793
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/gulpfile.js b/gulpfile.js
index 2f0dbf6a7..f6dd2d5e5 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -313,13 +313,16 @@ gulp.task("regen", ["jekyll"], function () {
});
gulp.task("fetch", function (done) {
-if (!fs.existsSync(FETCH_DIR)) {
-exec("node", [bin("fetch_docs.js"), "--config", FETCH_CONFIG,
'--docsRoot', DOCS_DIR], done);
-} else {
+
+// skip fetching if --nofetch was passed
+if (gutil.env.nofetch) {
gutil.log(gutil.colors.yellow(
-"Skipping fetching external docs. Run 'gulp clean' first to
initiate another fetch."));
+"Skipping fetching external docs."));
done();
+return;
}
+
+exec("node", [bin("fetch_docs.js"), "--config", FETCH_CONFIG,
'--docsRoot', DOCS_DIR], done);
});
gulp.task("reload", function () {
diff --git a/package.json b/package.json
index 5079f1ec6..33cdbee30 100644
--- a/package.json
+++ b/package.json
@@ -22,6 +22,7 @@
"baconjs": "^0.7.70",
"browser-sync": "^2.8.0",
"browserify": "^10.2.4",
+"chalk": "^2.3.1",
"cheerio": "^0.17.0",
"classnames": "^2.1.2",
"envify": "^3.4.0",
diff --git a/tools/bin/augment_toc.js b/tools/bin/augment_toc.js
index 7b12d51fd..b29f19458 100644
--- a/tools/bin/augment_toc.js
+++ b/tools/bin/augment_toc.js
@@ -22,6 +22,7 @@ var path = require('path');
var yaml = require('js-yaml');
var optimist = require('optimist');
+var chalk = require('chalk');
var util = require('./util');
@@ -46,7 +47,7 @@ function augmentEntry (originalEntry, prefix) {
// skip entries that don't point to a valid file
if (!fs.existsSync(filePath)) {
-console.warn('WARNING! Possible 404 in ToC: "' + filePath + '"');
+console.warn(chalk.red('WARNING! Possible 404 in ToC: "' + filePath +
'"; create the file to fix'));
return originalEntry;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379284#comment-16379284
]
ASF GitHub Bot commented on CB-13925:
-
janpio commented on issue #793: [CB-13925] Making file fetch happen on every
build.
URL: https://github.com/apache/cordova-docs/pull/793#issuecomment-369029844
Will this only affect `dev` when run in CI?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13925) Files in www/docs/en/dev/reference are not fetched on every build.
[
https://issues.apache.org/jira/browse/CB-13925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379275#comment-16379275
]
ASF GitHub Bot commented on CB-13925:
-
dblotsky opened a new pull request #793: [CB-13925] Making file fetch happen on
every build.
URL: https://github.com/apache/cordova-docs/pull/793
Adding --nofetch option to Gulp build, and making Gulp always fetch files on
build. Improving error message in augment_toc.js a bit.
### Platforms affected
None. It's a docs change.
### What does this PR do?
Fixes CB-13925.
### What testing has been done on this change?
Built the docs site locally.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html)
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with
resolving file paths", where CB- is the JIRA ID & "android" is the platform
affected.
- [x] Added automated test coverage as appropriate for this change.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Files in www/docs/en/dev/reference are not fetched on every build.
> --
>
> Key: CB-13925
> URL: https://issues.apache.org/jira/browse/CB-13925
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-docs
>Reporter: Dmitry Blotsky
>Priority: Major
>
> Some files in the docs are downloaded from external sources, into
> {{www/docs/en/dev/reference}}. The files and their sources are defined in
> {{cordova-docs/www/_data/fetched-files.yml}}, and downloaded by the {{gulp
> fetch}} task, which runs on every build.
> Expected behaviour: the files are fetched every time the command runs.
> Actual behaviour: the files are only fetched if the
> {{www/docs/en/dev/reference}} directory doesn't exist. That is, fetching is
> skipped every time after the first time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
