[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440244#comment-16440244 ] ASF GitHub Bot commented on CB-13955: - stevengill closed pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/Makefile b/Makefile deleted file mode 100644 index 23a2fa90d..0 --- a/Makefile +++ /dev/null @@ -1,314 +0,0 @@ -# Function Reference: -# https://www.gnu.org/software/make/manual/html_node/Text-Functions.html -# https://www.gnu.org/software/make/manual/html_node/File-Name-Functions.html -# Variable Reference: -# https://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html - -# Makefile's own config -ifeq ($(OS),Windows_NT) -WINDOWS=1 -endif - -ifdef WINDOWS -SHELL = cmd -JEKYLL = bundle.bat exec jekyll -CAT= type -LS = ls -else -SHELL = sh -JEKYLL = bundle exec jekyll -CAT= cat -LS = ls -endif - -# macros -slugify = $(subst /,_,$(subst .,-,$(1))) -slug2language = $(subst /,,$(dir $(subst _,/,$(1 -slug2version = $(subst -,.,$(notdir $(subst _,/,$(1 - -ifdef WINDOWS -copydir = xcopy "$(subst /,\,$(1))" "$(subst /,\,$(2))" /E /I -else -copydir = cp -r $(1) $(2) -endif - -ifdef WINDOWS -copyfile = copy "$(subst /,\,$(1))" "$(subst /,\,$(2))" -else -copyfile = cp $(1) $(2) -endif - -ifdef WINDOWS -makedir = mkdir $(subst /,\,$(1)) -else -makedir = mkdir -p $(1) -endif - -ifdef WINDOWS -printfile = type $(subst /,\,$(1)) -else -printfile = cat $(1) -endif - -ifdef WINDOWS -RM = cmd /C del /Q /F $(subst /,\,$(1)) -RMDIR = cmd /C rmdir /S /Q $(subst /,\,$(1)) -else -RM = rm -f $(1) -RMDIR = rm -rf $(1) -endif - -# constants -EMPTY = -SPACE = $(EMPTY) $(EMPTY) -COMMA = , - -VERSION_VAR_NAME = latest_docs_version - -# paths and files -BIN_DIR = tools/bin -NODE_BIN_DIR = ./node_modules/.bin - -SRC_DIR= www -DEV_DIR= build-dev -PROD_DIR = build-prod -CONFIG_DIR = conf - -DOCS_DIR = $(SRC_DIR)/docs -DATA_DIR = $(SRC_DIR)/_data -TOC_DIR = $(DATA_DIR)/toc -STATIC_DIR = $(SRC_DIR)/static -CSS_SRC_DIR = $(STATIC_DIR)/css-src -CSS_DEST_DIR = $(STATIC_DIR)/css -PLUGINS_SRC_DIR = $(STATIC_DIR)/plugins -PLUGINS_DEST_DIR = $(STATIC_DIR)/js - -# executables -NODE = node -GULP = $(NODE_BIN_DIR)/gulp -LESSC = $(NODE_BIN_DIR)/lessc -SASSC = $(NODE_BIN_DIR)/node-sass -BROWSERIFY = $(NODE_BIN_DIR)/browserify -UGLIFY = $(NODE_BIN_DIR)/uglifyjs - -# replace slashes in executables on Windows -ifdef WINDOWS -GULP := $(subst /,\,$(GULP)) -LESSC := $(subst /,\,$(LESSC)) -SASSC := $(subst /,\,$(SASSC)) -BROWSERIFY := $(subst /,\,$(BROWSERIFY)) -UGLIFY := $(subst /,\,$(UGLIFY)) -endif - -# existing files -MAIN_CONFIG = $(CONFIG_DIR)/_config.yml -DEV_CONFIG = $(CONFIG_DIR)/_dev.yml -PROD_CONFIG = $(CONFIG_DIR)/_prod.yml -DOCS_EXCLUDE_CONFIG = $(CONFIG_DIR)/_nodocs.yml -FETCH_CONFIG= $(DATA_DIR)/fetched-files.yml -REDIRECTS_FILE = $(DATA_DIR)/redirects.yml -PLUGINS_SRC = $(PLUGINS_SRC_DIR)/app.js -VERSION_FILE= VERSION -FETCH_SCRIPT= $(BIN_DIR)/fetch_docs.js - -# NOTE: -# the .scss files are separate because they combine into MAIN_STYLE_FILE, -# which includes them on its own, and the SCSS compiler takes care of them; -# because of this, there is also no .scss -> .css pattern rule -ifdef WINDOWS -PWD = $(dir $(realpath $(firstword $(MAKEFILE_LIST -SCSS_SRC = $(subst $(PWD),,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir *.scss /S /B))) -STYLES_SRC = $(subst $(PWD),,$(subst \,/,$(shell cd $(CSS_SRC_DIR) && dir *.less *.css /S /B))) -else -SCSS_SRC = $(shell find $(CSS_SRC_DIR) -name "*.scss") -STYLES_SRC = $(shell find $(CSS_SRC_DIR) -name "*.less" -or -name "*.css") -endif - -LANGUAGES = $(shell $(LS) $(DOCS_DIR)) - -LATEST_DOCS_VERSION = $(strip $(shell $(CAT) $(VERSION_FILE))) -NEXT_DOCS_VERSION = $(shell $(NODE) $(BIN_DIR)/nextversion.js $(LATEST_DOCS_VERSION)) - -NEXT_DOCS_VERSION_SLUG = $(call slugify,$(NEXT_DOCS_VERSION)) - -DEV_DOCS = $(addprefix $(DOCS_DIR)/,$(addsuffix /dev,$(LANGUAGES))) -DEV_DOCS_TOCS = $(addprefix $(TOC_DIR)/,$(addsuffix _dev-src.yml, $(LANGUAGES))) - -# generated files -VERSION_CONFIG= $(CONFIG_DIR)/_version.yml -DEFAULTS_CONFIG = $(CONFIG_DIR)/_defaults.yml -DOCS_VERSION_DATA = $(DATA_DIR)/docs-versions.yml -DOCS_PAGE_LIST= $(DATA_DIR)/all-pages.yml -PLUGINS_APP = $(PLUGINS_DEST_DIR)/plugins.js -MAIN_STYLE_FILE = $(CSS_DEST_DIR)/main.css -
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440245#comment-16440245 ] ASF subversion and git services commented on CB-13955: -- Commit a8dad1292e7bb0d7e5736b94f1d5122093dc4a39 in cordova-docs's branch refs/heads/master from [~stevegill] [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=a8dad12 ] Merge pull request #811 from gandhirajan/gandhi-doc-make CB-13955 No mention of 'Make' command running in 'developing-the-website' section > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16438115#comment-16438115 ] ASF GitHub Bot commented on CB-13955: - dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-381286683 Looks good to me. Farewell, Makefile! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429749#comment-16429749 ] ASF GitHub Bot commented on CB-13955: - gandhirajan commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-379548452 @purplecabbage thanks a lot for the response. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429621#comment-16429621 ] ASF GitHub Bot commented on CB-13955: - purplecabbage commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-379519988 +1 to removing makefile and leaving documentation explaining the one way to build and serve. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424538#comment-16424538 ] ASF GitHub Bot commented on CB-13955: - gandhirajan commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r178950059 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15 @@ That command will build the site and start a local server. To work on only the w Alternatively, to dynamically rebuild the site and refresh the browser _when changes happen_ (again, optionally with the `--nodocs` flag), run: node_modules/.bin/gulp watch + +### Using Make + +To build the website, run: + +make build Review comment: @dblotsky @janpio @stevengill Hi All, Please provide your valuable feedback to proceed further on this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422876#comment-16422876 ] ASF GitHub Bot commented on CB-13955: - gandhirajan commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r178604403 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15 @@ That command will build the site and start a local server. To work on only the w Alternatively, to dynamically rebuild the site and refresh the browser _when changes happen_ (again, optionally with the `--nodocs` flag), run: node_modules/.bin/gulp watch + +### Using Make + +To build the website, run: + +make build Review comment: @dblotsky @janpio @stevengill should we go ahead and knock off the Makefile and its corresponding installation steps then? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422722#comment-16422722 ] ASF GitHub Bot commented on CB-13955: - dblotsky commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r178583712 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15 @@ That command will build the site and start a local server. To work on only the w Alternatively, to dynamically rebuild the site and refresh the browser _when changes happen_ (again, optionally with the `--nodocs` flag), run: node_modules/.bin/gulp watch + +### Using Make + +To build the website, run: + +make build Review comment: @janpio this process is not required at all. The Makefile simply mirrors what the Gulpfile does. I put the Makefile in the project when it was started because I wanted faster builds, but nobody except me liked using Make. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16422164#comment-16422164 ] ASF GitHub Bot commented on CB-13955: - gandhirajan commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377912785 @dblotsky Hi Dmitry, I have no such preference for Make over Gulp. I just started my cordova contribution with docs and I found this discrepancy and started working on it. If we feel its not required, we can take a collective decision and drop off make. @janpio @stevengill your thoughts plz? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16421928#comment-16421928 ] ASF GitHub Bot commented on CB-13955: - dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377853105 @janpio @stevengill @gandhirajan @gandhirajan are you ok with using Gulp? Is there any reason you prefer Make over Gulp? If not, my recommendation is to delete the Makefile, and to have only one way to do builds. I think two documented ways will be confusing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419500#comment-16419500 ] ASF GitHub Bot commented on CB-13955: - gandhirajan commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377320809 @dblotsky Hi Dmitry, Since we have make install instructions documented, I thought it would be better to include instructions for running website using make so that the users will be kept informed. @janpio @stevengill Your thoughts please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419494#comment-16419494 ] ASF GitHub Bot commented on CB-13955: - gandhirajan commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r178135404 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15 @@ That command will build the site and start a local server. To work on only the w Alternatively, to dynamically rebuild the site and refresh the browser _when changes happen_ (again, optionally with the `--nodocs` flag), run: node_modules/.bin/gulp watch + +### Using Make + +To build the website, run: + +make build Review comment: @janpio sorry Jan, I dint get your question. make build should build the website using makefile This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418021#comment-16418021 ] ASF GitHub Bot commented on CB-13955: - janpio commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377014469 IMHO if there are two ways to do things, they should be documented. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418019#comment-16418019 ] ASF GitHub Bot commented on CB-13955: - dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377013624 I think the Makefile shouldn’t be part of the docs since Gulp is our standard way to do builds. I think it’s best if we document only one way to do builds. @janpio @stevengill thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418018#comment-16418018 ] ASF GitHub Bot commented on CB-13955: - dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377013624 I think the Makefile shouldn’t be part of the docs since Gulp is our standard way to do builds. I think it’s best if we document only one way to do builds. @janpio @stevengill thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418015#comment-16418015 ] ASF GitHub Bot commented on CB-13955: - dblotsky commented on issue #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#issuecomment-377013624 I think the Makefile shouldn’t be part of the docs since Gulp is our standard way to do builds. I think it’s best if we document only one way to do builds. @sujan @stevegill thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418009#comment-16418009 ] ASF GitHub Bot commented on CB-13955: - janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r177868797 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15 @@ That command will build the site and start a local server. To work on only the w Alternatively, to dynamically rebuild the site and refresh the browser _when changes happen_ (again, optionally with the `--nodocs` flag), run: node_modules/.bin/gulp watch + +### Using Make + +To build the website, run: + +make build Review comment: Doesn`t the normal build process have its own document? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418010#comment-16418010 ] ASF GitHub Bot commented on CB-13955: - janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r177868893 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15 @@ That command will build the site and start a local server. To work on only the w Alternatively, to dynamically rebuild the site and refresh the browser _when changes happen_ (again, optionally with the `--nodocs` flag), run: node_modules/.bin/gulp watch + +### Using Make + +To build the website, run: + +make build Review comment: Doesn`t the normal build process have its own document? Or is this required to be able to `serve`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16418008#comment-16418008 ] ASF GitHub Bot commented on CB-13955: - janpio commented on a change in pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811#discussion_r177868797 ## File path: doc/developing-the-website.md ## @@ -11,3 +13,15 @@ That command will build the site and start a local server. To work on only the w Alternatively, to dynamically rebuild the site and refresh the browser _when changes happen_ (again, optionally with the `--nodocs` flag), run: node_modules/.bin/gulp watch + +### Using Make + +To build the website, run: + +make build Review comment: Doesn`t the normal build process have its own document? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417973#comment-16417973 ] ASF GitHub Bot commented on CB-13955: - gandhirajan opened a new pull request #811: CB-13955 No mention of 'Make' command running in 'developing-the-website' section URL: https://github.com/apache/cordova-docs/pull/811 Added Make instructions for building and running website This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Assignee: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388412#comment-16388412 ] Jan Piotrowski (Sujan) commented on CB-13955: - Info: There is a `Makefile` that works just like the `gulpfile.js` and has the same functionality (or should have). > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388204#comment-16388204 ] Gandhirajan commented on CB-13955: -- Will have a check on this > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
