[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684153#comment-16684153 ] ASF GitHub Bot commented on CB-14089: - dpogue commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-437968135 The status is that we're trying to find an option that doesn't unconditionally pull kotlin support libraries into all Cordova projects, although it's worth more investigation there to see whether that actually impacts the resulting APK filesize. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684143#comment-16684143
]
ASF GitHub Bot commented on CB-14089:
-
brodybits commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r232747948
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +34,16 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+if (cdvHelpers.getConfigPreference('EnableKotlin',
'false').toBoolean()) {
+classpath
"org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+}
}
}
// Allow plugins to declare Maven dependencies via build-extras.gradle.
allprojects {
repositories {
-mavenCentral();
+mavenCentral()
Review comment:
I think this should be proposed in a separate PR (this may be done in PR
#507).
Also I think removing semicolons should be proposed in a separate PR. (EDIT:
already proposed in PR #507)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684149#comment-16684149 ] ASF GitHub Bot commented on CB-14089: - brodybits commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-437967179 What is the status of this proposal? If we merge PR #507 (Gradle updates) I think this one should be rebased. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684139#comment-16684139
]
ASF GitHub Bot commented on CB-14089:
-
brodybits commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r232747948
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +34,16 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+if (cdvHelpers.getConfigPreference('EnableKotlin',
'false').toBoolean()) {
+classpath
"org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+}
}
}
// Allow plugins to declare Maven dependencies via build-extras.gradle.
allprojects {
repositories {
-mavenCentral();
+mavenCentral()
Review comment:
I think this should be proposed in a separate PR (this may be done in PR
#507).
Also I think removing semicolons should be proposed in a separate PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16665787#comment-16665787
]
ASF GitHub Bot commented on CB-14089:
-
videmort commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r228693626
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +34,16 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+if (cdvHelpers.getConfigPreference('EnableKotlin',
'false').toBoolean()) {
+classpath
"org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
+}
}
}
// Allow plugins to declare Maven dependencies via build-extras.gradle.
allprojects {
repositories {
-mavenCentral();
+mavenCentral()
Review comment:
I think that shoud be google() instead mavenCentral()
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610858#comment-16610858
]
ASF GitHub Bot commented on CB-14089:
-
joshchandler commented on a change in pull request #441: CB-14089: (android)
Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r216728546
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
Oh I see.. Ok well then I'll wait until feedback is received on that google
services PR. I'm not familiar enough with gradle to confidently say that
importing into the dependencies scope wouldn't cause any problems.
`cordova.gradle` only consists of helper methods, so I don't see any reason why
it would be an issue though.
If it doesn't cause any issues then this would just be another reason to
pull it in here and the other dependencies scope further below this file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610650#comment-16610650 ] ASF GitHub Bot commented on CB-14089: - codecov-io commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging [#441](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #441 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=footer). Last update [23b2449...478450f](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610652#comment-16610652 ] ASF GitHub Bot commented on CB-14089: - codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging [#441](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #441 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=footer). Last update [23b2449...478450f](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610651#comment-16610651 ] ASF GitHub Bot commented on CB-14089: - codecov-io edited a comment on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-420286698 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=h1) Report > Merging [#441](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/23b24491c3e2ad5721a2813ec08f80985eca5e64?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #441 +/- ## === Coverage 61.64% 61.64% === Files 16 16 Lines1945 1945 Branches 363 363 === Hits 1199 1199 Misses746 746 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=footer). Last update [23b2449...478450f](https://codecov.io/gh/apache/cordova-android/pull/441?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610631#comment-16610631
]
ASF GitHub Bot commented on CB-14089:
-
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r216679161
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
@joshchandler Sorry, the `cdvHelpers` is currently not available in the
`dependencies` scope, as I mentioned in this example.
Wrapping the apply plugin should be OK. Example:
```
if (cdvHelpers.getConfigPreference('EnableKotlin', 'false').toBoolean()) {
apply plugin: 'kotlin-android'
}
```
There is a discussion on a PR that also modifies the the same `build.gradle`
file for other features. It also had the same issue where `cdvHelpers` is not
available in the dependency scope. Adding it is as easy as adding the `apply
from: '../CordovaLib/cordova.gradle'` in the scope BUT I am waiting for any
feedback about it.
You can see the comment here:
https://github.com/apache/cordova-android/pull/438#discussion_r216195552
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610606#comment-16610606 ] ASF GitHub Bot commented on CB-14089: - joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r216674955 ## File path: bin/templates/project/Activity.kt ## @@ -0,0 +1,38 @@ +/* Review comment: This file is actually not unnecessary.. I'm taking it out. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610607#comment-16610607
]
ASF GitHub Bot commented on CB-14089:
-
joshchandler commented on a change in pull request #441: CB-14089: (android)
Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r216674985
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
Awesome, did not know this was available. Thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16606177#comment-16606177 ] ASF GitHub Bot commented on CB-14089: - dpogue commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215720701 ## File path: test/gradle/wrapper/gradle-wrapper.properties ## @@ -1,6 +1,5 @@ -#Wed Oct 25 11:17:25 PDT 2017 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-bin.zip Review comment: Yeah... I think this might already have been updated on master (and maybe the source of a conflict now) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605273#comment-16605273
]
ASF GitHub Bot commented on CB-14089:
-
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r215495327
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
Can we wrap all of the Kotlin code and make it conditional by a flag? This
is regarding to the same concerns that @dpogue mentioned.
It might be possible that not everyone would use Kotlin.
For example:
```
if (cdvHelpers.getConfigPreference('EnableKotlin', 'false').toBoolean()) {
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605272#comment-16605272 ] ASF GitHub Bot commented on CB-14089: - erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215494867 ## File path: test/gradle/wrapper/gradle-wrapper.properties ## @@ -1,6 +1,5 @@ -#Wed Oct 25 11:17:25 PDT 2017 distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-bin.zip Review comment: I believe upgrading gradle should be in a separate PR. @dpogue Do you also agree with this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605271#comment-16605271 ] ASF GitHub Bot commented on CB-14089: - erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r215496283 ## File path: bin/templates/project/Activity.kt ## @@ -0,0 +1,38 @@ +/* Review comment: If we make Kotlin an optional feature, this file should not be used and defaults to `Activity.java`. Only use this file if the EnableKotlin flag is set to `true`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[
https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605274#comment-16605274
]
ASF GitHub Bot commented on CB-14089:
-
erisu commented on a change in pull request #441: CB-14089: (android) Add
Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r215495532
##
File path: bin/templates/project/app/build.gradle
##
@@ -30,13 +32,14 @@ buildscript {
dependencies {
classpath 'com.android.tools.build:gradle:3.1.0'
+classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
Review comment:
And this conditional statement would be applied everywhere else relating to
Kotlin.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Kotlin Support
> --
>
> Key: CB-14089
> URL: https://issues.apache.org/jira/browse/CB-14089
> Project: Apache Cordova
> Issue Type: New Feature
> Components: cordova-android
>Reporter: Joshua Chandler
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: cordova-android-7.0.0
>
>
> Kotlin is not supported out of the gate for cordova android projects.. You
> need to explicitly configure a built android project to support it. This
> should be supported out of the gate with no configuration so that plugins or
> any other custom code could be written in the language.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503782#comment-16503782 ] ASF GitHub Bot commented on CB-14089: - joshchandler commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-395185665 @dpogue Yes this adds the Kotlin library to all projects in all instances. Initially I thought that it'd make sense to add it anyways since it's an official language for Android development.. I'd be open to only adding it if it's explicitly defined in config.xml or something similar to that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474515#comment-16474515 ] ASF GitHub Bot commented on CB-14089: - joshchandler commented on a change in pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#discussion_r188038113 ## File path: bin/templates/project/Activity.kt ## @@ -0,0 +1,38 @@ +/* Review comment: I'm not entirely sure if this file should make it in and it's currently not hook up to the create method. I had just created it to do some functional testing. They claim that Kotlin is 100% interchangeable with Java as long as the stdlibs are imported.. Since that's now a thing with this change we could actually use this in favor of `Activity.java`, if you all are open to it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14089) Add Kotlin Support
[ https://issues.apache.org/jira/browse/CB-14089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474509#comment-16474509 ] ASF GitHub Bot commented on CB-14089: - joshchandler opened a new pull request #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441 ### Platforms affected Android ### What does this PR do? This adds support for the Kotlin programming language. Plugins can start being written in or converted to the language with this added. ### What testing has been done on this change? I haven't added any testing yet, but I created an example project by updating the `./bin/create` command to use `Activity.kt` as the main activity instead of `Activity.java`. Running `./cordova/run` compiles the app and the app runs without error. ### Checklist - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Kotlin Support > -- > > Key: CB-14089 > URL: https://issues.apache.org/jira/browse/CB-14089 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-android >Reporter: Joshua Chandler >Assignee: Joe Bowser >Priority: Minor > Fix For: cordova-android-7.0.0 > > > Kotlin is not supported out of the gate for cordova android projects.. You > need to explicitly configure a built android project to support it. This > should be supported out of the gate with no configuration so that plugins or > any other custom code could be written in the language. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
