[jira] [Commented] (CB-2528) Add window.onerror to index.html

2015-12-04 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041335#comment-15041335
 ] 

ASF GitHub Bot commented on CB-2528:


Github user BBosman closed the pull request at:

https://github.com/apache/cordova-app-hello-world/pull/6


> Add window.onerror to index.html
> 
>
> Key: CB-2528
> URL: https://issues.apache.org/jira/browse/CB-2528
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: App Hello World
>Reporter: Shazron Abdullah
>Assignee: Michael Brooks
>Priority: Minor
>
> https://twitter.com/purplecabbage/status/276506789065928704
> Tired of telling people to add this to debug their stuff.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-2528) Add window.onerror to index.html

2014-03-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926197#comment-13926197
 ] 

ASF GitHub Bot commented on CB-2528:


Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-app-hello-world/pull/6#issuecomment-37232204
  
@jsoref be careful not to recommend a platform specific option.  Alert 
makes sense in some cases, and console.log in some others.


> Add window.onerror to index.html
> 
>
> Key: CB-2528
> URL: https://issues.apache.org/jira/browse/CB-2528
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: App Hello World
>Reporter: Shazron Abdullah
>Assignee: Michael Brooks
>Priority: Minor
>
> https://twitter.com/purplecabbage/status/276506789065928704
> Tired of telling people to add this to debug their stuff.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-2528) Add window.onerror to index.html

2014-03-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926135#comment-13926135
 ] 

ASF GitHub Bot commented on CB-2528:


Github user jsoref commented on the pull request:


https://github.com/apache/cordova-app-hello-world/pull/6#issuecomment-37227558
  
Developers should be encouraged to use WebInspector instead...


> Add window.onerror to index.html
> 
>
> Key: CB-2528
> URL: https://issues.apache.org/jira/browse/CB-2528
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: App Hello World
>Reporter: Shazron Abdullah
>Assignee: Michael Brooks
>Priority: Minor
>
> https://twitter.com/purplecabbage/status/276506789065928704
> Tired of telling people to add this to debug their stuff.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-2528) Add window.onerror to index.html

2014-03-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13926101#comment-13926101
 ] 

ASF GitHub Bot commented on CB-2528:


Github user purplecabbage commented on the pull request:


https://github.com/apache/cordova-app-hello-world/pull/6#issuecomment-37225171
  
I agree, this would be better placed inside js/index.js and probably it 
should be /*commented*/ out with instructions to developers to uncomment it to 
catch errors.


> Add window.onerror to index.html
> 
>
> Key: CB-2528
> URL: https://issues.apache.org/jira/browse/CB-2528
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: App Hello World
>Reporter: Shazron Abdullah
>Assignee: Michael Brooks
>Priority: Minor
>
> https://twitter.com/purplecabbage/status/276506789065928704
> Tired of telling people to add this to debug their stuff.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-2528) Add window.onerror to index.html

2014-03-10 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925994#comment-13925994
 ] 

ASF GitHub Bot commented on CB-2528:


Github user jsoref commented on a diff in the pull request:


https://github.com/apache/cordova-app-hello-world/pull/6#discussion_r10442330
  
--- Diff: www/index.html ---
@@ -37,6 +37,8 @@
 
 
 

[jira] [Commented] (CB-2528) Add window.onerror to index.html

2014-02-07 Thread Bas Bosman (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895040#comment-13895040
 ] 

Bas Bosman commented on CB-2528:


Pull request: https://github.com/apache/cordova-app-hello-world/pull/6

> Add window.onerror to index.html
> 
>
> Key: CB-2528
> URL: https://issues.apache.org/jira/browse/CB-2528
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: App Hello World
>Reporter: Shazron Abdullah
>Assignee: Michael Brooks
>Priority: Minor
>
> https://twitter.com/purplecabbage/status/276506789065928704
> Tired of telling people to add this to debug their stuff.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)