[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13803594#comment-13803594 ] ASF subversion and git services commented on CB-3453: - Commit fe49c053735174d8b9ca66bbb8f0510c78a79dab in branch refs/heads/2.9.x from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=fe49c05 ] CB-5189 - ios - Backport for v2.9.1 of CB-4958, CB-3482 and CB-3453 changes > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > Fix For: 3.1.0 > > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740233#comment-13740233 ] ASF subversion and git services commented on CB-3453: - Commit 5f98661e0d90a26494b1bb7d82d9ce117facc9dd in branch refs/heads/dev from [~wjamesjong] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=5f98661 ] [CB-3453] Save original picture to photo library - saves original picture when the following camera options are set for no edits (i.e. allowEdit is false, correctOrientation is false, targetWidth/targetHeight are not specified) - this mirrors cordova-android behavior - testing done with mobile-spec auto and manual tests > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > Fix For: 3.1.0 > > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740152#comment-13740152 ] ASF subversion and git services commented on CB-3453: - Commit 5f98661e0d90a26494b1bb7d82d9ce117facc9dd in branch refs/heads/master from [~wjamesjong] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=5f98661 ] [CB-3453] Save original picture to photo library - saves original picture when the following camera options are set for no edits (i.e. allowEdit is false, correctOrientation is false, targetWidth/targetHeight are not specified) - this mirrors cordova-android behavior - testing done with mobile-spec auto and manual tests > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > Fix For: 3.1.0 > > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733860#comment-13733860 ] ASF subversion and git services commented on CB-3453: - Commit 767e064c01d224b4159dcb292017c8db521afc67 in branch refs/heads/master from [~wjamesjong] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=767e064 ] [CB-3453] Save original picture to photo library - saves original picture when the following camera options are set for no edits (i.e. allowEdit is false, correctOrientation is false, targetWidth/targetHeight are not specified) - this mirrors cordova-android behavior - testing done with mobile-spec auto and manual tests > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665166#comment-13665166 ] James Jong commented on CB-3453: Currently, the iOS behavior is always to resize. I'll start looking into this. > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665155#comment-13665155 ] Andrew Grieve commented on CB-3453: --- Nothing wrong. I agree that behaviour is fine. We should fix it for iOS. I agree the name resolveLocalFileSystemURI is weird. It's a part of the HTML5 FileSystem spec though, so that's why we're going with it. > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664945#comment-13664945 ] Abel Muiño commented on CB-3453: BTW: what's wrong with the approach used in cordova-android? (which is something like _"unless you request some changes, I'll give you an exact copy of the original"_). > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[
https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664942#comment-13664942
]
Abel Muiño commented on CB-3453:
IIRC, we tried {{resolveLocalFileSystemURI()}} without success (but using
2.6.0) for NATIVE_URIs (and FILE_URI creates this altered copy of the original
that we want to avoid).
On a side note, I find the name {{resolveLocalFileSystemURI()}} would be
confusing if it could as well handle NATIVE_URIs. Maybe
{{resolveToLocalFileSystemURI}} (or just {{resolveURI}}) would be clearer? (I
know, it would break older apps when upgrading, but some kind of alias with a
deprecation warning could be put in place).
> Retrieve the original picture from the library
> --
>
> Key: CB-3453
> URL: https://issues.apache.org/jira/browse/CB-3453
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: Master, 2.6.0, 2.7.0
>Reporter: Abel Muiño
>Assignee: James Jong
>Priority: Minor
>
> Cordova iOS always re-encodes the picture, sometimes making it larger than
> the original.
> In order to be cross-platform, it should match Android's behavior, where
> using default size, no orientation correction and 100% quality returns the
> unmodified picture (alternatively Cordova could provide an explicit API for
> reading the original pictures)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664784#comment-13664784 ] Andrew Grieve commented on CB-3453: --- Ah, okay, yeah, your use-case is one that I want to fix. This goes hand-in-hand with the similar Android bugs that you filed. Thanks for staying on top of this, I do intend to get to those in the near-term. Instead of using the FileEntry constructor (you're right - I do intend to break that :P), can you try using the resolveLocalFileSystemURI() function to convert from URI -> FileEntry? That's the (also currently undocumented) intended way to accomplish this. > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: James Jong >Priority: Minor > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664069#comment-13664069 ] Abel Muiño commented on CB-3453: Yes, we have a workaround based on NATIVE_URI and using the FileEntry constructor (which are undocumented, so I suppose it is not part of the Cordova API and prone to breaking in future versions). I now notice priority might have been set too high. > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: Shazron Abdullah > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3453) Retrieve the original picture from the library
[ https://issues.apache.org/jira/browse/CB-3453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13664061#comment-13664061 ] Andrew Grieve commented on CB-3453: --- Hi Abel, Would using destinationType: Camera.DestinationType.NATIVE_URI suite your needs here? > Retrieve the original picture from the library > -- > > Key: CB-3453 > URL: https://issues.apache.org/jira/browse/CB-3453 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: Master, 2.6.0, 2.7.0 >Reporter: Abel Muiño >Assignee: Shazron Abdullah > > Cordova iOS always re-encodes the picture, sometimes making it larger than > the original. > In order to be cross-platform, it should match Android's behavior, where > using default size, no orientation correction and 100% quality returns the > unmodified picture (alternatively Cordova could provide an explicit API for > reading the original pictures) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
