[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14164763#comment-14164763 ] ASF GitHub Bot commented on CB-3481: Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/18 > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 3.4.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088573#comment-14088573 ] ASF GitHub Bot commented on CB-3481: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/18#issuecomment-51418116 is this still valid? with everything moved to plugin tests ... merge conflicts. > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 3.4.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865852#comment-13865852 ] ASF subversion and git services commented on CB-3481: - Commit ccf92cfe72e359e213ef562c4e86db0d67228e9b in branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=ccf92cf ] CB-3481: Fixed the compass not supported issue - added a new jasmine test to check if the compass hardware is supported - added a custom matcher that trys to run a compass command, if a COMPASS_NOT_SUPPORTED error is caught then the device doesn't support compass. - on failure of the hardware check, none of the other compass tests are ran and a friendly message is shown to the user > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 3.4.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865768#comment-13865768 ] Shazron Abdullah commented on CB-3481: -- Ah ok, it has not been pulled in: https://github.com/apache/cordova-mobile-spec/commits/master/autotest/tests/compass.tests.js I'll pull it in > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 2.7.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865453#comment-13865453 ] Lisa Seacat DeLuca commented on CB-3481: [~shazron] yes, but i'm not sure if the fix was pulled into the master branch. > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 2.7.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864956#comment-13864956 ] Shazron Abdullah commented on CB-3481: -- Is this resolved (fix ver is 2.7)? > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 2.7.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686039#comment-13686039 ] Marcel Kinard commented on CB-3481: --- I checked out your topic branch and the automatic compass tests ran fine on iPhone 4,1 iOS 6.0 and iPad 2,1 iOS 5.1. I don't have a registered device without a compass. > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 2.7.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13680691#comment-13680691 ] mike billau commented on CB-3481: - Tested on the following Android devices without any problems. Android 4.2.2 - Nexus 7 (tab) Android 4.0.4 - Galaxy Tab 2, 7.0 Plus (tab) Android 3.0.1 - Motorola Xoom Wifi (tab) Android 2.3.4 - HTC Sensation 4G (phone) Android 2.2 - HTC Evo 4G (phone) Android 2.2 - Galaxy Tab 1, 7.0 (tab) > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test > Components: mobile-spec >Affects Versions: 2.7.0 >Reporter: Lisa Seacat DeLuca >Assignee: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Fix For: 2.7.0 > > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3481) MobileSpec - Compass test fails on all tests when device doesn't have compass support
[ https://issues.apache.org/jira/browse/CB-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13665294#comment-13665294 ] Lisa Seacat DeLuca commented on CB-3481: Fixed here: https://github.com/ldeluca/cordova-mobile-spec/blob/CB-3481/autotest/tests/compass.tests.js > MobileSpec - Compass test fails on all tests when device doesn't have compass > support > - > > Key: CB-3481 > URL: https://issues.apache.org/jira/browse/CB-3481 > Project: Apache Cordova > Issue Type: Test >Reporter: Lisa Seacat DeLuca >Priority: Minor > Labels: compass, test > Original Estimate: 48h > Remaining Estimate: 48h > > When the compass hardware is not supported on a device all of the compass > related tests will fail. Rather than fail them all, fail the hardware check > and give the user a helpful message as to why the test failed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
