[jira] [Commented] (CB-3509) network information javascript is tied into cordovajs
[ https://issues.apache.org/jira/browse/CB-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685860#comment-13685860 ] ASF subversion and git services commented on CB-3509: - Commit 208b97a9d3be4fe900d34c6816d21e09b1d8ebc9 in branch refs/heads/3.0.0 from Fil Maj [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=208b97a ] [CB-3509] Removed network plugin code from cordova.js 3.0 branch. Removed creation of CordovaConnectionReady channel, and its hook into waitForInitialization. > network information javascript is tied into cordovajs > - > > Key: CB-3509 > URL: https://issues.apache.org/jira/browse/CB-3509 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, Plugin Network Information >Reporter: Steve Gill >Assignee: Filip Maj > Fix For: 3.0.0 > > > cordovajs 3.0.0 branch > When we remove the network/connection javascript code from cordova-js, device > ready doesn't fire. Will need more investigation. > Remove code required by network information plugin from cordova js. > Build cordova js by running jake > Copy over newly created javascript files to android/ios 3.0.0 branches. > cordova-ios/CordovaLib/cordova.js > cordova-android/framework/assets/www/cordova.js > create android + ios projects using create scripts > run created projects, device ready doesn't fire. No need to even install > plugins. > Need to go to cordova-js and see why device ready doesn't fire after removing > these files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3509) network information javascript is tied into cordovajs
[
https://issues.apache.org/jira/browse/CB-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685833#comment-13685833
]
Filip Maj commented on CB-3509:
---
The issue is the internal cordova event {{onCordovaConnectionReady}} is
declared as "wait for this event to fire before firing deviceready":
{code}
channel.waitForInitialization('onCordovaConnectionReady');
{code}
This event is only fired inside the network plugin's JavaScript.
So, if you want to remove the network code from cordova JS, you have to make
sure the {{waitForInitialization}} call is removed as well.
To modularize this properly, the device motion plugin's JavaScript should
register the {{waitForInitialization}} call. So, when you add the network
plugin to your cordova app, deviceready will be delayed until the network
plugin loads and gets information back about the state of connectivity of the
device.
> network information javascript is tied into cordovajs
> -
>
> Key: CB-3509
> URL: https://issues.apache.org/jira/browse/CB-3509
> Project: Apache Cordova
> Issue Type: Bug
> Components: CordovaJS, Plugin Network Information
>Reporter: Steve Gill
>Assignee: Tim Kim
> Fix For: 3.0.0
>
>
> cordovajs 3.0.0 branch
> When we remove the network/connection javascript code from cordova-js, device
> ready doesn't fire. Will need more investigation.
> Remove code required by network information plugin from cordova js.
> Build cordova js by running jake
> Copy over newly created javascript files to android/ios 3.0.0 branches.
> cordova-ios/CordovaLib/cordova.js
> cordova-android/framework/assets/www/cordova.js
> create android + ios projects using create scripts
> run created projects, device ready doesn't fire. No need to even install
> plugins.
> Need to go to cordova-js and see why device ready doesn't fire after removing
> these files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3509) network information javascript is tied into cordovajs
[ https://issues.apache.org/jira/browse/CB-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13677532#comment-13677532 ] Tim Kim commented on CB-3509: - Ok, ya definitely not getting the deviceready event to fire. I'm not sure what the solution to fix this, will ping list. > network information javascript is tied into cordovajs > - > > Key: CB-3509 > URL: https://issues.apache.org/jira/browse/CB-3509 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, Plugin Network Information >Reporter: Steve Gill >Assignee: Tim Kim > Fix For: 3.0.0 > > > cordovajs 3.0.0 branch > When we remove the network/connection javascript code from cordova-js, device > ready doesn't fire. Will need more investigation. > Remove code required by network information plugin from cordova js. > Build cordova js by running jake > Copy over newly created javascript files to android/ios 3.0.0 branches. > cordova-ios/CordovaLib/cordova.js > cordova-android/framework/assets/www/cordova.js > create android + ios projects using create scripts > run created projects, device ready doesn't fire. No need to even install > plugins. > Need to go to cordova-js and see why device ready doesn't fire after removing > these files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3509) network information javascript is tied into cordovajs
[ https://issues.apache.org/jira/browse/CB-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676505#comment-13676505 ] Tim Kim commented on CB-3509: - Oh wait, I didn't realise I had to rip out the common/network stuff - thought it had been done already. Let me try that again. > network information javascript is tied into cordovajs > - > > Key: CB-3509 > URL: https://issues.apache.org/jira/browse/CB-3509 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, Plugin Network Information >Reporter: Steve Gill >Assignee: Tim Kim > Fix For: 3.0.0 > > > cordovajs 3.0.0 branch > When we remove the network/connection javascript code from cordova-js, device > ready doesn't fire. Will need more investigation. > Remove code required by network information plugin from cordova js. > Build cordova js by running jake > Copy over newly created javascript files to android/ios 3.0.0 branches. > cordova-ios/CordovaLib/cordova.js > cordova-android/framework/assets/www/cordova.js > create android + ios projects using create scripts > run created projects, device ready doesn't fire. No need to even install > plugins. > Need to go to cordova-js and see why device ready doesn't fire after removing > these files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3509) network information javascript is tied into cordovajs
[ https://issues.apache.org/jira/browse/CB-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676485#comment-13676485 ] Tim Kim commented on CB-3509: - Hrm, I just tested on device with android with the 3.0.0 branches and it seems to work okay. It did complain about the Network Connection class not being found in the logs though. I'll need to reconvene with Steve and ask him about the device ready not firing. > network information javascript is tied into cordovajs > - > > Key: CB-3509 > URL: https://issues.apache.org/jira/browse/CB-3509 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, Plugin Network Information >Reporter: Steve Gill >Assignee: Tim Kim > Fix For: 3.0.0 > > > cordovajs 3.0.0 branch > When we remove the network/connection javascript code from cordova-js, device > ready doesn't fire. Will need more investigation. > Remove code required by network information plugin from cordova js. > Build cordova js by running jake > Copy over newly created javascript files to android/ios 3.0.0 branches. > cordova-ios/CordovaLib/cordova.js > cordova-android/framework/assets/www/cordova.js > create android + ios projects using create scripts > run created projects, device ready doesn't fire. No need to even install > plugins. > Need to go to cordova-js and see why device ready doesn't fire after removing > these files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3509) network information javascript is tied into cordovajs
[ https://issues.apache.org/jira/browse/CB-3509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1386#comment-1386 ] Tim Kim commented on CB-3509: - Ok, I think I kinda figured out why deviceready isn't firing: 1) In the network.js file, it deals with firing the online/offline events for Cordova - so removing this will cause these events not to fire. 2) In the the android exec.js file, it uses the network online/offline events to start up the communication with the native side. 3) Therefore, the removal of the network.js file is not starting the js communication with the native side which is a good cause for the device ready event not firing. I'm not sure what a good work around for this right now. I'm too familiar with the internals of cordova js for android. I will seek help for this quest. > network information javascript is tied into cordovajs > - > > Key: CB-3509 > URL: https://issues.apache.org/jira/browse/CB-3509 > Project: Apache Cordova > Issue Type: Bug > Components: CordovaJS, Plugin Network Information >Reporter: Steve Gill >Assignee: Tim Kim > Fix For: 3.0.0 > > > cordovajs 3.0.0 branch > When we remove the network/connection javascript code from cordova-js, device > ready doesn't fire. Will need more investigation. > Remove code required by network information plugin from cordova js. > Build cordova js by running jake > Copy over newly created javascript files to android/ios 3.0.0 branches. > cordova-ios/CordovaLib/cordova.js > cordova-android/framework/assets/www/cordova.js > create android + ios projects using create scripts > run created projects, device ready doesn't fire. No need to even install > plugins. > Need to go to cordova-js and see why device ready doesn't fire after removing > these files. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
