[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483287#comment-14483287 ] ASF GitHub Bot commented on CB-3679: Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-90591245 This was merged. Will be applicable for cordova-android@4.0.0 Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14483288#comment-14483288 ] ASF GitHub Bot commented on CB-3679: Github user agrieve closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/32 Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309448#comment-14309448 ] ASF GitHub Bot commented on CB-3679: Github user cgwyllie commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-73274586 @agrieve @jbavari Hey, been looking into this for a while this afternoon and was wondering how it's possible to use the version of Cordova that doesn't have the splash code bundled on Android. Any pointer would be appreciated! Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309575#comment-14309575 ] Andrew Grieve commented on CB-3679: --- The version of cordova-android @ master has it removed. Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242749#comment-14242749 ] ASF subversion and git services commented on CB-3679: - Commit ddec7008cbab13865ff1321696bfeacd577e7169 in cordova-plugin-splashscreen's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=ddec700 ] CB-3679 Add engine tag for Android = 3.6.0 due to use of `preferences` Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241693#comment-14241693 ] ASF subversion and git services commented on CB-3679: - Commit 27f1181d53a6feca77f5bb645892f7d357a6f35a in cordova-android's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=27f1181 ] CB-3679 Move splashscreen logic into splashscreen plugin Tried as hard as possible for this not to be a breaking change (all symbols were preserved). Planning to remove delegating symbols in 4.0.x though. Also for backwards compatability - a copy of the plugin is bundled. It will likewise be removed in 4.0.x Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241694#comment-14241694 ] ASF subversion and git services commented on CB-3679: - Commit 50e4887aa19c0a4692216e6c8f817e0043c7931b in cordova-plugin-splashscreen's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=50e4887 ] CB-3679 Break Android splashscreen logic into splascreen plugin Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241730#comment-14241730 ] ASF subversion and git services commented on CB-3679: - Commit e593fe3f53251c67a001a56c473b1a5b9fd913b5 in cordova-plugin-splashscreen's branch refs/heads/master from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-splashscreen.git;h=e593fe3 ] CB-3679 Make SplashScreen plugin compatible with cordova-android@4.0.x Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241733#comment-14241733 ] ASF subversion and git services commented on CB-3679: - Commit 27f1181d53a6feca77f5bb645892f7d357a6f35a in cordova-android's branch refs/heads/4.0.x from [~agrieve] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=27f1181 ] CB-3679 Move splashscreen logic into splashscreen plugin Tried as hard as possible for this not to be a breaking change (all symbols were preserved). Planning to remove delegating symbols in 4.0.x though. Also for backwards compatability - a copy of the plugin is bundled. It will likewise be removed in 4.0.x Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241734#comment-14241734 ] ASF GitHub Bot commented on CB-3679: Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-66524675 merged. Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241735#comment-14241735 ] ASF GitHub Bot commented on CB-3679: Github user agrieve closed the pull request at: https://github.com/apache/cordova-android/pull/134 Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238227#comment-14238227 ] ASF GitHub Bot commented on CB-3679: Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-66163613 Glad that this is taking spinners out. Those spinners have been a personal pet-peeve for years. Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238228#comment-14238228 ] ASF GitHub Bot commented on CB-3679: Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-66163749 This looks good, let's merge it in. :+1: Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236153#comment-14236153 ] ASF GitHub Bot commented on CB-3679: Github user jbavari commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-65858347 Andrew, I looked through the code. Everything looks good from what I saw here. :+1: Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14236228#comment-14236228 ] ASF GitHub Bot commented on CB-3679: Github user jbavari commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-65865043 Works great. :+1: Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225040#comment-14225040 ] Joe Bowser commented on CB-3679: Are there tests attached to this? Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225078#comment-14225078 ] Andrew Grieve commented on CB-3679: --- Sorry - PRs aren't quite ready. Will hopefully get around to it this week. This shouldn't affect any tests. I'll be sure to run them before updating the PR, but this is 100% a refactoring, so shouldn't change behaviour. Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Andrew Grieve Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215849#comment-14215849 ] ASF GitHub Bot commented on CB-3679: GitHub user agrieve opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32 CB-3679 Break Android splashscreen logic into splascreen plugin You can merge this pull request into a Git repository by running: $ git pull https://github.com/agrieve/cordova-plugin-splashscreen splash-break Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-splashscreen/pull/32.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #32 commit ab8a3fada7687a2dab3f0264dbb78027fa8f6c2d Author: Andrew Grieve agri...@chromium.org Date: 2014-11-18T07:48:45Z CB-3679 Break Android splashscreen logic into splascreen plugin Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Steve Gill Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-3679) Breakout SplashScreen Plugin for Android
[ https://issues.apache.org/jira/browse/CB-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14215850#comment-14215850 ] ASF GitHub Bot commented on CB-3679: GitHub user agrieve opened a pull request: https://github.com/apache/cordova-android/pull/134 CB-3679 Move splashscreen logic into splashscreen plugin Tried as hard as possible for this not to be a breaking change (all symbols were preserved). Planning to remove delegating symbols in 4.0.x though. You can merge this pull request into a Git repository by running: $ git pull https://github.com/agrieve/cordova-android splash-break Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/134.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #134 commit 6aa767791b05fd621700c707ca0bd7ea37adbee4 Author: Andrew Grieve agri...@chromium.org Date: 2014-11-18T07:46:39Z CB-3679 Move splashscreen logic into splashscreen plugin Tried as hard as possible for this not to be a breaking change (all symbols were preserved). Planning to remove delegating symbols in 4.0.x though. Breakout SplashScreen Plugin for Android Key: CB-3679 URL: https://issues.apache.org/jira/browse/CB-3679 Project: Apache Cordova Issue Type: Improvement Components: Android, Plugin SplashScreen Reporter: Steve Gill Assignee: Steve Gill Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
