[jira] [Commented] (CB-3970) Make notification.beep cross platform in js
[ https://issues.apache.org/jira/browse/CB-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693372#comment-13693372 ] ASF subversion and git services commented on CB-3970: - Commit 5db12530ffd70f1154a3ff918c7f5c45524462ec in branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=5db1253 ] [CB-3970] Make notification.beep cross platform in js > Make notification.beep cross platform in js > --- > > Key: CB-3970 > URL: https://issues.apache.org/jira/browse/CB-3970 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Dialogs, Plugin Vibration >Reporter: Steve Gill >Assignee: Shazron Abdullah > Fix For: 3.0.0 > > > Their is a ios specific notification.js file in cordova-plugin-vibration that > use Media to do a beep. We should redo beep to use the common definition of > beep in the common notification.js file and remove the ios specific one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3970) Make notification.beep cross platform in js
[ https://issues.apache.org/jira/browse/CB-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13693309#comment-13693309 ] Shazron Abdullah commented on CB-3970: -- beep.wav: https://github.com/apache/cordova-ios/blob/4c63589acbc1f37e8aa70c30e1a57560a496af0a/iphone/beep.wav > Make notification.beep cross platform in js > --- > > Key: CB-3970 > URL: https://issues.apache.org/jira/browse/CB-3970 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Dialogs, Plugin Vibration >Reporter: Steve Gill >Assignee: Shazron Abdullah > Fix For: 3.0.0 > > > Their is a ios specific notification.js file in cordova-plugin-vibration that > use Media to do a beep. We should redo beep to use the common definition of > beep in the common notification.js file and remove the ios specific one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3970) Make notification.beep cross platform in js
[ https://issues.apache.org/jira/browse/CB-3970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13690968#comment-13690968 ] Shazron Abdullah commented on CB-3970: -- Plus, include the beep.wav as an asset for iOS in the plugin, make sure it gets copied in as a resource to the .app bundle. Use the AudioToolbox.framework for short system sounds: {code} // add in CDVNotification.h, .m - (void) beep:(CDVInvokedUrlCommand*)command { SystemSoundID completeSound; NSURL *audioPath = [[NSBundle mainBundle] URLForResource:@"beep" withExtension:@"wav"]; AudioServicesCreateSystemSoundID((CFURLRef)audioPath, &completeSound); AudioServicesPlaySystemSound (completeSound); } {code} > Make notification.beep cross platform in js > --- > > Key: CB-3970 > URL: https://issues.apache.org/jira/browse/CB-3970 > Project: Apache Cordova > Issue Type: Bug > Components: iOS, Plugin Dialogs, Plugin Vibration >Reporter: Steve Gill >Assignee: Shazron Abdullah > > Their is a ios specific notification.js file in cordova-plugin-vibration that > use Media to do a beep. We should redo beep to use the common definition of > beep in the common notification.js file and remove the ios specific one. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira