[jira] [Commented] (CB-3971) Breakout notification/dialog plugin from vibration plugin
[ https://issues.apache.org/jira/browse/CB-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895803#comment-13895803 ] ASF subversion and git services commented on CB-3971: - Commit b4e5646d621ddb7bee8b02c2c04fabf6ad1b5986 in branch refs/heads/master from [~ldeluca] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=b4e5646 ] CB-3971 Break vibrations tests out from notification - won't break existing platforms where code is not yet separated - breaks out the vibrations from the notifications so they may be tested separately. Breakout notification/dialog plugin from vibration plugin - Key: CB-3971 URL: https://issues.apache.org/jira/browse/CB-3971 Project: Apache Cordova Issue Type: Improvement Components: Android, BlackBerry, iOS, Plugin Dialogs, Plugin Vibration, WP7, WP8 Reporter: Steve Gill Fix For: 3.0.0 Currently the notification plugin and the vibration plugin are in one file. We need to break these out into two separate plugins. I believe we can accomplish this before 3.0. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-3971) Breakout notification/dialog plugin from vibration plugin
[ https://issues.apache.org/jira/browse/CB-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13694158#comment-13694158 ] Steve Gill commented on CB-3971: Just took a look at the pull request. It looks like you are doing this work on cordova-android master. I would recommend against doing this. Right after 2.9.0, we are switching over to using the 3.0 branches that exsit for each of the platforms. You will notice that no plugins exist on those branches. I recommend that these changes instead happen on the new plugin repos. For vibration, checkout https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-vibration.git;a=summary. For dialogs, checkout https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;a=summary. To test these, checkout the 3.0 branch for android, create a example project by using the create script and then use the latest plugman to install the plugins into the example app. Copy the plugins test directoires into the www folder (or copy in mobile spec). In the vibration repo, feel free to rename notification.java to vibration.java and make the changes you made in your pull request there. The javascript in that repo will also have to be renamed away from notification. Lets discuss more on irc. Breakout notification/dialog plugin from vibration plugin - Key: CB-3971 URL: https://issues.apache.org/jira/browse/CB-3971 Project: Apache Cordova Issue Type: Improvement Components: Android, BlackBerry, iOS, Plugin Dialogs, Plugin Vibration, WP7, WP8 Reporter: Steve Gill Fix For: 3.0.0 Currently the notification plugin and the vibration plugin are in one file. We need to break these out into two separate plugins. I believe we can accomplish this before 3.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3971) Breakout notification/dialog plugin from vibration plugin
[ https://issues.apache.org/jira/browse/CB-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13692990#comment-13692990 ] Lisa Seacat DeLuca commented on CB-3971: I am looking into this for Android Breakout notification/dialog plugin from vibration plugin - Key: CB-3971 URL: https://issues.apache.org/jira/browse/CB-3971 Project: Apache Cordova Issue Type: Improvement Components: Android, BlackBerry, iOS, Plugin Dialogs, Plugin Vibration, WP7, WP8 Reporter: Steve Gill Assignee: Lisa Seacat DeLuca Fix For: 3.0.0 Currently the notification plugin and the vibration plugin are in one file. We need to break these out into two separate plugins. I believe we can accomplish this before 3.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3971) Breakout notification/dialog plugin from vibration plugin
[ https://issues.apache.org/jira/browse/CB-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13693111#comment-13693111 ] Lisa Seacat DeLuca commented on CB-3971: Edited the mobile test spec to have separate tests for notifications and vibrations. tested on android devices. mostly refactoring. the pull request is here: https://github.com/apache/cordova-mobile-spec/pull/30 Breakout notification/dialog plugin from vibration plugin - Key: CB-3971 URL: https://issues.apache.org/jira/browse/CB-3971 Project: Apache Cordova Issue Type: Improvement Components: Android, BlackBerry, iOS, Plugin Dialogs, Plugin Vibration, WP7, WP8 Reporter: Steve Gill Fix For: 3.0.0 Currently the notification plugin and the vibration plugin are in one file. We need to break these out into two separate plugins. I believe we can accomplish this before 3.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3971) Breakout notification/dialog plugin from vibration plugin
[ https://issues.apache.org/jira/browse/CB-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13693127#comment-13693127 ] Lisa Seacat DeLuca commented on CB-3971: With my updates, I assumed that the structure to send a vibration is still going to be part of navigator.notification, correct? http://cordova.apache.org/docs/en/edge/cordova_notification_notification.md.html#notification.vibrate if we're going to change to something like navigator.vibrate and further extract from the notification piece we'll need to also update the documentation, test cases, etc. thoughts? Breakout notification/dialog plugin from vibration plugin - Key: CB-3971 URL: https://issues.apache.org/jira/browse/CB-3971 Project: Apache Cordova Issue Type: Improvement Components: Android, BlackBerry, iOS, Plugin Dialogs, Plugin Vibration, WP7, WP8 Reporter: Steve Gill Fix For: 3.0.0 Currently the notification plugin and the vibration plugin are in one file. We need to break these out into two separate plugins. I believe we can accomplish this before 3.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-3971) Breakout notification/dialog plugin from vibration plugin
[ https://issues.apache.org/jira/browse/CB-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13693198#comment-13693198 ] Andrew Grieve commented on CB-3971: --- Just sent an email to the dev list about whether we want to create a new plugin repo for 3.0 for this. For sure we need to keep the symbol on navigator.notification, at least until we deprecate it in favour of a new location (which would make more sense). Probably we'd want navigator.vibrate() as per http://www.w3.org/TR/vibration/. Breakout notification/dialog plugin from vibration plugin - Key: CB-3971 URL: https://issues.apache.org/jira/browse/CB-3971 Project: Apache Cordova Issue Type: Improvement Components: Android, BlackBerry, iOS, Plugin Dialogs, Plugin Vibration, WP7, WP8 Reporter: Steve Gill Fix For: 3.0.0 Currently the notification plugin and the vibration plugin are in one file. We need to break these out into two separate plugins. I believe we can accomplish this before 3.0. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
