[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
[ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941840#comment-13941840 ] Mike Billau commented on CB-4096: - [~iclelland], yes that was the thread I was reading but somehow missed Andrew's argument against using subdomains attribute. Fail. I didn't realize that the attribute was never documented, I assumed that since it was in the instructions for setting up mobile-spec that it'd be in the Whitelist guide, but the only mention of it in the official docs seems to be under the Blackberry section. In light of this I agree, we should axe the subdomains=true attribute. Since it hasn't been documented, I think it's fine to completely take it out instead of belatedly deprecating. I'll withdrawal my pull request -- thanks a lot for the comments anyway. Android - Unify Whitelist Implemenations Key: CB-4096 URL: https://issues.apache.org/jira/browse/CB-4096 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 3.0.0 Reporter: Andrew Grieve Assignee: Ian Clelland Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
[ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941847#comment-13941847 ] ASF GitHub Bot commented on CB-4096: Github user mbillau closed the pull request at: https://github.com/apache/cordova-android/pull/95 Android - Unify Whitelist Implemenations Key: CB-4096 URL: https://issues.apache.org/jira/browse/CB-4096 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 3.0.0 Reporter: Andrew Grieve Assignee: Ian Clelland Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
[
https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940696#comment-13940696
]
Mike Billau commented on CB-4096:
-
[~iclelland], what are the plans for the 'subdomains=true' flag? There was
nothing in the ML thread. The android code still parses out this attribute from
the XML and passes the flag around to all of the whitelist methods, it just
never utilizes it. It seems trivial to add code in
https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/Whitelist.java#L139
like this:
{code}
if( subdomains ){
if( scheme == null) scheme = ;
String sub = scheme + *. + host; // generate *.host subdomain
addWhiteListEntry(sub, false);
}
{code}
This would ensure back-compatibility for anyone still using the subdomains
flag. I think we might as well use this since so much of the code still passes
around the subdomain flag. We could add a deprecation notice here.
Android - Unify Whitelist Implemenations
Key: CB-4096
URL: https://issues.apache.org/jira/browse/CB-4096
Project: Apache Cordova
Issue Type: Sub-task
Components: Android
Affects Versions: 3.0.0
Reporter: Andrew Grieve
Assignee: Ian Clelland
Fix For: 3.1.0
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
[ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940815#comment-13940815 ] ASF GitHub Bot commented on CB-4096: GitHub user mbillau opened a pull request: https://github.com/apache/cordova-android/pull/95 Allow subdomains flag in Whitelist xml for backcompat With the new Whitelist implementation, the `subdomains=true` flag for the whitelist is being ignored even though the attribute is still parsed from XML and passed around our code. I think that we might as well allow this flag for backwards compatibility. https://issues.apache.org/jira/browse/CB-4096 You can merge this pull request into a Git repository by running: $ git pull https://github.com/mbillau/cordova-android CB-4096 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-android/pull/95.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #95 commit b95d729312ef00f59c75e43d73a73818cadd8761 Author: mbillau mike.bil...@gmail.com Date: 2014-03-19T18:21:08Z Allow subdomains flag in Whitelist xml for backcompat Android - Unify Whitelist Implemenations Key: CB-4096 URL: https://issues.apache.org/jira/browse/CB-4096 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 3.0.0 Reporter: Andrew Grieve Assignee: Ian Clelland Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
[ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940819#comment-13940819 ] Mike Billau commented on CB-4096: - https://github.com/apache/cordova-android/pull/95 I can merge this in myself if nobody comments in the next few days. Android - Unify Whitelist Implemenations Key: CB-4096 URL: https://issues.apache.org/jira/browse/CB-4096 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 3.0.0 Reporter: Andrew Grieve Assignee: Ian Clelland Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
[ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940907#comment-13940907 ] Ian Clelland commented on CB-4096: -- [~mrbillau], are you referring to [this ML thread|http://callback.markmail.org/thread/lqadhj3uqqtmohka]? I thought that the problem of two competing formats was raised, and that the consensus at the end was to go with *.origin.com as the single standard. (And the parent of this issue, CB-4093, has the description 'Ditch the subdomains=true attribute') I didn't realize it still parsed it; I think that code should be removed, but was probably left in for a very weak sort of backwards compatibility -- just not breaking existing apps. Digging back through the repo looking for history, support for the attribute has been there since the very first Android whitelist commit (80df4a8, Sept. 2011) but doesn't appear to ever have been documented. I'm not convinced that it makes sense to re-introduce support for this undocumented flag, 8 months later, in the name of backwards compatibility. Anybody who has used Cordova since v2.9 (when it was removed) has already had to deal with it not working, and would have switched to *.origin.com already. The only people who would get the backwards compatibility benefits now would be those who are upgrading directly from =2.8 to 3.5. Could we belatedly deprecate this, without changing current behaviour, by printing a notice if the subdomains attribute is used, on cordova prepare, or in the Android log? If we add it back now, I think we should immediately deprecate it, and then completely remove it in Cordova 3.8 or so. Android - Unify Whitelist Implemenations Key: CB-4096 URL: https://issues.apache.org/jira/browse/CB-4096 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 3.0.0 Reporter: Andrew Grieve Assignee: Ian Clelland Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4096) Android - Unify Whitelist Implemenations
[ https://issues.apache.org/jira/browse/CB-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716483#comment-13716483 ] ASF subversion and git services commented on CB-4096: - Commit 463c7b50277dda5978e2d5e1f1e296ab9e6a6e82 in branch refs/heads/master from [~iclelland] [ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=463c7b5 ] [CB-4096] Implemente new unified whitelist for android Android - Unify Whitelist Implemenations Key: CB-4096 URL: https://issues.apache.org/jira/browse/CB-4096 Project: Apache Cordova Issue Type: Sub-task Components: Android Affects Versions: 3.0.0 Reporter: Andrew Grieve Assignee: Ian Clelland -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
