[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717743#comment-13717743 ] Peter commented on CB-4130: --- There is no other bug opened. The only issue is that filetransfer.spec.13 was failing. CB-4130 is all you need. The "fix" assumed the test was faulty, whereas we thought the test was good and the FileTransfer code caused the fail. In other words, please consider reopening the current issue and change the subject: * to be: "mobilespec filetransfer.spec.13 fails due to incorrect body" * instead of: "mobilespec filetransfer.spec.13 fails due to incorrect body test" > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716333#comment-13716333 ] David Kemp commented on CB-4130: Is there a bug opened for that? I verified that the correct website was returned and the returned page did not end with a newline. I did not dig deeper to see if the fetch was dropping a newline. > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714859#comment-13714859 ] Peter commented on CB-4130: --- We also investigated the reason for this test fail and found that the problem originates in FileTransfer.createFileTransferError() due to the readLine() which is ignoring the line terminator which actually _does_ exist on that page. Ref: http://docs.oracle.com/javase/1.5.0/docs/api/java/io/BufferedReader.html#readLine%28%29 Changing the test expect surely makes the test pass, but isn't that just masking the real problem instead of fixing it? > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706085#comment-13706085 ] Joe Bowser commented on CB-4130: Nexus 10, Android 4.2.2. > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706033#comment-13706033 ] David Kemp commented on CB-4130: I just retested on iOS and android and do not see a failure. What is your test environment? > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706011#comment-13706011 ] Joe Bowser commented on CB-4130: There's now a space that causes this to fail instead of a newline character. > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703330#comment-13703330 ] ASF subversion and git services commented on CB-4130: - Commit 22f8c4d562721d3249e7753f44d6745c078c4d62 in branch refs/heads/master from [~drkemp] [ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=22f8c4d ] CB-4130 : changed test to be independent of newline > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4130) mobilespec filetransfer.spec.13 fails due to incorrect body test
[ https://issues.apache.org/jira/browse/CB-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703316#comment-13703316 ] David Kemp commented on CB-4130: fixed in pull request https://github.com/apache/cordova-mobile-spec/pull/33 > mobilespec filetransfer.spec.13 fails due to incorrect body test > > > Key: CB-4130 > URL: https://issues.apache.org/jira/browse/CB-4130 > Project: Apache Cordova > Issue Type: Bug > Components: Android, mobile-spec >Affects Versions: 3.0.0 > Environment: verified nexus 7 - should affect all android >Reporter: David Kemp >Assignee: David Kemp >Priority: Minor > Fix For: 3.0.0 > > > 404 test gets back a correct response that does not end with a newline, - the > test requires a newline on the end of the response. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
