[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718772#comment-13718772 ] Anis Kadri commented on CB-4358: cool! > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[
https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717847#comment-13717847
]
Filip Maj commented on CB-4358:
---
Yes.
The values of the variables are stored in the .json (i.e.
{{android.json}}, {{ios.json}}) files, which are stored in the directory
specified by {{--plugins_dir}} flag. Those values are the interpolated into the
plugin.xml-specified config fragments [during creation of the "config
munge"|https://github.com/apache/cordova-plugman/blob/master/src/util/config-changes.js#L120].
> Trim amount of frameworks (18) in default template to minimum needed (4)
> -
>
> Key: CB-4358
> URL: https://issues.apache.org/jira/browse/CB-4358
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.0.0
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.1.0
>
>
> These are the only 4 frameworks needed for 3.0.0 with just CordovaLib:
> - MobileCoreServices.framework
> - CoreGraphics.framework
> - CoreLocation.framework
> - AssetsLibrary.framework
> Ensure the default template only ships with these, right now it ships with 18
> frameworks specified.
> NOTE: After doing this, re-test all core plugins, I'm sure some of them will
> fail since they probably depend on the frameworks already existing in the
> default template. The frameworks they need will have to be specified in their
> plugin.xml (file separate bugs for each plugin)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717843#comment-13717843 ] Anis Kadri commented on CB-4358: That sounds correct to me. btw [~filmaj] does that reference counting work for config fragments that have variables in them ? > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717841#comment-13717841 ] Filip Maj commented on CB-4358: --- So it sounds like a refactor of the config-changes module is in order to support XML, plist and pbxproj modifications with this reference-counting approach. Is that correct? > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717834#comment-13717834 ] Anis Kadri commented on CB-4358: Correct. *.framework are added to *.pbxproj. I don't think there are any other necessary modifications. > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[
https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717830#comment-13717830
]
Filip Maj commented on CB-4358:
---
plugman currently does something like reference counting for config-file
elements: it breaks up XML or plist-style configuration changes into a single
modification per child leaf element, then iterates through all plugins to count
how many times each such child leaf element is referenced by different plugins.
It also uses the {{parent}} XPath selector to differentiate between potentially
identical xml leaf elements under different areas of the config doc. That's
what the
[config-changes|https://github.com/apache/cordova-plugman/blob/master/src/util/config-changes.js]
module does in plugman. I'll spend some time this week to document that code
better so it's not so imposing.
So with the above, when a plugin gets uninstalled, this giant multi-plugin
"config munge" gets decremented with the plugin-to-be-uninstalled's particular
configuration changes. If there are any leaf elements in this config graph
munge that have a reference count of zero, we know we can safely remove it.
Sounds like this same thing is necessary for {{.framework}} files. However
these are not references in either XML or plist files but rather the project's
{{pbxproj}} file, correct?
> Trim amount of frameworks (18) in default template to minimum needed (4)
> -
>
> Key: CB-4358
> URL: https://issues.apache.org/jira/browse/CB-4358
> Project: Apache Cordova
> Issue Type: Bug
> Components: iOS
>Affects Versions: 3.0.0
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
> Fix For: 3.1.0
>
>
> These are the only 4 frameworks needed for 3.0.0 with just CordovaLib:
> - MobileCoreServices.framework
> - CoreGraphics.framework
> - CoreLocation.framework
> - AssetsLibrary.framework
> Ensure the default template only ships with these, right now it ships with 18
> frameworks specified.
> NOTE: After doing this, re-test all core plugins, I'm sure some of them will
> fail since they probably depend on the frameworks already existing in the
> default template. The frameworks they need will have to be specified in their
> plugin.xml (file separate bugs for each plugin)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717709#comment-13717709 ] Shazron Abdullah commented on CB-4358: -- Update: I've tested all the core plugins and made changes to the plugins that needed to specify framework dependencies. The 5 plugins affected were: Dialogs, Camera, Contacts, Network Info, Vibration. Once Fil chimes in maybe this related issue should be filed as a new issue. > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717699#comment-13717699 ] Anis Kadri commented on CB-4358: dependency support, as I understand it, is in effect for other Cordova plugins. It should be extendable to frameworks as well, couldn't it ? [~filmaj] There are other things that are not cleaned up either such as configuration fragments that have variables in them (Facebook-Connect and MapKit plugins use it). We can't destroy the project and rebuild it because people do make modifications to their projects. > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717651#comment-13717651 ] ASF subversion and git services commented on CB-4358: - Commit 9d204382fa7e8b92ebe5f962ecfaabf710b03e72 in branch refs/heads/master from [~shazron] [ https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=9d20438 ] [CB-4358] Trim amount of frameworks (18) in default template to minimum needed (4) > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717598#comment-13717598 ] Shazron Abdullah commented on CB-4358: -- In an ideal world where devs won't touch the project without using the CLI, we could use some sort of framework reference counting I suppose. I *think* plugman already kinda uses this for s in plugin.xml, on a plugin level. > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716453#comment-13716453 ] Andrew Grieve commented on CB-4358: --- Bah, just remember that linked frameworks *must* appear in the top-level project. Having a sub-project won't help. > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716444#comment-13716444 ] Michal Mocny commented on CB-4358: -- The problem of handling plugin/platform removal comes up a lot for various reasons like this. Its hard to know what to clean up, especially in the face of overlap with other plugins. What if we just clear everything and re-build that project artifacts from scratch, i.e. re-install all remaining plugins? As-is, this would mean trouncing on any user-changes inside platforms, but we already signal that those files are not the be modified don't we? We should support long-lived places for those types of user changes, such as the app manifest. Is that feasible? I think Joe often points out that external devs do make changes to platforms even against suggestion. > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-4358) Trim amount of frameworks (18) in default template to minimum needed (4)
[ https://issues.apache.org/jira/browse/CB-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13716437#comment-13716437 ] Andrew Grieve commented on CB-4358: --- Along the lines of frameworks - how should we handle uninstall of a plugin that added a framework? It will be common for multiple plugins to require the same framework. For the embedded case, it will be common for an app to require frameworks as well. One solution that comes to mind would be to put all plugins in their own sub-project. Then it can just be re-generated upon uninstall instead of trying to patch up the user's project file. [~anis] > Trim amount of frameworks (18) in default template to minimum needed (4) > - > > Key: CB-4358 > URL: https://issues.apache.org/jira/browse/CB-4358 > Project: Apache Cordova > Issue Type: Bug > Components: iOS >Affects Versions: 3.0.0 >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah > Fix For: 3.1.0 > > > These are the only 4 frameworks needed for 3.0.0 with just CordovaLib: > - MobileCoreServices.framework > - CoreGraphics.framework > - CoreLocation.framework > - AssetsLibrary.framework > Ensure the default template only ships with these, right now it ships with 18 > frameworks specified. > NOTE: After doing this, re-test all core plugins, I'm sure some of them will > fail since they probably depend on the frameworks already existing in the > default template. The frameworks they need will have to be specified in their > plugin.xml (file separate bugs for each plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
