[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented
[ https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14696926#comment-14696926 ] ASF GitHub Bot commented on CB-4614: Github user svkirans closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/54 Contact.save and Contact.remove - method signatures not documented -- Key: CB-4614 URL: https://issues.apache.org/jira/browse/CB-4614 Project: Apache Cordova Issue Type: Improvement Components: Docs, Plugin Contacts Affects Versions: 2.9.0 Reporter: Peter Assignee: Michael Brooks Priority: Minor The method signatures for Contact methods *save* and *remove* are not documented. Only in the examples can you see that they have parameters for onSuccess and onError callbacks. Ref http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented
[ https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14630990#comment-14630990 ] Andrey Kurdyumov commented on CB-4614: -- Still not fixed. Contact.save and Contact.remove - method signatures not documented -- Key: CB-4614 URL: https://issues.apache.org/jira/browse/CB-4614 Project: Apache Cordova Issue Type: Improvement Components: Docs, Plugin Contacts Affects Versions: 2.9.0 Reporter: Peter Assignee: Michael Brooks Priority: Minor The method signatures for Contact methods *save* and *remove* are not documented. Only in the examples can you see that they have parameters for onSuccess and onError callbacks. Ref http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented
[ https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297058#comment-14297058 ] ASF GitHub Bot commented on CB-4614: Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72050202 @svkirans: please use `git commit --amend` and fix your commit message to match the style. Contact.save and Contact.remove - method signatures not documented -- Key: CB-4614 URL: https://issues.apache.org/jira/browse/CB-4614 Project: Apache Cordova Issue Type: Improvement Components: Docs, Plugin Contacts Affects Versions: 2.9.0 Reporter: Peter Assignee: Michael Brooks Priority: Minor The method signatures for Contact methods *save* and *remove* are not documented. Only in the examples can you see that they have parameters for onSuccess and onError callbacks. Ref http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented
[ https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297035#comment-14297035 ] ASF GitHub Bot commented on CB-4614: GitHub user svkirans opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/54 Fix for CB-4614 Fix for CB-4614 You can merge this pull request into a Git repository by running: $ git pull https://github.com/svkirans/cordova-plugin-contacts CB-4614 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-contacts/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit e47ede740e3d9f01428e1141319eb1e1154527b6 Author: Kiran svkir...@gmail.com Date: 2015-01-29T15:46:36Z Fix for CB-4614 Contact.save and Contact.remove - method signatures not documented -- Key: CB-4614 URL: https://issues.apache.org/jira/browse/CB-4614 Project: Apache Cordova Issue Type: Improvement Components: Docs, Plugin Contacts Affects Versions: 2.9.0 Reporter: Peter Assignee: Michael Brooks Priority: Minor The method signatures for Contact methods *save* and *remove* are not documented. Only in the examples can you see that they have parameters for onSuccess and onError callbacks. Ref http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented
[ https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297042#comment-14297042 ] ASF GitHub Bot commented on CB-4614: Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72047729 Please see http://wiki.apache.org/cordova/IssueWorkflow#About_Commit_Messages Contact.save and Contact.remove - method signatures not documented -- Key: CB-4614 URL: https://issues.apache.org/jira/browse/CB-4614 Project: Apache Cordova Issue Type: Improvement Components: Docs, Plugin Contacts Affects Versions: 2.9.0 Reporter: Peter Assignee: Michael Brooks Priority: Minor The method signatures for Contact methods *save* and *remove* are not documented. Only in the examples can you see that they have parameters for onSuccess and onError callbacks. Ref http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented
[ https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297048#comment-14297048 ] ASF GitHub Bot commented on CB-4614: Github user svkirans commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72048606 Added documentation for remove and save functions in contact. Contact.save and Contact.remove - method signatures not documented -- Key: CB-4614 URL: https://issues.apache.org/jira/browse/CB-4614 Project: Apache Cordova Issue Type: Improvement Components: Docs, Plugin Contacts Affects Versions: 2.9.0 Reporter: Peter Assignee: Michael Brooks Priority: Minor The method signatures for Contact methods *save* and *remove* are not documented. Only in the examples can you see that they have parameters for onSuccess and onError callbacks. Ref http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4614) Contact.save and Contact.remove - method signatures not documented
[ https://issues.apache.org/jira/browse/CB-4614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297337#comment-14297337 ] ASF GitHub Bot commented on CB-4614: Github user jsoref commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/54#issuecomment-72081856 The first line of your commit message isn't in the right form. Also, please use `git rebase -i` and you should `fold` your commits into a single commit. Contact.save and Contact.remove - method signatures not documented -- Key: CB-4614 URL: https://issues.apache.org/jira/browse/CB-4614 Project: Apache Cordova Issue Type: Improvement Components: Docs, Plugin Contacts Affects Versions: 2.9.0 Reporter: Peter Assignee: Michael Brooks Priority: Minor The method signatures for Contact methods *save* and *remove* are not documented. Only in the examples can you see that they have parameters for onSuccess and onError callbacks. Ref http://cordova.apache.org/docs/en/2.9.0/cordova_contacts_contacts.md.html#Contact -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
