[jira] [Commented] (CB-4789) cordova tool should recognize when platforms/$plat directory is deleted
[
https://issues.apache.org/jira/browse/CB-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14379228#comment-14379228
]
Andrew Grieve commented on CB-4789:
---
This would still be a nice thing to have work. I think at this point it would
be as simple as moving android.json, ios.json files from being within
plugins/ to being within the respective platforms/PLAT directory.
Would need to update:
* ./cordova/platform.js (has code to remove the .js file on platform rm)
* ./cordova/prepare.js (to reapply munge)
* ./plugman/prepare.js: (to apply munge via plugman)
* ./plugman/prepare-browserify.js: (to apply munge via plugman)
* ./plugman/install.js: (update list of installed plugins)
* ./plugman/uninstall.js: (update list of installed plugins), (finds all
dependents in all other platforms to delete dependents)
cordova tool should recognize when platforms/$plat directory is deleted
---
Key: CB-4789
URL: https://issues.apache.org/jira/browse/CB-4789
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Environment: Mac OSX 10.8.4, Cordova CLI 3.0.9, Xcode build tools
4.6.3 (also tried Xcode 5.0 build tools).
Reporter: Owen
Priority: Minor
Steps:
{code}
cordova create Project com.foo.bar Project
cd Project
cordova platform add ios
cordova plugin add ...
rm -rf platforms/ios
cordova platform add ios
{code}
This leaves you in a bad state where things work, but plugins are not
re-installed by platform add.
Maybe as a fix we should have some precondition checks before running
commands. E.g. validate that our cached state-of-the-world matches reality.
In this specific case, the `platform add ios` should first detect that ios
was deleted and internally run `platform rm ios` first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4789) cordova tool should recognize when platforms/$plat directory is deleted
[
https://issues.apache.org/jira/browse/CB-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14360677#comment-14360677
]
ASF GitHub Bot commented on CB-4789:
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-plugin-whitelist/pull/2#issuecomment-79145875
Test CB-4789
cordova tool should recognize when platforms/$plat directory is deleted
---
Key: CB-4789
URL: https://issues.apache.org/jira/browse/CB-4789
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Environment: Mac OSX 10.8.4, Cordova CLI 3.0.9, Xcode build tools
4.6.3 (also tried Xcode 5.0 build tools).
Reporter: Owen
Priority: Minor
Steps:
{code}
cordova create Project com.foo.bar Project
cd Project
cordova platform add ios
cordova plugin add ...
rm -rf platforms/ios
cordova platform add ios
{code}
This leaves you in a bad state where things work, but plugins are not
re-installed by platform add.
Maybe as a fix we should have some precondition checks before running
commands. E.g. validate that our cached state-of-the-world matches reality.
In this specific case, the `platform add ios` should first detect that ios
was deleted and internally run `platform rm ios` first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-4789) cordova tool should recognize when platforms/$plat directory is deleted
[
https://issues.apache.org/jira/browse/CB-4789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280334#comment-14280334
]
ASF subversion and git services commented on CB-4789:
-
Commit 36ffb18d97f420d519bf46b83ad5048343b8f6c4 in cordova-lib's branch
refs/heads/master from [~agrieve]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=36ffb18 ]
CB-4789 refactor: Remove config_changes.get/set_platform_json in favour of
PlatformJson
Addresses longstanding TODO and makes us one step closer to being able
to change the location of the platform.json files to be within their
respective platforms
cordova tool should recognize when platforms/$plat directory is deleted
---
Key: CB-4789
URL: https://issues.apache.org/jira/browse/CB-4789
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Environment: Mac OSX 10.8.4, Cordova CLI 3.0.9, Xcode build tools
4.6.3 (also tried Xcode 5.0 build tools).
Reporter: Owen
Priority: Minor
Steps:
{code}
cordova create Project com.foo.bar Project
cd Project
cordova platform add ios
cordova plugin add ...
rm -rf platforms/ios
cordova platform add ios
{code}
This leaves you in a bad state where things work, but plugins are not
re-installed by platform add.
Maybe as a fix we should have some precondition checks before running
commands. E.g. validate that our cached state-of-the-world matches reality.
In this specific case, the `platform add ios` should first detect that ios
was deleted and internally run `platform rm ios` first.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
