[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984304#comment-13984304 ] ASF GitHub Bot commented on CB-4966: Github user zalun closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/16 > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984303#comment-13984303 ] ASF GitHub Bot commented on CB-4966: Github user zalun closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/17 > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981517#comment-13981517 ] ASF subversion and git services commented on CB-4966: - Commit 4ebf797ab39d903e5ad796adf87393223818e5f2 in cordova-plugin-dialogs's branch refs/heads/master from [~zalun] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-dialogs.git;h=4ebf797 ] CB-4966 Dialogs are in window now No need to add anything to manifest or index.html > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981106#comment-13981106 ] ASF GitHub Bot commented on CB-4966: Github user zalun closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/15 > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981105#comment-13981105 ] ASF GitHub Bot commented on CB-4966: Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/15#issuecomment-41404063 It's in master > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956415#comment-13956415 ] Piotr Zalewa commented on CB-4966: -- Separate window approach will have to wait until Firefox API for opening and close singular windows (opened by window.open() ) will settle down. It's currently behaving in a different way in every version (1.1, 1.2 and 1.3). > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947906#comment-13947906 ] ASF GitHub Bot commented on CB-4966: GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/17 CB-4966 Removing FirefoxOS Quirks * no need to add special permission (it's different API with the same name) * notification.css is added automatically This still creates dialogs inside main DOM You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugin-dialogs add-css-to-DOM Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-dialogs/pull/17.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #17 commit 8016d774cbe19709c2d68024d2a74e85b7f6d372 Author: Piotr Zalewa Date: 2014-03-26T13:20:19Z Removing FirefoxOS Quirks * no need to add special permission (it's different API with the same name) * notification.css is added automatically > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923879#comment-13923879 ] Piotr Zalewa commented on CB-4966: -- The idea behind is purity. Displaying the dialog by covering the DOM with a specific layer might implement few issues. CSS might be corrupted by some declarations inside index.css, it might happen that DOM elements might get duplicated. Adding notification.css to entire DOM is a little too broad. Having it in separate window brings ability to go out of the dialog without making a choice (Certainly this could be implemented to current version). No need to add css file to your app HTML. Adding it for FirefoxOS sake only will require removing it from all HTML files when building for other platforms. Well there is an issue about blocking dialogs. Imagine using notification.alert will stop your app from contacting the server. Current implementation of the plugin is not blocking, but has above issues. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13923675#comment-13923675 ] RobberPhex commented on CB-4966: Sorry, I don't know that why you implement dialog by new window. I use the plugin "org.apache.cordova.dialogs 0.2.6", with notification.css¬ification.js As for block the js, I tested in Firefox OS 1.2, When call *navigator.notification.alert* and *navigator.notification.prompt*, The counter(window.setTimeout(count, 1000);) works normally. As for alert function, I think it is raw js function, I don't think it is a problem that alert block other js function. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922486#comment-13922486 ] Piotr Zalewa commented on CB-4966: -- English is not my first language as well. I will try to assume: 1. The link you've posted - https://developer.mozilla.org/en-US/docs/Web/API/notification is about the desktop notification system which is displaying alerts and confirmations. As far as I know it cannot be used for receiving feedback from users. To provide dialogs (alert, confirm and prompt) Cordova has a Notification API. It is displaying these dialog windows asynchronously (the rest of the code is still executed) and provides the results via callback system. 2. You've mentioned master branch. If it is cordova-plugin-dialogs master branch then I don't see how it would work without src/firefoxos/notification.js file which development we're discussing here. 3. You've also mentioned permission. Yes. alert, prompt and confirm usage is not restricted. 4. Not standard. Valid point, but there is no standard and asynchronous dialogs available in FirefoxOS. Unfortunately you're also right on the issue which comes from this - changing the skin of FirefoxOS will not be reflected in dialogs generated by this plugin. Standard alert, prompt and confirm have two issues which prevent us from using inside Cordova plugin. 4.1 They are not compatible with Cordova API - There is no way to change the title and button labels. 4.2. They are blocking JS execution. This is major as displaying an alert will stop other running JS functions. This is an example http://jsfiddle.net/zalun/DSF5D/ I've been talking about these issues with our apps team at Mozilla. I don't remember anyone bringing the skin issue, but I still think it's a low cost to pay when the alternative is a completely incompatible API. The standard API is still present for developer to use in the app, there is no restriction on that. On the other side developer has now the power to change the skin of these dialog windows which obviously might be a pro and a con. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919242#comment-13919242 ] RobberPhex commented on CB-4966: [~zalun] Sorry for my poor English. The Web API notification is too simple too provide the prompt and confirm. I mean, the master branch is work fine, we should not put all together into HTML and display it. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919226#comment-13919226 ] Piotr Zalewa commented on CB-4966: -- AFAIK Mozilla Notification API is to display messages inside the "drawer" where all system messages are placed. This has nothing about prompt or confirm. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13919100#comment-13919100 ] RobberPhex commented on CB-4966: [~zalun] I just disagree implement by use new window. The FirefoxOS provide a method to show notification(https://developer.mozilla.org/en-US/docs/Web/API/notification), so, we can use it. and, The master is using FirefoxOS's standard API, and it works well. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918246#comment-13918246 ] Piotr Zalewa commented on CB-4966: -- [~RobberPhex] You mean the entire plugin is not good idea? ad 1) Yes it's not standard, but Cordova API is very different froom standard one ad 2) OS theme? Right - it is an issue Which method? Standard alert(), prompt(). What bug? Thanks > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918196#comment-13918196 ] RobberPhex commented on CB-4966: I think it is not a good idea. First, it is not standard, the app alert sometext without permission. Second, If use custom the theme, the apps will not change. So, I think the existing methods is good, but it still have some bug. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883500#comment-13883500 ] Piotr Zalewa commented on CB-4966: -- Thanks > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883441#comment-13883441 ] Herm Wong commented on CB-4966: --- I've created a separate issue for the broken prompt response. https://issues.apache.org/jira/browse/CB-5906. The pull request has been merged. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882825#comment-13882825 ] Piotr Zalewa commented on CB-4966: -- Prompt response was broken. There was also an error in buttonIndex (starting from 0 instead of 1) https://github.com/apache/cordova-plugin-dialogs/pull/15 > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867997#comment-13867997 ] Piotr Zalewa commented on CB-4966: -- Created pull request with docs in place https://github.com/apache/cordova-plugin-dialogs/pull/11 > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843587#comment-13843587 ] Piotr Zalewa commented on CB-4966: -- The fix is in this commit; https://github.com/zalun/cordova-plugin-dialogs/commit/b44c1385a3e1762dc56b6018588400f10fab8320 > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13843577#comment-13843577 ] Piotr Zalewa commented on CB-4966: -- There is an error in plugin.xml - files are copied to css instead of img > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840270#comment-13840270 ] James Long commented on CB-4966: Ok, so I guess this is resolved, and we just need to make a documentation note about including the CSS file. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838887#comment-13838887 ] Piotr Zalewa commented on CB-4966: -- Built in are simply alert(), prompt() etc. These are very different from the Cordova ones. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13833088#comment-13833088 ] Steve Gill commented on CB-4966: I haven't seen the built in ones but trust your guys opinion on them. It would be nice to see FFOS have better support for them in the future. For now, I say copy over the contents using plugin.xml and add documentation to the plugin readme and http://cordova.apache.org/docs/en/3.2.0/cordova_notification_notification.md.html#Notification instructing users to add the css into their project. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832771#comment-13832771 ] James Long commented on CB-4966: Steve, what is your opinion? The builtin alert is less customizable and worse, is blocking. It doesn't seem like we can offer it as it's too restricted. I wonder if there's anyway we can get the styles on the native alert though... > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831396#comment-13831396 ] Piotr Zalewa commented on CB-4966: -- Yes - they are needed - otherwise we would need to cripple the experience provided by API. The default FXOS alerts are blocking. Also no title or additional buttons are allowed. One can not amend the text on the default buttons. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830252#comment-13830252 ] Steve Gill commented on CB-4966: I think it will have to be a documentation issue for now. It is strange to me that we adding image + css files for this plugin. We usually just go off the default system style for alerts/dialogs. Are the images + css necessary? > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830147#comment-13830147 ] James Long commented on CB-4966: Hey guys, can you answer the above questions? > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808187#comment-13808187 ] Piotr Zalewa commented on CB-4966: -- There are also img files > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13808105#comment-13808105 ] James Long commented on CB-4966: The last thing needed here is the CSS. How is the user expected to pull in the CSS needed for the dialog? The plugin.xml file tells it to copy the CSS into into the app directory, but then user needs to manually add a tag, right? How does that work cross-platform? > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805726#comment-13805726 ] Steve Gill commented on CB-4966: No need to worry about dependencies in this case. They used to be one plugin but have been broken out to two. You can easy plugin add the vibration plugin and then the tests would pass. I have merged this in onto the dev branch > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805721#comment-13805721 ] James Long commented on CB-4966: All the tests pass except one: https://github.com/apache/cordova-mobile-spec/blob/master/autotest/tests/notification.tests.js#L29 How do plugin dependencies work? Do we have to add the vibration plugin for this to work? Actually, I just noticed that vibration isn't even listed as a plugin in the documentation. Is vibration a part of the notification plugin? That seems weird. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805191#comment-13805191 ] Piotr Zalewa commented on CB-4966: -- Arguments fixed with https://github.com/zalun/cordova-plugin-dialogs/commit/77a73ece0fc90a8a60d12eabf0b7aa3db112f29d > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805187#comment-13805187 ] Piotr Zalewa commented on CB-4966: -- Just found out that the call to executed function changed as well. All arguments (title, message and buttonLabels) are now passed as an array in first argument. I'm changing that. > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805139#comment-13805139 ] Piotr Zalewa commented on CB-4966: -- Old plugin style. Fixed with https://github.com/zalun/cordova-plugin-dialogs/commit/25e6a24d6c624efb91d83c5a308306028e1586e9 > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804817#comment-13804817 ] Steve Gill commented on CB-4966: This plugin is causing device ready not to fire on ffos. I haven't debugged it. Needs more work > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4966) dialog
[ https://issues.apache.org/jira/browse/CB-4966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804041#comment-13804041 ] Piotr Zalewa commented on CB-4966: -- Design added - seems like it's ready for testing. Could someone help me with that? > dialog > -- > > Key: CB-4966 > URL: https://issues.apache.org/jira/browse/CB-4966 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Dialogs > Environment: firefoxos >Reporter: Piotr Zalewa > > I started developing it - only the CSS is left - no idea how to conect it to > main CSS (is it needed?) > https://github.com/zalun/cordova-plugin-dialogs -- This message was sent by Atlassian JIRA (v6.1#6144)
