[jira] [Commented] (CB-5065) Using git-ref on cordova plugin add fails with error

2013-10-15 Thread Braden Shepherdson (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795290#comment-13795290
 ] 

Braden Shepherdson commented on CB-5065:


I believe that extra tmp_dir is from a time when the command was 'cd %s; git 
checkout %s'. But that has since been replaced with passing the cwd parameter 
to child_process.exec. It's a bit worrying that the tests didn't catch this, 
though.

 Using git-ref on cordova plugin add fails with error
 --

 Key: CB-5065
 URL: https://issues.apache.org/jira/browse/CB-5065
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugman
Reporter: Marcel Kinard
Assignee: Marcel Kinard
Priority: Minor

 When trying to add a plugin using a git-ref, it fails with an error:
 $ ../cordova-cli/bin/cordova --verbose plugin add 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0
 Calling plugman.fetch on plugin 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0;
 Fetching plugin from 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0;...
 Fetching plugin from https://github.com/apache/cordova-plugin-console.git;...
 Fetching plugin via git-clone command: git clone 
 https://github.com/apache/cordova-plugin-console.git; 
 plugman-tmp1381514955645
 Plugin https://github.com/apache/cordova-plugin-console.git; fetched.
 Error: Error fetching plugin: Error: Command failed: error: pathspec 'r0.2.0' 
 did not match any file(s) known to git.
 at /Users/marcelk/Developer/apache/cordova-cli/src/plugin.js:94:41
 at _rejected 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/q/q.js:808:24)
 at /Users/marcelk/Developer/apache/cordova-cli/node_modules/q/q.js:834:30
 at Promise.when 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:1079:31)
 at Promise.promise.promiseDispatch 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:752:41)
 at 
 /Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:574:44
 at flush 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:108:17)
 at process._tickCallback (node.js:415:13)



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5065) Using git-ref on cordova plugin add fails with error

2013-10-15 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795447#comment-13795447
 ] 

ASF subversion and git services commented on CB-5065:
-

Commit 8ef2108794a0de6ed93237ce2fb438995bed8490 in branch refs/heads/master 
from [~cmarcelk]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=8ef2108 ]

CB-5065 remove breaking parameter

Get the cordova plugin add 
https://github.com/apache/cordova-plugin-console.git#r0.2.0; format working 
again.


 Using git-ref on cordova plugin add fails with error
 --

 Key: CB-5065
 URL: https://issues.apache.org/jira/browse/CB-5065
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugman
Reporter: Marcel Kinard
Assignee: Marcel Kinard
Priority: Minor

 When trying to add a plugin using a git-ref, it fails with an error:
 $ ../cordova-cli/bin/cordova --verbose plugin add 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0
 Calling plugman.fetch on plugin 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0;
 Fetching plugin from 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0;...
 Fetching plugin from https://github.com/apache/cordova-plugin-console.git;...
 Fetching plugin via git-clone command: git clone 
 https://github.com/apache/cordova-plugin-console.git; 
 plugman-tmp1381514955645
 Plugin https://github.com/apache/cordova-plugin-console.git; fetched.
 Error: Error fetching plugin: Error: Command failed: error: pathspec 'r0.2.0' 
 did not match any file(s) known to git.
 at /Users/marcelk/Developer/apache/cordova-cli/src/plugin.js:94:41
 at _rejected 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/q/q.js:808:24)
 at /Users/marcelk/Developer/apache/cordova-cli/node_modules/q/q.js:834:30
 at Promise.when 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:1079:31)
 at Promise.promise.promiseDispatch 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:752:41)
 at 
 /Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:574:44
 at flush 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:108:17)
 at process._tickCallback (node.js:415:13)



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5065) Using git-ref on cordova plugin add fails with error

2013-10-15 Thread Marcel Kinard (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795448#comment-13795448
 ] 

Marcel Kinard commented on CB-5065:
---

I made the fix so the git-ref will work on cordova plugin add. I'll 
investigate why the tests didn't catch this.

 Using git-ref on cordova plugin add fails with error
 --

 Key: CB-5065
 URL: https://issues.apache.org/jira/browse/CB-5065
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugman
Reporter: Marcel Kinard
Assignee: Marcel Kinard
Priority: Minor

 When trying to add a plugin using a git-ref, it fails with an error:
 $ ../cordova-cli/bin/cordova --verbose plugin add 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0
 Calling plugman.fetch on plugin 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0;
 Fetching plugin from 
 https://github.com/apache/cordova-plugin-console.git#r0.2.0;...
 Fetching plugin from https://github.com/apache/cordova-plugin-console.git;...
 Fetching plugin via git-clone command: git clone 
 https://github.com/apache/cordova-plugin-console.git; 
 plugman-tmp1381514955645
 Plugin https://github.com/apache/cordova-plugin-console.git; fetched.
 Error: Error fetching plugin: Error: Command failed: error: pathspec 'r0.2.0' 
 did not match any file(s) known to git.
 at /Users/marcelk/Developer/apache/cordova-cli/src/plugin.js:94:41
 at _rejected 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/q/q.js:808:24)
 at /Users/marcelk/Developer/apache/cordova-cli/node_modules/q/q.js:834:30
 at Promise.when 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:1079:31)
 at Promise.promise.promiseDispatch 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:752:41)
 at 
 /Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:574:44
 at flush 
 (/Users/marcelk/Developer/apache/cordova-cli/node_modules/plugman/node_modules/q/q.js:108:17)
 at process._tickCallback (node.js:415:13)



--
This message was sent by Atlassian JIRA
(v6.1#6144)