[jira] [Commented] (CB-5114) Windows 8.1 - Use a new proxy as old geolocation methods is deprecated
[ https://issues.apache.org/jira/browse/CB-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089775#comment-14089775 ] ASF subversion and git services commented on CB-5114: - Commit a8e9efe93c704a2ef975febed39e8df669eeff79 in cordova-plugin-geolocation's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=a8e9efe ] Merge branch 'CB-5114' of https://github.com/sgrebnov/cordova-plugin-geolocation > Windows 8.1 - Use a new proxy as old geolocation methods is deprecated > -- > > Key: CB-5114 > URL: https://issues.apache.org/jira/browse/CB-5114 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Windows 8 >Reporter: Maxime LUCE >Assignee: Sergey Grebnov > > In WinJS 2.0 : Geolocation.Geocoordinate.Latitude, Longitude, Altitude has > been replaced by Geolocation.Geopoint.Position.Latitude, ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5114) Windows 8.1 - Use a new proxy as old geolocation methods is deprecated
[ https://issues.apache.org/jira/browse/CB-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14089765#comment-14089765 ] ASF GitHub Bot commented on CB-5114: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/18 > Windows 8.1 - Use a new proxy as old geolocation methods is deprecated > -- > > Key: CB-5114 > URL: https://issues.apache.org/jira/browse/CB-5114 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Windows 8 >Reporter: Maxime LUCE >Assignee: Sergey Grebnov > > In WinJS 2.0 : Geolocation.Geocoordinate.Latitude, Longitude, Altitude has > been replaced by Geolocation.Geopoint.Position.Latitude, ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5114) Windows 8.1 - Use a new proxy as old geolocation methods is deprecated
[ https://issues.apache.org/jira/browse/CB-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058703#comment-14058703 ] Sergey Grebnov commented on CB-5114: Rebased, added minor corrections, tested and sent PR https://github.com/apache/cordova-plugin-geolocation/pull/18 Thx, Maxime! Please let me know if the PR looks good to you > Windows 8.1 - Use a new proxy as old geolocation methods is deprecated > -- > > Key: CB-5114 > URL: https://issues.apache.org/jira/browse/CB-5114 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Windows 8 >Reporter: Maxime LUCE >Assignee: Sergey Grebnov > > In WinJS 2.0 : Geolocation.Geocoordinate.Latitude, Longitude, Altitude has > been replaced by Geolocation.Geopoint.Position.Latitude, ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5114) Windows 8.1 - Use a new proxy as old geolocation methods is deprecated
[ https://issues.apache.org/jira/browse/CB-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058701#comment-14058701 ] ASF GitHub Bot commented on CB-5114: GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/18 CB- 5114 Windows 8.1 - Use a new proxy as old geolocation methods is deprecated https://issues.apache.org/jira/browse/CB-5114 * Tested on Windows 8.0, Windows 8.1, Windows Phone 8.1 * There are 'windows8' and 'windows' sections which are totally equal. This is done by design so that we can deprecate 'windows8' section in the future You can merge this pull request into a Git repository by running: $ git pull https://github.com/sgrebnov/cordova-plugin-geolocation CB-5114 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-geolocation/pull/18.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #18 commit e9eaa78a9016783a1f8576c88e3cbda943bf5e3b Author: SomaticIT Date: 2013-10-17T10:45:40Z CB-5114 Append Windows 8.1 into plugin.xml + Optimize Windows 8 Geolocation proxy commit c1bcd6b6fe808079bd8891c063bf037fb4934506 Author: sgrebnov Date: 2014-07-11T12:02:30Z CB-5114 Windows 8.1 - Use a new proxy as old geolocation methods is deprecated * Added separate section for Windows Univeral Apps * Made GeolocationProxy compatible with windows8.0 and 8.1 api versions > Windows 8.1 - Use a new proxy as old geolocation methods is deprecated > -- > > Key: CB-5114 > URL: https://issues.apache.org/jira/browse/CB-5114 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Windows 8 >Reporter: Maxime LUCE >Assignee: Sergey Grebnov > > In WinJS 2.0 : Geolocation.Geocoordinate.Latitude, Longitude, Altitude has > been replaced by Geolocation.Geopoint.Position.Latitude, ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5114) Windows 8.1 - Use a new proxy as old geolocation methods is deprecated
[ https://issues.apache.org/jira/browse/CB-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056425#comment-14056425 ] Maxime LUCE commented on CB-5114: - OK let me know if you have any problems. Thx > Windows 8.1 - Use a new proxy as old geolocation methods is deprecated > -- > > Key: CB-5114 > URL: https://issues.apache.org/jira/browse/CB-5114 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Windows 8 >Reporter: Maxime LUCE >Assignee: Sergey Grebnov > > In WinJS 2.0 : Geolocation.Geocoordinate.Latitude, Longitude, Altitude has > been replaced by Geolocation.Geopoint.Position.Latitude, ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5114) Windows 8.1 - Use a new proxy as old geolocation methods is deprecated
[ https://issues.apache.org/jira/browse/CB-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055089#comment-14055089 ] Sergey Grebnov commented on CB-5114: Hi Maxime, I'l review your implementation on this week, Thx for your work! > Windows 8.1 - Use a new proxy as old geolocation methods is deprecated > -- > > Key: CB-5114 > URL: https://issues.apache.org/jira/browse/CB-5114 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Windows 8 >Reporter: Maxime LUCE >Assignee: Sergey Grebnov > > In WinJS 2.0 : Geolocation.Geocoordinate.Latitude, Longitude, Altitude has > been replaced by Geolocation.Geopoint.Position.Latitude, ... -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5114) Windows 8.1 - Use a new proxy as old geolocation methods is deprecated
[ https://issues.apache.org/jira/browse/CB-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055027#comment-14055027 ] Maxime LUCE commented on CB-5114: - Hi Sergey, There is already a pull-request in Github for this plugin. Can you merge it or do you need some change ? I can edit the original code if you want. > Windows 8.1 - Use a new proxy as old geolocation methods is deprecated > -- > > Key: CB-5114 > URL: https://issues.apache.org/jira/browse/CB-5114 > Project: Apache Cordova > Issue Type: Sub-task > Components: Plugin Geolocation, Windows 8 >Reporter: Maxime LUCE >Assignee: Sergey Grebnov > > In WinJS 2.0 : Geolocation.Geocoordinate.Latitude, Longitude, Altitude has > been replaced by Geolocation.Geopoint.Position.Latitude, ... -- This message was sent by Atlassian JIRA (v6.2#6252)