[jira] [Commented] (CB-5364) Config parser uniqueness check is invalid

2013-11-14 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822876#comment-13822876
 ] 

ASF subversion and git services commented on CB-5364:
-

Commit 133836739c9f19de7a9e4dc8074dc0341fa8939c in branch refs/heads/master 
from [~bhigg...@blackberry.com]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=1338367 ]

CB-5364 config_parser - check for null element text


> Config parser uniqueness check is invalid
> -
>
> Key: CB-5364
> URL: https://issues.apache.org/jira/browse/CB-5364
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.1.0
>Reporter: Bryan Higgins
>Assignee: Bryan Higgins
>Priority: Critical
> Fix For: 3.2.0
>
>
> Two cases have been overlooked:
> 1) Child tags
> 2) Text
> The result is developers can't add a child or elements with differing text to 
> config.xml when the a plugin also installs the same parent element.
> For BlackBerry, this means developers cannot manually add permissions after 
> adding any plugin which injects a permission.
> Fix is in progress for 3.2.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5364) Config parser uniqueness check is invalid

2013-11-13 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821279#comment-13821279
 ] 

ASF subversion and git services commented on CB-5364:
-

Commit f6da763065b56223ed6835166f675741a24def50 in branch refs/heads/master 
from [~bhigg...@blackberry.com]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=f6da763 ]

CB-5364 config_parser - handle duplicates with children and text when merging


> Config parser uniqueness check is invalid
> -
>
> Key: CB-5364
> URL: https://issues.apache.org/jira/browse/CB-5364
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.1.0
>Reporter: Bryan Higgins
>Assignee: Bryan Higgins
>Priority: Critical
> Fix For: 3.2.0
>
>
> Two cases have been overlooked:
> 1) Child tags
> 2) Text
> The result is developers can't add a child or elements with differing text to 
> config.xml when the a plugin also installs the same parent element.
> For BlackBerry, this means developers cannot manually add permissions after 
> adding any plugin which injects a permission.
> Fix is in progress for 3.2.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5364) Config parser uniqueness check is invalid

2013-11-12 Thread Bryan Higgins (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13820412#comment-13820412
 ] 

Bryan Higgins commented on CB-5364:
---

https://reviews.apache.org/r/15461/diff/

> Config parser uniqueness check is invalid
> -
>
> Key: CB-5364
> URL: https://issues.apache.org/jira/browse/CB-5364
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: CLI
>Affects Versions: 3.1.0
>Reporter: Bryan Higgins
>Assignee: Bryan Higgins
>Priority: Critical
> Fix For: 3.2.0
>
>
> Two cases have been overlooked:
> 1) Child tags
> 2) Text
> The result is developers can't add a child or elements with differing text to 
> config.xml when the a plugin also installs the same parent element.
> For BlackBerry, this means developers cannot manually add permissions after 
> adding any plugin which injects a permission.
> Fix is in progress for 3.2.



--
This message was sent by Atlassian JIRA
(v6.1#6144)