[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies
[ https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917418#comment-13917418 ] Ian Clelland commented on CB-6140: -- Bryan, is this a regression since CLI 3.3.0-0.1.0? > Plugman allows deletion of dependencies > --- > > Key: CB-6140 > URL: https://issues.apache.org/jira/browse/CB-6140 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Bryan Higgins > > plugman 0.20.1 / CLI 3.4.0-0.1.2 > After a dependency was automatically added for me, I am able to remove it. > "prepare" then complains about a missing plugin.xml file > I used the following plugin, but I suspect this behaviour would occur for all > with a top-level dependency: > https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies
[ https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917487#comment-13917487 ] David Kemp commented on CB-6140: >From the description I assume that i should be able to replicate this with the >file-transfer plugin. Below is console output that I get - not showing the problem. Is it specific to the platform maybe? I am currently using only Android.. drkemp-macbookpro:tap drkemp$ cordova plugin list [ 'org.apache.cordova.camera', 'org.apache.cordova.device-orientation', 'org.apache.cordova.geolocation', 'org.apache.cordova.inappbrowser', 'org.apache.cordova.network-information', 'org.apache.cordova.vibration' ] drkemp-macbookpro:tap drkemp$ cordova plugin add org.apache.cordova.file-transfer Fetching plugin "org.apache.cordova.file-transfer" via plugin registry Installing org.apache.cordova.file-transfer (android) Fetching plugin "org.apache.cordova.file" via plugin registry Installing org.apache.cordova.file (android) drkemp-macbookpro:tap drkemp$ cordova plugin list [ 'org.apache.cordova.camera', 'org.apache.cordova.device-orientation', 'org.apache.cordova.file', 'org.apache.cordova.file-transfer', 'org.apache.cordova.geolocation', 'org.apache.cordova.inappbrowser', 'org.apache.cordova.network-information', 'org.apache.cordova.vibration' ] drkemp-macbookpro:tap drkemp$ cordova plugin remove org.apache.cordova.file Deleting plugin org.apache.cordova.file No dangling plugins to remove. drkemp-macbookpro:tap drkemp$ cordova plugin list [ 'org.apache.cordova.camera', 'org.apache.cordova.device-orientation', 'org.apache.cordova.file', 'org.apache.cordova.file-transfer', 'org.apache.cordova.geolocation', 'org.apache.cordova.inappbrowser', 'org.apache.cordova.network-information', 'org.apache.cordova.vibration' ] drkemp-macbookpro:tap drkemp$ cordova prepare drkemp-macbookpro:tap drkemp$ cordova -v 3.4.0-0.1.2 drkemp-macbookpro:tap drkemp$ plugman -v 0.20.1 drkemp-macbookpro:tap drkemp$ > Plugman allows deletion of dependencies > --- > > Key: CB-6140 > URL: https://issues.apache.org/jira/browse/CB-6140 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Bryan Higgins > > plugman 0.20.1 / CLI 3.4.0-0.1.2 > After a dependency was automatically added for me, I am able to remove it. > "prepare" then complains about a missing plugin.xml file > I used the following plugin, but I suspect this behaviour would occur for all > with a top-level dependency: > https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies
[ https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918085#comment-13918085 ] Bryan Higgins commented on CB-6140: --- Thanks for taking a look guys. I double checked a couple of things: The file-transfer plugin does work correctly on BB10. So perhaps this is limited in scope to lib-file only plugins. The same issue is out there in 3.4.0-0.1.0. I must have picked a different plugin which also had js-modules when I tested that release. So this issue would definitely not block the release. I should have time later this week to investigate further. > Plugman allows deletion of dependencies > --- > > Key: CB-6140 > URL: https://issues.apache.org/jira/browse/CB-6140 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Bryan Higgins > > plugman 0.20.1 / CLI 3.4.0-0.1.2 > After a dependency was automatically added for me, I am able to remove it. > "prepare" then complains about a missing plugin.xml file > I used the following plugin, but I suspect this behaviour would occur for all > with a top-level dependency: > https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies
[ https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938599#comment-13938599 ] Josh Soref commented on CB-6140: Using [~jbondc]'s fix for CB-6272, $ PATH=$PATH:/Cordova/cordova-cli/bin:/adt-bundle-mac-x86_64-20130917/sdk/tools:~/apache-ant-1.9.2/bin sh -c 'cordova create yip; cd yip; cordova platform add android ios blackberry10; cordova plugin add org.cordova.mobile-spec-dependencies --searchpath ~/Cordova/cordova-mobile-spec; cordova plugin remove org.cordova.mobile-spec-dependencies; cordova plugin' Creating a new cordova project with name "HelloCordova" and id "io.cordova.hellocordova" at location "...yip" Creating android project... Creating Cordova project for the Android platform: ... Creating ios project... Creating blackberry10 project... ... Installing "org.apache.cordova.test.echo" for ios Uninstalling 20 dependent plugins. Uninstalling org.apache.cordova.battery-status from android ... Uninstalling org.cordova.mobile-spec-dependencies from android Uninstalling 20 dependent plugins. Uninstalling org.apache.cordova.battery-status from blackberry10 ... Uninstalling org.cordova.mobile-spec-dependencies from blackberry10 Uninstalling 20 dependent plugins. Uninstalling org.apache.cordova.battery-status from iOS ... Uninstalling org.cordova.mobile-spec-dependencies from ios Removing "org.cordova.mobile-spec-dependencies" [ 'com.blackberry.pim.lib', 'com.blackberry.utils' ] $ cordova plugin [ 'com.blackberry.pim.lib', 'com.blackberry.utils' ] $ cordova plugin rm com.blackberry.pim.lib Uninstalling com.blackberry.pim.lib from android Uninstalling com.blackberry.pim.lib from blackberry10 Uninstalling com.blackberry.pim.lib from ios Removing "com.blackberry.pim.lib" $ cordova plugin [ 'com.blackberry.utils' ] $ cordova plugin rm com.blackberry.utils Uninstalling com.blackberry.utils from android q/q.js:126 throw e; ^ Error: ENOENT, no such file or directory 'yip/plugins/com.blackberry.pim.lib/plugin.xml' at Object.fs.openSync (fs.js:427:18) at Object.fs.readFileSync (fs.js:284:15) at Object.module.exports.parseElementtreeSync (cordova-plugman/src/util/xml-helpers.js:119:27) at cordova-plugman/src/util/dependencies.js:40:35 at Array.forEach (native) at Object.module.exports.package.generate_dependency_info (cordova-plugman/src/util/dependencies.js:39:45) at runUninstallPlatform (cordova-plugman/src/uninstall.js:173:53) at Function.module.exports.uninstallPlatform (cordova-plugman/src/uninstall.js:55:12) at cordova-cli/src/plugin.js:173:58 at _fulfilled (q/q.js:798:54) ... > Plugman allows deletion of dependencies > --- > > Key: CB-6140 > URL: https://issues.apache.org/jira/browse/CB-6140 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Bryan Higgins > > plugman 0.20.1 / CLI 3.4.0-0.1.2 > After a dependency was automatically added for me, I am able to remove it. > "prepare" then complains about a missing plugin.xml file > I used the following plugin, but I suspect this behaviour would occur for all > with a top-level dependency: > https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies
[ https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13938716#comment-13938716 ] Jonathan Bond commented on CB-6140: --- Need to get dependency tree in cli before we start looping & removing plugins. Need to always keep dependency tree on not use plugin.xml for forcefully removed dependencies. > Plugman allows deletion of dependencies > --- > > Key: CB-6140 > URL: https://issues.apache.org/jira/browse/CB-6140 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Bryan Higgins >Assignee: Jonathan Bond > Fix For: 3.5.0 > > > plugman 0.20.1 / CLI 3.4.0-0.1.2 > After a dependency was automatically added for me, I am able to remove it. > "prepare" then complains about a missing plugin.xml file > I used the following plugin, but I suspect this behaviour would occur for all > with a top-level dependency: > https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies
[ https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038037#comment-14038037 ] Danyi Lin commented on CB-6140: --- [~bhigg...@blackberry.com] I am just trying to clarify this issue given a plugin defined as below: foo ... bar ... * Install plugin foo, bar will be installed as dependency implicitly Test 1 remove plugin foo expect result: bar should be remove either actual result : bar was NOT removed Test 2 remove plugin bar expect result: the removing will be rejected, because foo depends on it actual result : bar was removed. > Plugman allows deletion of dependencies > --- > > Key: CB-6140 > URL: https://issues.apache.org/jira/browse/CB-6140 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Bryan Higgins >Assignee: Jonathan Bond > Fix For: 3.6.0 > > > plugman 0.20.1 / CLI 3.4.0-0.1.2 > After a dependency was automatically added for me, I am able to remove it. > "prepare" then complains about a missing plugin.xml file > I used the following plugin, but I suspect this behaviour would occur for all > with a top-level dependency: > https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6140) Plugman allows deletion of dependencies
[ https://issues.apache.org/jira/browse/CB-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038055#comment-14038055 ] ASF GitHub Bot commented on CB-6140: GitHub user dylin opened a pull request: https://github.com/apache/cordova-lib/pull/38 Fixed issue: CB-6140 plugman dependency check will ignore platform/dependecy when removing an intalled plugin, which will result in platform level dependencies is uninstalled inproperly. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dylin/cordova-lib dylin/CB-6140 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/38.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #38 commit 3241f0776efe9f9bcb3a5d09dedb3cba21c8a5dc Author: Danyi Lin Date: 2014-06-19T22:45:19Z Fixed issue: CB-6140 plugman dependency check will ignore platform/dependecy when removing an intalled plugin, which will result in platform level dependencies is uninstalled inproperly. > Plugman allows deletion of dependencies > --- > > Key: CB-6140 > URL: https://issues.apache.org/jira/browse/CB-6140 > Project: Apache Cordova > Issue Type: Bug > Components: CLI, Plugman >Affects Versions: 3.4.0 >Reporter: Bryan Higgins >Assignee: Jonathan Bond > Fix For: 3.6.0 > > > plugman 0.20.1 / CLI 3.4.0-0.1.2 > After a dependency was automatically added for me, I am able to remove it. > "prepare" then complains about a missing plugin.xml file > I used the following plugin, but I suspect this behaviour would occur for all > with a top-level dependency: > https://github.com/blackberry/cordova-blackberry-plugins/blob/master/plugin/com.blackberry.sensors/plugin.xml -- This message was sent by Atlassian JIRA (v6.2#6252)
