[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958369#comment-13958369 ] ASF GitHub Bot commented on CB-6279: Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/2 Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13958374#comment-13958374 ] Steve Gill commented on CB-6279: Looks Great! Go ahead and resolve this one! Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954692#comment-13954692 ] Josh Bavari commented on CB-6279: - Fixed the filters, improved styling, and removed the icons. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954751#comment-13954751 ] ASF GitHub Bot commented on CB-6279: GitHub user jbavari opened a pull request: https://github.com/apache/cordova-registry-web/pull/2 Refactor Fixes for these issues: https://issues.apache.org/jira/browse/CB-6279 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jbavari/cordova-registry-web refactor Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-registry-web/pull/2.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2 commit 0b2fbdffb878380c1dd8c775cd405c7755c495fd Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T14:06:10Z Removed the $ from the cordova add plugin command. commit 100a9dfc65441911b40e09c2f2ed1d8e85ad85a6 Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T14:09:29Z Fixed the Grunt watch configuration - watching the css files to call LESS and then reload server was infinitely looping. Less would be compiled and change css, which then made reload happen. However, changing less caused a reload, so there was two reloads for each. This is now fixed commit 06efc8f0c790f06add697810a8e10949c8f66fa9 Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T14:25:04Z Removed the icons from the filters. Updated styles commit 3f4aea87135411c9a0163bb0a5a33ae63d72c35a Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T17:19:24Z More fixes for grunt file and reloading. Had double reloads again. This fixes that. Also including dropdown stylesheet for styling dropdowns commit 6cc51774fad16ba0e48a124c363a3ec08aad57b8 Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T17:19:53Z Taking out the old dropdown styling. commit 3736ad6fe26de09d5d760e7477a7abd197efd1b9 Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T17:20:16Z Fixes for search page filter - added more padding to make it stand out more commit ced602083b8840c6f3228901a23c3c7147a099f1 Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T17:20:40Z Including the correct filters this time commit 346cd100d74b7512b9c234856b361821fc455f48 Author: Josh Bavari j...@raisemore.com Date: 2014-03-30T17:21:38Z Fixes for platform details page and style.css included Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951196#comment-13951196 ] Steve Gill commented on CB-6279: Talked to Joni. We aren't allowed to use the icons for the filters. They are copyrighted or something. Just checkboxes for now. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951352#comment-13951352 ] Josh Bavari commented on CB-6279: - Cancel that last comment - ill get them since im on the task. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13951350#comment-13951350 ] Josh Bavari commented on CB-6279: - I hear and comply. You removing or me? Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948405#comment-13948405 ] Steve Gill commented on CB-6279: Windows phone 8, phone 7 aren't filtering properly Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946958#comment-13946958 ] Steve Gill commented on CB-6279: That sounds good to me! Do you have a pull request I could take a look at for this and merge it in? Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946975#comment-13946975 ] Josh Bavari commented on CB-6279: - Yea, I'll push it up to my repo and send a PR. Yep. I'm using an angular filter for it. One caveat to it - if the user who submitted the plugin didnt specify platform, then it wont be able to be filtered. I put a message up when you click filters that states this so the user is not left wondering. Not much we can do about that. Ive noticed though that going forward there are more platforms specified. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946992#comment-13946992 ] Josh Bavari commented on CB-6279: - Steve, I sent the PR to Github. I'm sorry its huge! A lot has changed since you were gone. Let me know if you need anything. Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6279) Add filter by platform
[ https://issues.apache.org/jira/browse/CB-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944188#comment-13944188 ] Josh Bavari commented on CB-6279: - I have added filters on the search page. The filters added were ios, android, windows phone 7, windows phone 8, windows 8, ubuntu, and firefox os. I have added custom icons for these as well. I was going to add in those same icons in the grid so users can see at a distance what plugin is available for what platform without filtering. Is that ok [~stevegill]? Add filter by platform -- Key: CB-6279 URL: https://issues.apache.org/jira/browse/CB-6279 Project: Apache Cordova Issue Type: Sub-task Components: Registry, Registry Web Reporter: Steve Gill Assignee: Josh Bavari -- This message was sent by Atlassian JIRA (v6.2#6252)
