[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949726#comment-13949726 ] ASF GitHub Bot commented on CB-6337: Github user stevengill commented on the pull request: https://github.com/apache/cordova-cli/pull/150#issuecomment-38840114 Hey Josh, I will merge this in Print nice error when cordova-cli hits various expected things -- Key: CB-6337 URL: https://issues.apache.org/jira/browse/CB-6337 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Josh Soref Assignee: Josh Soref CB-5782 introduced a way to silence stack traces for expected failures, but it missed some spots. This is a first pass against things in CLI itself -- it doesn't cover errors coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949985#comment-13949985 ] ASF subversion and git services commented on CB-6337: - Commit 4f4dc29af98d8080507c0d6fe0015cec780fd701 in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=4f4dc29 ] CB-6337 Print nice error when cordova-cli hits various expected things Add missing CordovaError requires Reduce specificity of jasmine toThrow() expectations Print nice error when cordova-cli hits various expected things -- Key: CB-6337 URL: https://issues.apache.org/jira/browse/CB-6337 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Josh Soref Assignee: Josh Soref CB-5782 introduced a way to silence stack traces for expected failures, but it missed some spots. This is a first pass against things in CLI itself -- it doesn't cover errors coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1395#comment-1395 ] ASF GitHub Bot commented on CB-6337: Github user stevengill commented on the pull request: https://github.com/apache/cordova-cli/pull/150#issuecomment-38865992 Merged in. I believe this will automatically get closed soon Print nice error when cordova-cli hits various expected things -- Key: CB-6337 URL: https://issues.apache.org/jira/browse/CB-6337 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Josh Soref Assignee: Josh Soref CB-5782 introduced a way to silence stack traces for expected failures, but it missed some spots. This is a first pass against things in CLI itself -- it doesn't cover errors coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950009#comment-13950009 ] ASF GitHub Bot commented on CB-6337: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/150 Print nice error when cordova-cli hits various expected things -- Key: CB-6337 URL: https://issues.apache.org/jira/browse/CB-6337 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Josh Soref Assignee: Josh Soref CB-5782 introduced a way to silence stack traces for expected failures, but it missed some spots. This is a first pass against things in CLI itself -- it doesn't cover errors coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[
https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948045#comment-13948045
]
ASF GitHub Bot commented on CB-6337:
Github user jsoref commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/125#discussion_r10983854
--- Diff: src/metadata/tizen_parser.js ---
@@ -0,0 +1,131 @@
+var Q = require( q ),
+ shelljs = require( shelljs ),
+ util = require( ../util ),
+ elementTree = require( elementtree ),
+ exec = require( child_process ).exec,
+ path = require( path );
+
+function genPackageId() {
+ var idx,
+ returnValue = ;
+ characters = [
+ 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
+ a, b, c, d, e, f, g, h, i, j,
+ k, l, m, n, o, p, q, r, s, t,
+ u, v, w, x, y, z ];
+
+ for ( idx = 0 ; idx 10 ; idx++ ) {
+ returnValue += ( characters[ Math.round( Math.random() * 35 ) ]
);
+ }
+
+ return returnValue;
+}
+
+module.exports = function tizen_parser( project ) {
+ this.path = project;
+}
+
+// Returns a promise
+module.exports.check_requirements = function( project_root ) {
+ var deferred = Q.defer();
+
+ exec( web-build, {}, function( error, stdout, stderr ) {
+ if ( error ) {
+ deferred.reject( new Error( Requirements check failed.
Command 'web-build' not found. ) );
--- End diff --
Please see CB-6337 and use CordovaError instead of Error (don't forget to
add the require for it)
Print nice error when cordova-cli hits various expected things
--
Key: CB-6337
URL: https://issues.apache.org/jira/browse/CB-6337
Project: Apache Cordova
Issue Type: Bug
Components: CLI
Affects Versions: 3.4.0
Reporter: Josh Soref
Assignee: Josh Soref
CB-5782 introduced a way to silence stack traces for expected failures, but
it missed some spots.
This is a first pass against things in CLI itself -- it doesn't cover errors
coming from plugman.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948857#comment-13948857 ] ASF GitHub Bot commented on CB-6337: Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/150#issuecomment-38767219 `npm test` is happy, would someone please merge this? Print nice error when cordova-cli hits various expected things -- Key: CB-6337 URL: https://issues.apache.org/jira/browse/CB-6337 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Josh Soref Assignee: Josh Soref CB-5782 introduced a way to silence stack traces for expected failures, but it missed some spots. This is a first pass against things in CLI itself -- it doesn't cover errors coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945564#comment-13945564 ] ASF subversion and git services commented on CB-6337: - Commit 07181e4ee3e358b7af7674a4ae68fe06552b2655 in cordova-cli's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-cli.git;h=07181e4 ] CB-6337 Print nice error when cordova-cli hits various expected things Print nice error when cordova-cli hits various expected things -- Key: CB-6337 URL: https://issues.apache.org/jira/browse/CB-6337 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Josh Soref Assignee: Josh Soref CB-5782 introduced a way to silence stack traces for expected failures, but it missed some spots. This is a first pass against things in CLI itself -- it doesn't cover errors coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6337) Print nice error when cordova-cli hits various expected things
[ https://issues.apache.org/jira/browse/CB-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945625#comment-13945625 ] ASF GitHub Bot commented on CB-6337: Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/148 Print nice error when cordova-cli hits various expected things -- Key: CB-6337 URL: https://issues.apache.org/jira/browse/CB-6337 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.4.0 Reporter: Josh Soref Assignee: Josh Soref CB-5782 introduced a way to silence stack traces for expected failures, but it missed some spots. This is a first pass against things in CLI itself -- it doesn't cover errors coming from plugman. -- This message was sent by Atlassian JIRA (v6.2#6252)
