[jira] [Commented] (CB-6351) setMetadata fails silently

2014-03-27 Thread Robin Zeggelaar (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949024#comment-13949024
 ] 

Robin Zeggelaar commented on CB-6351:
-

Dear Ian,

The project was created after upgrading Cordova and Phonegap via NPM. The 
plugins were added using Cordova plugin add org.apache.cordova.x. Am i right 
to assume this is the correct way to handle things?

I will look into updating/re-installing and get back to you with the results.

 setMetadata fails silently
 --

 Key: CB-6351
 URL: https://issues.apache.org/jira/browse/CB-6351
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File
Affects Versions: 3.4.0
Reporter: Robin Zeggelaar
Assignee: Ian Clelland
  Labels: setMetadata

 In Cordova 3.0.4 the setMetadata call on iOS fails silently. Android does not 
 seem to have this issue.
 On the javascript side the following call is made (Entry.js): 
 exec(successCallback, errorCallback, File, setMetadata, [this.fullPath, 
 metadataObject]);
 This fails silently on the native end. My callbacks are not invoked. I fixed 
 this by changing this.fullPath to this.toURL(), conform the changes to the 
 File plugin. After this change the callbacks did get invoked properly.
 Could you take a look at this and fix it in a future release?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6351) setMetadata fails silently

2014-03-27 Thread Ian Clelland (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949227#comment-13949227
 ] 

Ian Clelland commented on CB-6351:
--

Thanks for checking that, [~RobinZeggelaar] -- I ran the file through {{git 
blame}}, and saw that it is only fixed in the dev branch. I merged in the pull 
request https://github.com/apache/cordova-plugin-file/pull/33 about three weeks 
ago, and promptly forgot about it.

You can see it fixed on the dev branch here: 
https://github.com/apache/cordova-plugin-file/blob/dev/www/Entry.js#L89

I'll see if I can get a 1.0.2 release put together next week that will address 
this.

Thanks,
Ian

 setMetadata fails silently
 --

 Key: CB-6351
 URL: https://issues.apache.org/jira/browse/CB-6351
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File
Affects Versions: 3.4.0
Reporter: Robin Zeggelaar
Assignee: Ian Clelland
  Labels: setMetadata

 In Cordova 3.0.4 the setMetadata call on iOS fails silently. Android does not 
 seem to have this issue.
 On the javascript side the following call is made (Entry.js): 
 exec(successCallback, errorCallback, File, setMetadata, [this.fullPath, 
 metadataObject]);
 This fails silently on the native end. My callbacks are not invoked. I fixed 
 this by changing this.fullPath to this.toURL(), conform the changes to the 
 File plugin. After this change the callbacks did get invoked properly.
 Could you take a look at this and fix it in a future release?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6351) setMetadata fails silently

2014-03-27 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13949231#comment-13949231
 ] 

ASF GitHub Bot commented on CB-6351:


Github user clelland commented on the pull request:

https://github.com/apache/cordova-plugin-file/pull/33#issuecomment-38797238
  
See [CB-6351](https://issues.apache.org/jira/browse/CB-6351) as well -- 
this was also reported on JIRA while still on the dev branch.


 setMetadata fails silently
 --

 Key: CB-6351
 URL: https://issues.apache.org/jira/browse/CB-6351
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File
Affects Versions: 3.4.0
Reporter: Robin Zeggelaar
Assignee: Ian Clelland
  Labels: setMetadata

 In Cordova 3.0.4 the setMetadata call on iOS fails silently. Android does not 
 seem to have this issue.
 On the javascript side the following call is made (Entry.js): 
 exec(successCallback, errorCallback, File, setMetadata, [this.fullPath, 
 metadataObject]);
 This fails silently on the native end. My callbacks are not invoked. I fixed 
 this by changing this.fullPath to this.toURL(), conform the changes to the 
 File plugin. After this change the callbacks did get invoked properly.
 Could you take a look at this and fix it in a future release?



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6351) setMetadata fails silently

2014-03-26 Thread Ian Clelland (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948163#comment-13948163
 ] 

Ian Clelland commented on CB-6351:
--

Have you recently updated your Cordova project?

The current version of Entry.js in the File plugin uses this line:

{code}
exec(successCallback, errorCallback, File, setMetadata, 
[this.filesystem.__format__(this.fullPath), metadataObject]);
{code}

which is functionally equivalent to using {{.toURL()}}.

It seems like you might be using new native code with old JavaScript. This has 
come up a couple of times with people upgrading their projects / plugins. I 
suspect it is a plugin upgrade bug.

 setMetadata fails silently
 --

 Key: CB-6351
 URL: https://issues.apache.org/jira/browse/CB-6351
 Project: Apache Cordova
  Issue Type: Bug
  Components: Plugin File
Affects Versions: 3.4.0
Reporter: Robin Zeggelaar
Assignee: Ian Clelland
  Labels: setMetadata

 In Cordova 3.0.4 the setMetadata call on iOS fails silently. Android does not 
 seem to have this issue.
 On the javascript side the following call is made (Entry.js): 
 exec(successCallback, errorCallback, File, setMetadata, [this.fullPath, 
 metadataObject]);
 This fails silently on the native end. My callbacks are not invoked. I fixed 
 this by changing this.fullPath to this.toURL(), conform the changes to the 
 File plugin. After this change the callbacks did get invoked properly.
 Could you take a look at this and fix it in a future release?



--
This message was sent by Atlassian JIRA
(v6.2#6252)