[jira] [Commented] (CB-6482) InAppBrowser calls incorrect callback on WP8
[
https://issues.apache.org/jira/browse/CB-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981370#comment-13981370
]
ASF subversion and git services commented on CB-6482:
-
Commit ab7494faa059a8e90fb8f88c5c5ef40e8a154478 in
cordova-plugin-inappbrowser's branch refs/heads/master from sgrebnov
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=ab7494f
]
CB-6482 InAppBrowser calls incorrect callback on WP8
> InAppBrowser calls incorrect callback on WP8
>
>
> Key: CB-6482
> URL: https://issues.apache.org/jira/browse/CB-6482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser, WP8
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
>
> Due to current implementation InAppBrowser does not save initial callback id
> when you performed 'open' operation, but uses the latest command callback
> instead. So if you invoke any other command like executeScript after,
> location chanegs events will be broken. It will start using executeScript
> callback is instead of original one.
> For example,
> var loginWindow = window.open(someUrl, "_blank", "location=no");
> loginWindow.addEventListener('loadstart', loadEventHandler);
> loginWindow.addEventListener('loadstop', loadEventHandler);
> loginWindow.executeScript(..);
> The last call will break location change notifications.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6482) InAppBrowser calls incorrect callback on WP8
[
https://issues.apache.org/jira/browse/CB-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981383#comment-13981383
]
ASF GitHub Bot commented on CB-6482:
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/41
> InAppBrowser calls incorrect callback on WP8
>
>
> Key: CB-6482
> URL: https://issues.apache.org/jira/browse/CB-6482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser, WP8
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
>
> Due to current implementation InAppBrowser does not save initial callback id
> when you performed 'open' operation, but uses the latest command callback
> instead. So if you invoke any other command like executeScript after,
> location chanegs events will be broken. It will start using executeScript
> callback is instead of original one.
> For example,
> var loginWindow = window.open(someUrl, "_blank", "location=no");
> loginWindow.addEventListener('loadstart', loadEventHandler);
> loginWindow.addEventListener('loadstop', loadEventHandler);
> loginWindow.executeScript(..);
> The last call will break location change notifications.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6482) InAppBrowser calls incorrect callback on WP8
[
https://issues.apache.org/jira/browse/CB-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981371#comment-13981371
]
ASF subversion and git services commented on CB-6482:
-
Commit 907bba6cf68693658fac90b00f8df635ddb8a11b in
cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=907bba6
]
Merge branch 'CB-6482' of
https://github.com/sgrebnov/cordova-plugin-inappbrowser into dev
> InAppBrowser calls incorrect callback on WP8
>
>
> Key: CB-6482
> URL: https://issues.apache.org/jira/browse/CB-6482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser, WP8
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
>
> Due to current implementation InAppBrowser does not save initial callback id
> when you performed 'open' operation, but uses the latest command callback
> instead. So if you invoke any other command like executeScript after,
> location chanegs events will be broken. It will start using executeScript
> callback is instead of original one.
> For example,
> var loginWindow = window.open(someUrl, "_blank", "location=no");
> loginWindow.addEventListener('loadstart', loadEventHandler);
> loginWindow.addEventListener('loadstop', loadEventHandler);
> loginWindow.executeScript(..);
> The last call will break location change notifications.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6482) InAppBrowser calls incorrect callback on WP8
[
https://issues.apache.org/jira/browse/CB-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976248#comment-13976248
]
ASF subversion and git services commented on CB-6482:
-
Commit ab7494faa059a8e90fb8f88c5c5ef40e8a154478 in
cordova-plugin-inappbrowser's branch refs/heads/dev from sgrebnov
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=ab7494f
]
CB-6482 InAppBrowser calls incorrect callback on WP8
> InAppBrowser calls incorrect callback on WP8
>
>
> Key: CB-6482
> URL: https://issues.apache.org/jira/browse/CB-6482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser, WP8
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
>
> Due to current implementation InAppBrowser does not save initial callback id
> when you performed 'open' operation, but uses the latest command callback
> instead. So if you invoke any other command like executeScript after,
> location chanegs events will be broken. It will start using executeScript
> callback is instead of original one.
> For example,
> var loginWindow = window.open(someUrl, "_blank", "location=no");
> loginWindow.addEventListener('loadstart', loadEventHandler);
> loginWindow.addEventListener('loadstop', loadEventHandler);
> loginWindow.executeScript(..);
> The last call will break location change notifications.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6482) InAppBrowser calls incorrect callback on WP8
[
https://issues.apache.org/jira/browse/CB-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976249#comment-13976249
]
ASF subversion and git services commented on CB-6482:
-
Commit 907bba6cf68693658fac90b00f8df635ddb8a11b in
cordova-plugin-inappbrowser's branch refs/heads/dev from [~purplecabbage]
[
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=907bba6
]
Merge branch 'CB-6482' of
https://github.com/sgrebnov/cordova-plugin-inappbrowser into dev
> InAppBrowser calls incorrect callback on WP8
>
>
> Key: CB-6482
> URL: https://issues.apache.org/jira/browse/CB-6482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser, WP8
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
>
> Due to current implementation InAppBrowser does not save initial callback id
> when you performed 'open' operation, but uses the latest command callback
> instead. So if you invoke any other command like executeScript after,
> location chanegs events will be broken. It will start using executeScript
> callback is instead of original one.
> For example,
> var loginWindow = window.open(someUrl, "_blank", "location=no");
> loginWindow.addEventListener('loadstart', loadEventHandler);
> loginWindow.addEventListener('loadstop', loadEventHandler);
> loginWindow.executeScript(..);
> The last call will break location change notifications.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6482) InAppBrowser calls incorrect callback on WP8
[
https://issues.apache.org/jira/browse/CB-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976124#comment-13976124
]
ASF GitHub Bot commented on CB-6482:
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/41
CB-6482 InAppBrowser calls incorrect callback on WP8
https://issues.apache.org/jira/browse/CB-6482
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sgrebnov/cordova-plugin-inappbrowser CB-6482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-inappbrowser/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
commit ab7494faa059a8e90fb8f88c5c5ef40e8a154478
Author: sgrebnov
Date: 2014-04-21T22:28:03Z
CB-6482 InAppBrowser calls incorrect callback on WP8
> InAppBrowser calls incorrect callback on WP8
>
>
> Key: CB-6482
> URL: https://issues.apache.org/jira/browse/CB-6482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin InAppBrowser, WP8
>Reporter: Sergey Grebnov
>Assignee: Sergey Grebnov
>
> Due to current implementation InAppBrowser does not save initial callback id
> when you performed 'open' operation, but uses the latest command callback
> instead. So if you invoke any other command like executeScript after,
> location chanegs events will be broken. It will start using executeScript
> callback is instead of original one.
> For example,
> var loginWindow = window.open(someUrl, "_blank", "location=no");
> loginWindow.addEventListener('loadstart', loadEventHandler);
> loginWindow.addEventListener('loadstop', loadEventHandler);
> loginWindow.executeScript(..);
> The last call will break location change notifications.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
