[jira] [Commented] (CB-6549) Use relative path to link cordova-mobile-spec repository

2014-04-29 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984592#comment-13984592
 ] 

ASF GitHub Bot commented on CB-6549:


GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/59

CB-6549 use relative path to link assets

Changed: Use relative path instead of absolute path, to link the
cordova-mobile-spec repository with the mobilespec project.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-6549

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/59.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #59


commit 515756097640b01013de43a00bf34f3642844990
Author: Martin Gonzalez 
Date:   2014-04-29T17:58:06Z

CB-6549 use relative path to link assets

Changed: Use relative path instead of absolute path, to link the
cordova-mobile-spec repository with the mobilespec project.




> Use relative path to link cordova-mobile-spec repository
> 
>
> Key: CB-6549
> URL: https://issues.apache.org/jira/browse/CB-6549
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: mobile-spec
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: mobilespec,
> Fix For: 3.5.0
>
>
> Under the Windows environment, when project creation, the usage of an 
> absolute path as argument for --link-to, it rejects the project creation.
> Error that throws:
> 'Only local paths for custom www assets are supported.'
> Using a relative path it solves the problem, and works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6549) Use relative path to link cordova-mobile-spec repository

2014-04-29 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984614#comment-13984614
 ] 

ASF subversion and git services commented on CB-6549:
-

Commit a9a0e7e8bd233fae4f034aae8e322446facca33e in cordova-mobile-spec's branch 
refs/heads/master from [~martin.c.glez.glez]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=a9a0e7e ]

CB-6549 use relative path to link assets

Changed: Use relative path instead of absolute path, to link the
cordova-mobile-spec repository with the mobilespec project. This is needed
for Windows-based dev workstations.

github: close #59


> Use relative path to link cordova-mobile-spec repository
> 
>
> Key: CB-6549
> URL: https://issues.apache.org/jira/browse/CB-6549
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: mobile-spec
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: mobilespec,
> Fix For: 3.5.0
>
>
> Under the Windows environment, when project creation, the usage of an 
> absolute path as argument for --link-to, it rejects the project creation.
> Error that throws:
> 'Only local paths for custom www assets are supported.'
> Using a relative path it solves the problem, and works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6549) Use relative path to link cordova-mobile-spec repository

2014-04-29 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984616#comment-13984616
 ] 

ASF GitHub Bot commented on CB-6549:


Github user cmarcelk commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/59#issuecomment-41712597
  
Merged.


> Use relative path to link cordova-mobile-spec repository
> 
>
> Key: CB-6549
> URL: https://issues.apache.org/jira/browse/CB-6549
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: mobile-spec
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: mobilespec,
> Fix For: 3.5.0
>
>
> Under the Windows environment, when project creation, the usage of an 
> absolute path as argument for --link-to, it rejects the project creation.
> Error that throws:
> 'Only local paths for custom www assets are supported.'
> Using a relative path it solves the problem, and works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6549) Use relative path to link cordova-mobile-spec repository

2014-04-29 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984617#comment-13984617
 ] 

ASF GitHub Bot commented on CB-6549:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/59


> Use relative path to link cordova-mobile-spec repository
> 
>
> Key: CB-6549
> URL: https://issues.apache.org/jira/browse/CB-6549
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: mobile-spec
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: mobilespec,
> Fix For: 3.5.0
>
>
> Under the Windows environment, when project creation, the usage of an 
> absolute path as argument for --link-to, it rejects the project creation.
> Error that throws:
> 'Only local paths for custom www assets are supported.'
> Using a relative path it solves the problem, and works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6549) Use relative path to link cordova-mobile-spec repository

2014-06-13 Thread Jesse MacFadyen (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031094#comment-14031094
 ] 

Jesse MacFadyen commented on CB-6549:
-

Doesn't this also occur with a file: url?
The test that triggers the output "'Only local paths for custom www assets are 
supported.'" 
is only testing for the presence of a ':' in the provided path ... Shouldn't it 
test for "http:" ?

> Use relative path to link cordova-mobile-spec repository
> 
>
> Key: CB-6549
> URL: https://issues.apache.org/jira/browse/CB-6549
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: mobile-spec
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: mobilespec,
> Fix For: 3.5.0
>
>
> Under the Windows environment, when project creation, the usage of an 
> absolute path as argument for --link-to, it rejects the project creation.
> Error that throws:
> 'Only local paths for custom www assets are supported.'
> Using a relative path it solves the problem, and works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6549) Use relative path to link cordova-mobile-spec repository

2014-06-13 Thread Martin Gonzalez (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031101#comment-14031101
 ] 

Martin Gonzalez commented on CB-6549:
-

I'm not entirely sure about what it looks for. If it's a ':' in the path or 
URL, or if it's trying to determine that the directory to link is a child from 
the project creation occurs. 
current dir:
cordova-mobiles-spec
dir 1 
dir 2

when (global or local cli)
cordova create project name --link-to [folder resource to link]

the folder to link it has to be relative. If you provide the same resource with 
the absolute path at least under windows it throws a error.


> Use relative path to link cordova-mobile-spec repository
> 
>
> Key: CB-6549
> URL: https://issues.apache.org/jira/browse/CB-6549
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: mobile-spec
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: mobilespec,
> Fix For: 3.5.0
>
>
> Under the Windows environment, when project creation, the usage of an 
> absolute path as argument for --link-to, it rejects the project creation.
> Error that throws:
> 'Only local paths for custom www assets are supported.'
> Using a relative path it solves the problem, and works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-6549) Use relative path to link cordova-mobile-spec repository

2014-06-13 Thread Jesse MacFadyen (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-6549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031112#comment-14031112
 ] 

Jesse MacFadyen commented on CB-6549:
-

Yeah, I added CB-6943 to track the other error. I am adding tests now.

> Use relative path to link cordova-mobile-spec repository
> 
>
> Key: CB-6549
> URL: https://issues.apache.org/jira/browse/CB-6549
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: mobile-spec
>Affects Versions: 3.4.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>  Labels: mobilespec,
> Fix For: 3.5.0
>
>
> Under the Windows environment, when project creation, the usage of an 
> absolute path as argument for --link-to, it rejects the project creation.
> Error that throws:
> 'Only local paths for custom www assets are supported.'
> Using a relative path it solves the problem, and works as expected.



--
This message was sent by Atlassian JIRA
(v6.2#6252)