[jira] [Commented] (CB-6922) File Entry.getMetadata returns invalid dates on Android
[
https://issues.apache.org/jira/browse/CB-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028090#comment-14028090
]
ASF GitHub Bot commented on CB-6922:
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/39#issuecomment-45775108
I've created [CB-6922](https://issues.apache.org/jira/browse/CB-6922) for
this -- it was certainly a problem in Android.
The trouble, as Shaz identified, is that *both* the File API and the
FileEntry API have a method to get metadata for a file, and they use
inconsistent names for the timestamp.
I've committed a different fix, which just makes use of getFileMetadata for
both functions (on all platforms) and changes the key names in JavaScript
before instantiating the Metadata object. This should ensure consistent
behaviour across all platforms.
> File Entry.getMetadata returns invalid dates on Android
> ---
>
> Key: CB-6922
> URL: https://issues.apache.org/jira/browse/CB-6922
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Ian Clelland
>Assignee: Ian Clelland
>
> See https://github.com/apache/cordova-plugin-file/pull/39
> {{Entry.getMetadata}} expects the JSON in the callback from native to include
> a {{modificationTime}} key, but on Android, it contains a
> {{lastModifiedDate}} key instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6922) File Entry.getMetadata returns invalid dates on Android
[
https://issues.apache.org/jira/browse/CB-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028081#comment-14028081
]
ASF subversion and git services commented on CB-6922:
-
Commit 71ff2e47aa8999c74ba45140bfada8d520246b1e in cordova-plugin-file's branch
refs/heads/master from [~iclelland]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=71ff2e4 ]
CB-6922: Use getFileMetadata consistently to get metadata
> File Entry.getMetadata returns invalid dates on Android
> ---
>
> Key: CB-6922
> URL: https://issues.apache.org/jira/browse/CB-6922
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Ian Clelland
>Assignee: Ian Clelland
>
> See https://github.com/apache/cordova-plugin-file/pull/39
> {{Entry.getMetadata}} expects the JSON in the callback from native to include
> a {{modificationTime}} key, but on Android, it contains a
> {{lastModifiedDate}} key instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6922) File Entry.getMetadata returns invalid dates on Android
[
https://issues.apache.org/jira/browse/CB-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028082#comment-14028082
]
ASF subversion and git services commented on CB-6922:
-
Commit 090979e9d4dfcd2d696489033f28f31003f2b918 in cordova-plugin-file's branch
refs/heads/master from [~iclelland]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=090979e ]
CB-6922: Remove unused getMetadata native code
> File Entry.getMetadata returns invalid dates on Android
> ---
>
> Key: CB-6922
> URL: https://issues.apache.org/jira/browse/CB-6922
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Ian Clelland
>Assignee: Ian Clelland
>
> See https://github.com/apache/cordova-plugin-file/pull/39
> {{Entry.getMetadata}} expects the JSON in the callback from native to include
> a {{modificationTime}} key, but on Android, it contains a
> {{lastModifiedDate}} key instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-6922) File Entry.getMetadata returns invalid dates on Android
[
https://issues.apache.org/jira/browse/CB-6922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028065#comment-14028065
]
ASF subversion and git services commented on CB-6922:
-
Commit 9037e9c0bdb72b96afeac5446adb8625d4da2009 in cordova-mobile-spec's branch
refs/heads/master from [~iclelland]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;h=9037e9c ]
CB-6922: Test that metadata.modificationTime is a valid date
> File Entry.getMetadata returns invalid dates on Android
> ---
>
> Key: CB-6922
> URL: https://issues.apache.org/jira/browse/CB-6922
> Project: Apache Cordova
> Issue Type: Bug
>Reporter: Ian Clelland
>Assignee: Ian Clelland
>
> See https://github.com/apache/cordova-plugin-file/pull/39
> {{Entry.getMetadata}} expects the JSON in the callback from native to include
> a {{modificationTime}} key, but on Android, it contains a
> {{lastModifiedDate}} key instead.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
