[jira] [Commented] (CB-6979) CDVContact : ExtractPhotos creating replica photos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033770#comment-15033770
 ] 

ASF GitHub Bot commented on CB-6979:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-contacts/pull/89


> CDVContact : ExtractPhotos creating replica photos 
> ---
>
> Key: CB-6979
> URL: https://issues.apache.org/jira/browse/CB-6979
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Geetha
>Assignee: Vladimir Kotikov
>Priority: Minor
>  Labels: iOS, triaged
>
> When we try to get the contacts from the Addressbook , in CDVContact in the 
> extractPhotos method , the photos are extracted and stroed in the tmp folder. 
> But duplicates of photos have created in tm because everytime the photo URL 
> is been a new one thus creating a photo and increasing the memory consumption 
> of the app. We ve found that app memory usage piles up when we try to load 
> the more no of  contacts which leads to low memory warning to the app and 
> thus killed by the OS. 
> This is the observation we found , Please let us know if we can do some 
> alternative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6979) CDVContact : ExtractPhotos creating replica photos

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033769#comment-15033769
 ] 

ASF subversion and git services commented on CB-6979:
-

Commit ecf040a7406e4b52b3c56fb174b2e83a5a9da496 in cordova-plugin-contacts's 
branch refs/heads/master from [~vladimir.kotikov]
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-contacts.git;h=ecf040a 
]

CB-6979 Don't create duplicates for extracted contacts photos

This closes #89


> CDVContact : ExtractPhotos creating replica photos 
> ---
>
> Key: CB-6979
> URL: https://issues.apache.org/jira/browse/CB-6979
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Geetha
>Assignee: Vladimir Kotikov
>Priority: Minor
>  Labels: iOS, triaged
>
> When we try to get the contacts from the Addressbook , in CDVContact in the 
> extractPhotos method , the photos are extracted and stroed in the tmp folder. 
> But duplicates of photos have created in tm because everytime the photo URL 
> is been a new one thus creating a photo and increasing the memory consumption 
> of the app. We ve found that app memory usage piles up when we try to load 
> the more no of  contacts which leads to low memory warning to the app and 
> thus killed by the OS. 
> This is the observation we found , Please let us know if we can do some 
> alternative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6979) CDVContact : ExtractPhotos creating replica photos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15029717#comment-15029717
 ] 

ASF GitHub Bot commented on CB-6979:


Github user vladimir-kotikov commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/89#discussion_r46032879
  
--- Diff: src/ios/CDVContact.m ---
@@ -1324,6 +1324,7 @@ - (NSObject*)extractPhotos
 NSMutableArray* photos = nil;
 
 if (ABPersonHasImageData(self.record)) {
+CFIndex photoId = ABRecordGetRecordID(self.record);
--- End diff --

Yes. It can also return `-1` when pemission to address book is denied, but 
this is hardly ever possible in our case, since we now asking for permissions 
always (since 
https://github.com/apache/cordova-plugin-contacts/commit/617fb764bf1c7047cfe02cf346771dd7fa38ed40)


> CDVContact : ExtractPhotos creating replica photos 
> ---
>
> Key: CB-6979
> URL: https://issues.apache.org/jira/browse/CB-6979
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Geetha
>Assignee: Vladimir Kotikov
>Priority: Minor
>  Labels: iOS, triaged
>
> When we try to get the contacts from the Addressbook , in CDVContact in the 
> extractPhotos method , the photos are extracted and stroed in the tmp folder. 
> But duplicates of photos have created in tm because everytime the photo URL 
> is been a new one thus creating a photo and increasing the memory consumption 
> of the app. We ve found that app memory usage piles up when we try to load 
> the more no of  contacts which leads to low memory warning to the app and 
> thus killed by the OS. 
> This is the observation we found , Please let us know if we can do some 
> alternative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6979) CDVContact : ExtractPhotos creating replica photos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028669#comment-15028669
 ] 

ASF GitHub Bot commented on CB-6979:


GitHub user vladimir-kotikov opened a pull request:

https://github.com/apache/cordova-plugin-contacts/pull/89

CB-6979 Don't create duplicates for extracted contacts photos

Fix for [CB-6979](https://issues.apache.org/jira/browse/CB-6979)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-contacts CB-6979

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-contacts/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #89


commit 9df4809abe1b2d1ad04031e5a02a046757b20947
Author: Vladimir Kotikov 
Date:   2015-11-26T12:21:57Z

CB-6979 Don't create duplicates for extracted contacts photos




> CDVContact : ExtractPhotos creating replica photos 
> ---
>
> Key: CB-6979
> URL: https://issues.apache.org/jira/browse/CB-6979
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Geetha
>Assignee: Vladimir Kotikov
>Priority: Minor
>  Labels: iOS, triaged
>
> When we try to get the contacts from the Addressbook , in CDVContact in the 
> extractPhotos method , the photos are extracted and stroed in the tmp folder. 
> But duplicates of photos have created in tm because everytime the photo URL 
> is been a new one thus creating a photo and increasing the memory consumption 
> of the app. We ve found that app memory usage piles up when we try to load 
> the more no of  contacts which leads to low memory warning to the app and 
> thus killed by the OS. 
> This is the observation we found , Please let us know if we can do some 
> alternative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6979) CDVContact : ExtractPhotos creating replica photos

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028990#comment-15028990
 ] 

ASF GitHub Bot commented on CB-6979:


Github user daserge commented on a diff in the pull request:


https://github.com/apache/cordova-plugin-contacts/pull/89#discussion_r45988996
  
--- Diff: src/ios/CDVContact.m ---
@@ -1324,6 +1324,7 @@ - (NSObject*)extractPhotos
 NSMutableArray* photos = nil;
 
 if (ABPersonHasImageData(self.record)) {
+CFIndex photoId = ABRecordGetRecordID(self.record);
--- End diff --

Will this always return a valid value?


> CDVContact : ExtractPhotos creating replica photos 
> ---
>
> Key: CB-6979
> URL: https://issues.apache.org/jira/browse/CB-6979
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin Contacts
> Environment: iOS
>Reporter: Geetha
>Assignee: Vladimir Kotikov
>Priority: Minor
>  Labels: iOS, triaged
>
> When we try to get the contacts from the Addressbook , in CDVContact in the 
> extractPhotos method , the photos are extracted and stroed in the tmp folder. 
> But duplicates of photos have created in tm because everytime the photo URL 
> is been a new one thus creating a photo and increasing the memory consumption 
> of the app. We ve found that app memory usage piles up when we try to load 
> the more no of  contacts which leads to low memory warning to the app and 
> thus killed by the OS. 
> This is the observation we found , Please let us know if we can do some 
> alternative.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org