[jira] [Commented] (CB-6986) pin jshint
[ https://issues.apache.org/jira/browse/CB-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037825#comment-14037825 ] ASF GitHub Bot commented on CB-6986: GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/37 CB-6986 make npm run jshint work without a global jshint You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_6986 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 commit a64032cc5a35a8a59cb97bd13f11013b742ed1fb Author: Josh Soref jso...@blackberry.com Date: 2014-06-19T20:00:04Z CB-6986 make npm run jshint work without a global jshint pin jshint -- Key: CB-6986 URL: https://issues.apache.org/jira/browse/CB-6986 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently npm test and npm run jshint fail if jshint isn't installed globally. Apparently jshint has changed significantly between 2.4 and 2.5, so if we're expecting people to have consistent output, we should select a specific version of jshint and depend on it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6986) pin jshint
[ https://issues.apache.org/jira/browse/CB-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038103#comment-14038103 ] ASF subversion and git services commented on CB-6986: - Commit d23aee39bf92e70eca8cb5defb6c0066a071c210 in cordova-lib's branch refs/heads/master from [~jsoref] [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=d23aee3 ] CB-6986 make npm run jshint work without a global jshint Add jshint to dev-deps in package.json and use it instead of relying on a global jshint. github: close #37 pin jshint -- Key: CB-6986 URL: https://issues.apache.org/jira/browse/CB-6986 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently npm test and npm run jshint fail if jshint isn't installed globally. Apparently jshint has changed significantly between 2.4 and 2.5, so if we're expecting people to have consistent output, we should select a specific version of jshint and depend on it. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6986) pin jshint
[ https://issues.apache.org/jira/browse/CB-6986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038104#comment-14038104 ] ASF GitHub Bot commented on CB-6986: Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/37 pin jshint -- Key: CB-6986 URL: https://issues.apache.org/jira/browse/CB-6986 Project: Apache Cordova Issue Type: Bug Components: CordovaLib Affects Versions: 3.5.0 Reporter: Josh Soref Assignee: Josh Soref Currently npm test and npm run jshint fail if jshint isn't installed globally. Apparently jshint has changed significantly between 2.4 and 2.5, so if we're expecting people to have consistent output, we should select a specific version of jshint and depend on it. -- This message was sent by Atlassian JIRA (v6.2#6252)
