[jira] [Commented] (CB-7009) file.spec.11 fails on WP8

2014-08-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088613#comment-14088613
 ] 

ASF GitHub Bot commented on CB-7009:


Github user martincgg commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/75#issuecomment-51419471
  
no longer valid, closing


> file.spec.11 fails on WP8
> -
>
> Key: CB-7009
> URL: https://issues.apache.org/jira/browse/CB-7009
> Project: Apache Cordova
>  Issue Type: Test
>  Components: mobile-spec
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>Priority: Minor
>  Labels: mobilespec
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-7009) file.spec.11 fails on WP8

2014-08-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088614#comment-14088614
 ] 

ASF GitHub Bot commented on CB-7009:


Github user martincgg closed the pull request at:

https://github.com/apache/cordova-mobile-spec/pull/75


> file.spec.11 fails on WP8
> -
>
> Key: CB-7009
> URL: https://issues.apache.org/jira/browse/CB-7009
> Project: Apache Cordova
>  Issue Type: Test
>  Components: mobile-spec
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>Priority: Minor
>  Labels: mobilespec
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-7009) file.spec.11 fails on WP8

2014-08-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088566#comment-14088566
 ] 

ASF GitHub Bot commented on CB-7009:


Github user purplecabbage commented on the pull request:

https://github.com/apache/cordova-mobile-spec/pull/75#issuecomment-51418024
  
is this still valid? with everything moved to plugin tests ...
merge conflicts.


> file.spec.11 fails on WP8
> -
>
> Key: CB-7009
> URL: https://issues.apache.org/jira/browse/CB-7009
> Project: Apache Cordova
>  Issue Type: Test
>  Components: mobile-spec
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>Priority: Minor
>  Labels: mobilespec
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (CB-7009) file.spec.11 fails on WP8

2014-06-24 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-7009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14041945#comment-14041945
 ] 

ASF GitHub Bot commented on CB-7009:


GitHub user martincgg opened a pull request:

https://github.com/apache/cordova-mobile-spec/pull/75

CB-7009 (WP8) use proper path if windowsphone

Use a proper filepath to determine if the file exists or not, instead of 
just throw a ENCODING_ERR error code.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/martincgg/cordova-mobile-spec CB-7009

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-mobile-spec/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #75


commit b88d103fdc49c00b561f6cb77246be0a91de53c7
Author: Martin Gonzalez 
Date:   2014-06-24T10:00:18Z

CB-7009 (WP8) use proper path if windowsphone

Use a proper filename to determine if exists or not, instead of just
throw a ENCODING_ERR error code.




> file.spec.11 fails on WP8
> -
>
> Key: CB-7009
> URL: https://issues.apache.org/jira/browse/CB-7009
> Project: Apache Cordova
>  Issue Type: Test
>  Components: mobile-spec
>Affects Versions: 3.5.0
>Reporter: Martin Gonzalez
>Assignee: Martin Gonzalez
>Priority: Minor
>  Labels: mobilespec
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)