[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305760#comment-14305760 ] ASF GitHub Bot commented on CB-7285: Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/29 > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device, Windows, WP8 >Reporter: Ian Clelland >Assignee: Jesse MacFadyen >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305757#comment-14305757 ] ASF subversion and git services commented on CB-7285: - Commit d505dfa49c407b6fe034bc67e0587c4ed31d6c61 in cordova-plugin-device's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device.git;h=d505dfa ] [CB-7285][WP8] add manufacturer info > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device, Windows, WP8 >Reporter: Ian Clelland >Assignee: Jesse MacFadyen >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305759#comment-14305759 ] ASF subversion and git services commented on CB-7285: - Commit 734e01f5a6762b37d576d4189b0aa5ef4a5b92f1 in cordova-plugin-device's branch refs/heads/master from [~purplecabbage] [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-device.git;h=734e01f ] [CB-7285] Add test for manufacturer property > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device, Windows, WP8 >Reporter: Ian Clelland >Assignee: Jesse MacFadyen >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305753#comment-14305753 ] ASF GitHub Bot commented on CB-7285: GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-device/pull/29 CB-7285 Add manufacturer property on WP8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-device CB-7285 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-device/pull/29.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #29 commit d505dfa49c407b6fe034bc67e0587c4ed31d6c61 Author: Jesse MacFadyen Date: 2015-02-04T19:00:18Z [CB-7285][WP8] add manufacturer info commit 734e01f5a6762b37d576d4189b0aa5ef4a5b92f1 Author: Jesse MacFadyen Date: 2015-02-04T19:03:17Z [CB-7285] Add test for manufacturer property > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device, Windows, WP8 >Reporter: Ian Clelland >Assignee: Jesse MacFadyen >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304327#comment-14304327 ] ASF GitHub Bot commented on CB-7285: Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-72761694 I have decided to accept this pull request, and implement the windows/wp8 functions. The fact that the native api makes this information available implies the importance of the info. Hiding this from cordova apps simply to prevent misuse is probably not helpful. [CB-7285] > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device >Reporter: Ian Clelland >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[
https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277461#comment-14277461
]
Josh Soref commented on CB-7285:
[~OliverSalzburg]: if you can get this information from the UA already, then
you should just be logging the UA.
The problem with such a feature is that it encourages developers to write code
w/ really rough edges.
if (manufacturerA) {
doSomething();
} else if (manufacturerB) {
doSomethingElse();
}
What happens when it's manufacturerC?
Nothing.
the UX is thus awful for that case.
Or what happens when manufacturerA changes its sense of style (which happens
annually IME).
> Add Manufacturer info to device plugin
> --
>
> Key: CB-7285
> URL: https://issues.apache.org/jira/browse/CB-7285
> Project: Apache Cordova
> Issue Type: New Feature
> Components: Plugin Device
>Reporter: Ian Clelland
>Priority: Minor
>
> bq.For some platforms it makes sense to be able to list the Manufacturer for
> a device. These changes allow retrieval of manufacturer name for Android, iOS
> & Blackberry. Have not added to other platforms as I have no access to those
> or know the API's.
> See https://github.com/apache/cordova-plugin-device/pull/20
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224735#comment-14224735 ] Oliver Salzburg commented on CB-7285: - We would really appreciate this addition. We don't use the information for feature detection, but for feedback. Especially in cross-platform mobile applications, there are a ton of things to go wrong. Having as many details as possible about the device in use is very helpful when trying to troubleshoot issues with a customer. Yes, we probably already have the model of the phone in the information package, but what's the harm in extending the capabilities of the plugin? It's not like the availability of the information forces one to misuse it for feature detection. > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device >Reporter: Ian Clelland >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134188#comment-14134188 ] Shazron Abdullah commented on CB-7285: -- Yeah I'm not sure of the value of this value. "For some platforms it makes sense to be able to list the Manufacturer of the device" --> why? > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device >Reporter: Ian Clelland >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14093025#comment-14093025 ] Jesse MacFadyen commented on CB-7285: - Windows Phone and Windows 8 both support DeviceManufacturer:String, as well as DeviceFirmwareVersion:String, and DeviceHardwareVersion:String. Much of this info can be gleaned by looking at the user-agent string, however, I recommend this feature detection, over using these values. > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device >Reporter: Ian Clelland >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7285) Add Manufacturer info to device plugin
[ https://issues.apache.org/jira/browse/CB-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092787#comment-14092787 ] ASF GitHub Bot commented on CB-7285: Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-51784352 I've linked this to https://issues.apache.org/jira/browse/CB-7285 for discussion. I'd like to see WP, FireOS (all Amazon?) FFOS chime in on this as well. > Add Manufacturer info to device plugin > -- > > Key: CB-7285 > URL: https://issues.apache.org/jira/browse/CB-7285 > Project: Apache Cordova > Issue Type: New Feature > Components: Plugin Device >Reporter: Ian Clelland >Priority: Minor > > bq.For some platforms it makes sense to be able to list the Manufacturer for > a device. These changes allow retrieval of manufacturer name for Android, iOS > & Blackberry. Have not added to other platforms as I have no access to those > or know the API's. > See https://github.com/apache/cordova-plugin-device/pull/20 -- This message was sent by Atlassian JIRA (v6.2#6252)
