[jira] [Commented] (CB-7668) Android: Crop image

[Ray Shan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216375#comment-15216375
 ] 

Ray Shan commented on CB-7668:
--

Thanks for your notes Richard. Will create new issue.

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212263#comment-15212263
 ] 

Richard B Knoll commented on CB-7668:
-

[~rayshan] Yeah, I have seen that behavior as well. I would advise avoiding the 
allowEdit parameter altogether on Android. We use an undocumented API, so we 
can't really guarantee that it will work on all devices (there is no real 
built-in way to do cropping in Android). If image editing is necessary to your 
application, your best option right now might be to look for another plugin 
that actually implements its own cropping utility instead of using intents to 
find the installed one. That being said, go ahead and create an issue for the 
Google Photos thing

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Ray Shan (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212216#comment-15212216
 ] 

Ray Shan commented on CB-7668:
--

[~riknoll] With a Samsung device on Marshmallow with allowEdit: true, I noticed 
if user chooses system Gallery app, crop UI is shown, but if user chooses 
Google Photos app, crop UI isn't shown.

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14990956#comment-14990956
 ] 

Richard B Knoll commented on CB-7668:
-

Another thing that seems to have happened with Marshmallow is that allowEdit is 
completely unsupported when selecting from the gallery. When I specify that 
flag on my device all that happens is that the Google Photos image picker comes 
up instead of the normal behavior (no crop screen is ever given).

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982828#comment-14982828
 ] 

ASF subversion and git services commented on CB-7668:
-

Commit 5ff225d8dfc6b7868c8e2ce38e58c6bfad860402 in cordova-plugin-camera's 
branch refs/heads/master from Richard Knoll
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-camera.git;h=5ff225d 
]

CB-7668 android: Adding a sterner warning for allowedit on Android


> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982830#comment-14982830
 ] 

ASF GitHub Bot commented on CB-7668:


Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-camera/pull/130


> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981199#comment-14981199
 ] 

ASF GitHub Bot commented on CB-7668:


Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/130#issuecomment-152308660
  
@infil00p please review


> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981197#comment-14981197
 ] 

ASF GitHub Bot commented on CB-7668:


GitHub user riknoll opened a pull request:

https://github.com/apache/cordova-plugin-camera/pull/130

CB-7668 Adding a sterner warning for allowedit on Android

Adds a much clearer warning about `allowEdit` on Android to the README. 
That particular feature has been the cause of many JIRA issues (see CB-7668) 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-plugin-camera 
allow-edit-warning

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-camera/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #130


commit b97fadf332904cbe7cc0aa03002a9902e523abdd
Author: Richard Knoll 
Date:   2015-10-29T18:18:47Z

CB-7668 Adding a sterner warning for allowedit on Android




> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979323#comment-14979323
 ] 

Joe Bowser commented on CB-7668:


Right now we have support for the Google Photos crop.  Google Photos is on deck 
on every phone that has the Google Experience.  That said, this doesn't work on 
the Xiaomi phones, and I haven't tested it on any Amazon devices.

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979310#comment-14979310
 ] 

Richard B Knoll commented on CB-7668:
-

[~bowserj] I'll write up a new warning/explanation for the docs and submit a 
PR. Maintaining our own cropping UI sounds cumbersome, so I am inclined to 
agree with your idea of leaving this to third party plugins if they are 
adequate (at least in the near term). I'm guessing we shouldn't point to 
specific third party projects, but I'll mention that they exist so developers 
know to look for them. Do you think there is value in leaving this issue open? 
I've definitely seen others with the same problem, so we might want to consider 
it for a future roadmap. If third party plugins provide a good answer we should 
let them, but I'm not very familiar with what the landscape is like there or 
how to tell if the problem is solved. We might close this as "later" and 
revisit it if there is more JIRA activity.

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Joe Bowser (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977221#comment-14977221
 ] 

Joe Bowser commented on CB-7668:


[~riknoll] Assigning this to you since you're currently wading through the 
aftermath.  If this feature doesn't make sense, I'm fine with closing this.

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>Assignee: Richard B Knoll
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Richard B Knoll (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14949703#comment-14949703
 ] 

Richard B Knoll commented on CB-7668:
-

As [~agrieve] mentioned, Android does try and use the 
com.android.camera.action.CROP intent to find an application that can handle 
image cropping and use that. Unfortunately, this is [not an officially 
supported API in the Android 
SDK|https://groups.google.com/forum/#!topic/android-developers/LdZHUjkmGSw] and 
works only because most devices come with an application that handles that 
particular Intent (Google Plus Photos). The plugin documentation should 
probably have a clearly stated warning that using this feature on Android is 
unpredictable and may break in the future if Google Plus Photos decides to 
remove its support for that Intent.

> Android: Crop image
> ---
>
> Key: CB-7668
> URL: https://issues.apache.org/jira/browse/CB-7668
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: Plugin Camera
>Reporter: David Vielhuber
>
> Hello!
> On iOS it is possible to crop an image afterwards when set to targetWidth and 
> targetHeight natively.
> On Android this is not possible. I now have to program an individual solution.
> Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-7668) Android: Crop image

[Andrew Grieve (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153299#comment-14153299
 ] 

Andrew Grieve commented on CB-7668:
---

I believe this actually does exist for Android if you set allowEdit=true in the 
options. It does it via the com.android.camera.action.CROP intent. The caveat 
is that there are cases where phones ship without handlers for this intent, and 
so the crop step is just skipped.

 Android: Crop image
 ---

 Key: CB-7668
 URL: https://issues.apache.org/jira/browse/CB-7668
 Project: Apache Cordova
  Issue Type: New Feature
  Components: Plugin Camera
Reporter: David Vielhuber

 Hello!
 On iOS it is possible to crop an image afterwards when set to targetWidth and 
 targetHeight natively.
 On Android this is not possible. I now have to program an individual solution.
 Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (CB-7668) Android: Crop image

[David Vielhuber (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153313#comment-14153313
 ] 

David Vielhuber commented on CB-7668:
-

Are you sure?

As stated in the official documentation 
(https://github.com/apache/cordova-plugin-camera/blob/master/doc/index.md) of 
the plugin, Android ignores the allowEdit parameter.

I tried it now with Android 4.4 with allowEdit true and 
targetWidth/targetHeight and it simply skips and does not provide an UI to crop 
the image.

 Android: Crop image
 ---

 Key: CB-7668
 URL: https://issues.apache.org/jira/browse/CB-7668
 Project: Apache Cordova
  Issue Type: New Feature
  Components: Plugin Camera
Reporter: David Vielhuber

 Hello!
 On iOS it is possible to crop an image afterwards when set to targetWidth and 
 targetHeight natively.
 On Android this is not possible. I now have to program an individual solution.
 Are there plans to integrate this natively in the future?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)